Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: u4O2Y3wRZUDKWEU4BfR/UXYt9WIB/B3Pyglj49Kw3BDRI7rSbiZOdMlMbi9G+ss5RKT40+rm8y
 GVw2Mq5iPFkykP2NfcKHZmrxRI/mQP0HD8UnaIz/Bbj1ai8kvO6r0wIHP0mCayXkrP5PUtUHyp
 8zp4EBTt1hud94ttc4zmy4Zn+EipHdZgs36MR8CU9xJHRps8I9gYm9ELxLGuDeJmMivVL+GwCF
 y9JSV43P4/Tw6rlqquFHjeXY0hQwMghKu4bTWMul5zItRT+ID7EydEe+lcOXHySU7EVdSOO8kq
 XS0=
From:   Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To:     Hui Su <sh_def@163.com>, "axboe@kernel.dk" <axboe@kernel.dk>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] blk: use REQ_OP_WRITE instead of hard code
Thread-Topic: [PATCH] blk: use REQ_OP_WRITE instead of hard code
Thread-Index: AQHWpiEFu+/IMnkTMUW1yQ9XseklJg==
Date:   Mon, 19 Oct 2020 14:09:40 +0000
Message-ID: <SN4PR0401MB3598441A5D53ED264496CF419B1E0@SN4PR0401MB3598.namprd04.prod.outlook.com>
References: <20201019135059.GA16475@rlk>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 56114b20-50dc-43e9-5ca0-08d874389f23
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2020 14:09:40.8161
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cFEY3tK+OxYvviypG8mHn6xtitpkGRG3GYGsmSyaqyo5QftJn/NiTUKUij6kkv0/X1/WhYl5XYRi49reqtuUlVSXmlKraYGT+pwp/akD4bU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0401MB3597
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19/10/2020 16:06, Hui Su wrote:=0A=
> use REQ_OP_WRITE instead of hard code in=0A=
> op_is_write().=0A=
> =0A=
> Signed-off-by: Hui Su <sh_def@163.com>=0A=
> ---=0A=
>  include/linux/blk_types.h | 2 +-=0A=
>  1 file changed, 1 insertion(+), 1 deletion(-)=0A=
> =0A=
> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h=0A=
> index 7d7c13238fdb..7b9b02378c24 100644=0A=
> --- a/include/linux/blk_types.h=0A=
> +++ b/include/linux/blk_types.h=0A=
> @@ -440,7 +440,7 @@ static inline void bio_set_op_attrs(struct bio *bio, =
unsigned op,=0A=
>  =0A=
>  static inline bool op_is_write(unsigned int op)=0A=
>  {=0A=
> -	return (op & 1);=0A=
> +	return (op & REQ_OP_WRITE);=0A=
=0A=
op_is_write() returns true for every req_op that writes to a device (they a=
ll have =0A=
the lowest bit set), while REQ_OP_WRITE means a WRITE. You'll change the se=
mantics=0A=
with this patch.=0A=