Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp3232161pxu; Mon, 19 Oct 2020 07:17:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNV3D28UDn59dIE7KUVuIn/Av/TEjassZODaRfSWWXOimPdwGglAENZS0JICD/gWkXeN67 X-Received: by 2002:a05:6402:601:: with SMTP id n1mr16161edv.240.1603117052674; Mon, 19 Oct 2020 07:17:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603117052; cv=none; d=google.com; s=arc-20160816; b=OC/1xjC1by1YFYV28LApG2TQD85uPggvVpEsV1JJgvIuaam92QcF9lU2FCdAZbWfe5 kpOJ9wmXsmmBQpOiRvyj5DkgfyOP6TewGTCmZLaKAnPj4XdSIwh0hwDoh55gkC0WnXtP BPFEnfleTZjd/nGXV+riGhKsOxsHjE8gYoeuEs/4nnMfvv9gTkCGx+s2ZIWfWS3t2JgY APOrdQFcuAgKLTAnMvlC2CAwLblt2hVfJ8yzoYgpPxGJp1xfZlNecI1d3EmUrbImVE0z ZeKlGOQ0xzMUYhsA+EAYzORq/juLW93LaZ2bYhAHAB0WXjqcacrlFaxKfmDxDsF6RBOA Seyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=/aVlQXLfK1hOQxfMVIouEj2i2xXsvrmEfcyi4AYtsuw=; b=YG5hbTmYdm2f6TjoxD1ZPPlSeJhGhSJE9EGR3M2D8mjTmH/fGzhWWDH4RU4Rda4IbD T34aXAm9jWNYTbQyN0j+LZkEkhA4WYlai3B+pu36loY9EomV/UFHrp33DCGhXMywtil0 DFGHA6iVLO/qW7tGZ4jxAACZ91X5/D+o6z4i5sW8E5RmjGKivhOYeAu4PvPVwhO8eQO/ kYFwMKbHInaYhQFqe6LaddqZBfKc73DnrTbW4cywzkI5BoTy/oLKdw7mzt+T1LqT4D4I kYztnjKQmvzvFCbMBXQzLGLlFaH4KqO/3ouVAOzx5o6MAt+zNXBPBjSkmow7KXDxcxMc R5ew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bu15si7665370edb.481.2020.10.19.07.17.10; Mon, 19 Oct 2020 07:17:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729278AbgJSOOg (ORCPT + 99 others); Mon, 19 Oct 2020 10:14:36 -0400 Received: from foss.arm.com ([217.140.110.172]:58712 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728802AbgJSOOg (ORCPT ); Mon, 19 Oct 2020 10:14:36 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D3128D6E; Mon, 19 Oct 2020 07:14:35 -0700 (PDT) Received: from [192.168.178.2] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 25BAE3F66E; Mon, 19 Oct 2020 07:14:33 -0700 (PDT) Subject: Re: [PATCH 3/2] sched/cpupri: Remap CPUPRI_NORMAL to MAX_RT_PRIO-1 To: Peter Zijlstra Cc: Ingo Molnar , Juri Lelli , Vincent Guittot , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , linux-kernel@vger.kernel.org References: <20200922083934.19275-1-dietmar.eggemann@arm.com> <20201014194858.GC2974@worktop.programming.kicks-ass.net> From: Dietmar Eggemann Message-ID: <20388bee-9534-3ca0-4916-0bd0b9852189@arm.com> Date: Mon, 19 Oct 2020 16:14:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201014194858.GC2974@worktop.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/10/2020 21:48, Peter Zijlstra wrote: [...] > + switch (prio) { > + case CPUPRI_INVALID: > + cpupri = CPUPRI_INVALID; /* -1 */ > + break; > + > + case 0...98: kernel/sched/cpupri.c:54:7: error: too many decimal points in number 54 | case 0...98: | ^~~~~~ There need to be spaces around the ellipses. Otherwise LGTM.