Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp3292397pxu; Mon, 19 Oct 2020 08:37:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdY8CMTid5RHLXe67kmhwvnBuV3V3eaFiP+DBnmi5a8WG5i3NgtFZ1dsYi8ZG13wZuopMC X-Received: by 2002:a05:6402:142c:: with SMTP id c12mr384596edx.41.1603121825736; Mon, 19 Oct 2020 08:37:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603121825; cv=none; d=google.com; s=arc-20160816; b=DhglKj11HB0fTiuou4vNMoKavEA70LV/ONlJBrtAzEdhyvf0cK1xIHTaSMQMrpWPzW 5CLzllMsVkUZVz3gt0YaawWg+6vzb+fXjkPA5KVMRxX9QCDQOxPXYNax7hCCARIw15Ps tp+k64G8Z9U3OV12lPMkAKN8XAu4yo7bhqGA3D0giBVsXxkg4hcDGXQamYQXqB8TDc1c 9Y9Z6Y5x2aZeK7frgPEH8ncM7kZLeDFN7WOLJGycjdwyrYf//Fs0PKO4SxVl7UlVMn4r vlEI1Qs8xlRnFna2gq4zBchEEXd3u1OHd8R7SEYpXLkF0ybOROhmEsRPlIGay3sUR3mk mPwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=G6IqZPH/xvsjeV+KO4PrfwtgG9S8DY4P3ygKvGFV+Wk=; b=KIHPsFivZKu/2hkxly2gDrON7zDMAm2dLCqVpP+65ruveQnSxnyhkuxFAtMVtsq0ua bTUB4mTyLl+tys9/T+rjc6s0ruBqRTRhXH2FOkq4SerL4/7J9HHMQ9i3MCVSLgsoFOhj tUNXwCJhEzk86Yp4sep2DWPyuwXrt3LQlPJEb3Ias0b9NFPFd8wHwFYuA6UEizRPAZF3 EOuMnDHIihjblAdNw37aunCiXPs+fGy6ZYCyHCcM/T7J9koGc0BUbthNXSpeR4oxbXGA MzVgvpauVr0WF2IZVjcPt5PXk1JKCMwK4GRwmj1ckq3v3RRKYEdc9JiJ/aBjz1JAv5OU T/XQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="Y/TH7WtZ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dt1si154109ejc.566.2020.10.19.08.36.38; Mon, 19 Oct 2020 08:37:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="Y/TH7WtZ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729987AbgJSPcy (ORCPT + 99 others); Mon, 19 Oct 2020 11:32:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729075AbgJSPcx (ORCPT ); Mon, 19 Oct 2020 11:32:53 -0400 Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A4DBC0613CE for ; Mon, 19 Oct 2020 08:32:52 -0700 (PDT) Received: by mail-il1-x141.google.com with SMTP id l16so516644ilj.9 for ; Mon, 19 Oct 2020 08:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=G6IqZPH/xvsjeV+KO4PrfwtgG9S8DY4P3ygKvGFV+Wk=; b=Y/TH7WtZNNRhTiDN1VAyBBdljrCIJKN6XT05Ag7KnMLwK12/Ung3jtuMQBGYi5vmhL 72/8lisWN3QniaCEz9Ib59crBAL4W1ZrUu/PaALYAA96srEE+L40iZ2Fnizhbkk2angL n6p7BdbI7RXC6n4N5OwCcPTdftLKF1OCH+NUNUPpmCAhDrhdkH82Rv1C7nl9I/ojaHcV kmS7yyp69BJmWKnQSo8qs4q3hxKII5v/b9LrtNGumGkzr/60C+mgBR70JPZ1kZ0Da7c/ NnasKweHHQHA+GwqdLowZhENOTy302Sg6tYVr8qE71tIiiRNXAfefesK4386lqvMYonD vH1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=G6IqZPH/xvsjeV+KO4PrfwtgG9S8DY4P3ygKvGFV+Wk=; b=N/d8D1plAioxttygQcdxrAy1cfYmRf9/Ivr6AqBgrsv18Uvil4mldM5yKL/RHNwjhP A9APYXXnRFAkvhD3Y/25mJzO1LzNPC6DqslKiokle0mZiiPhhbC3hvGRpn0WGiv66NKl e/DCFcptK/kyyeJEzBh3OVAOIo/0hhjIS/gwJP7DvS7SpNeszwo28/enIqaUQx3sFtdM yUHrOVwA9E7aFx2U0mTgRIoKDsAKsuhah3m0w2fnn/gReuL+h11xzF4TSq1lQ9Cvq3P5 0E92DN7oZBuURdCFYW+R07q87qT9nwyIz3aoJYQWVnSV7w0R29DDp79E4nYCokrjttmH T9fQ== X-Gm-Message-State: AOAM531noPso1Jz6sDoznXH7sXV3j4gsitNUKpzpeYzMpaKm9LV0LQPW B1HIqdOn7fxKw77K7z4utIRgew== X-Received: by 2002:a92:dc8f:: with SMTP id c15mr387228iln.293.1603121571501; Mon, 19 Oct 2020 08:32:51 -0700 (PDT) Received: from [192.168.1.30] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id z200sm65790iof.47.2020.10.19.08.32.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Oct 2020 08:32:50 -0700 (PDT) Subject: Re: [PATCH] zram: Fix __zram_bvec_{read,write}() locking order To: Peter Zijlstra , Minchan Kim Cc: Mikhail Gavrilov , Linux List Kernel Mailing , linux-block@vger.kernel.org, Mike Galbraith , ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, bigeasy@linutronix.de, Andrew Morton References: <20201016124009.GQ2611@hirez.programming.kicks-ass.net> <20201016153324.GA1976566@google.com> <20201019101353.GJ2628@hirez.programming.kicks-ass.net> From: Jens Axboe Message-ID: Date: Mon, 19 Oct 2020 09:32:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201019101353.GJ2628@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/19/20 4:13 AM, Peter Zijlstra wrote: > > Mikhail reported a lockdep spat detailing how __zram_bvec_read() and > __zram_bvec_write() use zstrm->lock and zspage->lock in opposite order. Applied, thanks. -- Jens Axboe