Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 6QNar7c2ScLOkgZ7EO2D9jNDDa1TuqBTsORTg5ON9eJHiVmesr4xbMmPKDkw4y+9Myre9WGc7F
 G/y3eS79SXKw==
IronPort-SDR: h9gTNV91jXeK4rF3ZmFqRqfezlbO+S+1Qumj3cOgPg2iF9NH3Hbq4IPJziGLDbUbT8n0RL780u
 SK0j1v53b0Bw==
Date:   Mon, 19 Oct 2020 10:38:41 -0700
From:   Sean Christopherson <sean.j.christopherson@intel.com>
To:     Dave Hansen <dave.hansen@intel.com>
Cc:     Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>, x86@kernel.org,
        linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jethro Beekman <jethro@fortanix.com>,
        Darren Kenny <darren.kenny@oracle.com>,
        akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com,
        asapek@google.com, bp@alien8.de, cedric.xing@intel.com,
        chenalexchen@google.com, conradparker@google.com,
        cyhanish@google.com, haitao.huang@intel.com, kai.huang@intel.com,
        kai.svahn@intel.com, kmoy@google.com, ludloff@google.com,
        luto@kernel.org, nhorman@redhat.com, npmccallum@redhat.com,
        puiterwijk@redhat.com, rientjes@google.com, tglx@linutronix.de,
        yaozhangx@google.com, mikko.ylinen@intel.com
Subject: Re: [PATCH v39 05/24] x86/sgx: Add wrappers for ENCLS leaf functions
Message-ID: <20201019173840.GA22119@linux.intel.com>
References: <20201003045059.665934-1-jarkko.sakkinen@linux.intel.com>
 <20201003045059.665934-6-jarkko.sakkinen@linux.intel.com>
 <a1ec29d2-41ab-fbac-6a06-8755742328d9@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a1ec29d2-41ab-fbac-6a06-8755742328d9@intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

On Mon, Oct 19, 2020 at 07:30:32AM -0700, Dave Hansen wrote:
> On 10/2/20 9:50 PM, Jarkko Sakkinen wrote:
> > +/**
> > + * encls_failed() - Check if an ENCLS leaf function failed
> > + * @ret:	the return value of an ENCLS leaf function call
> > + *
> > + * Check if an ENCLS leaf function failed. This happens when the leaf function
> > + * causes a fault that is not caused by an EPCM conflict or when the leaf
> > + * function returns a non-zero value.
> > + */
> > +static inline bool encls_failed(int ret)
> > +{
> > +	int epcm_trapnr;
> > +
> > +	if (boot_cpu_has(X86_FEATURE_SGX2))
> > +		epcm_trapnr = X86_TRAP_PF;
> > +	else
> > +		epcm_trapnr = X86_TRAP_GP;
> 
> So, the SDM makes it sound like the only thing that changes from
> SGX1->SGX2 is the ENCLS leafs supported.  Since the kernel doesn't use
> any SGX2 leaf functions, this would imply there is some other
> architecture change which is visible.  *But* I don't see any evidence of
> this in the SDM, at least from a quick scan.
> 
> Why is this here?

SGX1 CPUs take an erratum on the #PF behavior, e.g. "KBW90 Violation of Intel
SGX Access-Control Requirements Produce #GP Instead of #PF".

https://www.intel.com/content/dam/www/public/us/en/documents/specification-updates/xeon-e3-1200v6-spec-update.pdf

> > +	if (ret & ENCLS_FAULT_FLAG)
> > +		return ENCLS_TRAPNR(ret) != epcm_trapnr;
> > +
> > +	return !!ret;
> > +}
> 
>