Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: gB9fCH3xMs096NXojgxhqxE6g7lQLGQdCnrIIBmJwE5MLHOfqYkDoq2ID9CVGR3Zh5Lei6R+oW
 7FoKZtAngqhg==
IronPort-SDR: MbfntzzDOkBTt66vMeL8cpge34ZUlAD51ktwVXEb124MwqDEmKD9Q6mytHhpFCOq8MygzWh9ES
 JNA+/Fun+0PA==
Date:   Mon, 19 Oct 2020 12:17:04 +0800
From:   Xu Yilun <yilun.xu@intel.com>
To:     Tom Rix <trix@redhat.com>
Cc:     mdf@kernel.org, linux-fpga@vger.kernel.org,
        linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
        lgoncalv@redhat.com, hao.wu@intel.com, yilun.xu@intel.com
Subject: Re: [PATCH 0/2] UIO support for dfl devices
Message-ID: <20201019041704.GC16172@yilunxu-OptiPlex-7050>
References: <1602828151-24784-1-git-send-email-yilun.xu@intel.com>
 <3dcc1b4e-d0fd-0586-ea87-eada0c557bed@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3dcc1b4e-d0fd-0586-ea87-eada0c557bed@redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

On Fri, Oct 16, 2020 at 09:40:03AM -0700, Tom Rix wrote:
> 
> On 10/15/20 11:02 PM, Xu Yilun wrote:
> > This patchset supports some dfl device drivers written in userspace.
> >
> > The usage is like:
> >
> >  # echo dfl_dev.1 > /sys/bus/dfl/drivers/<kernel driver>/unbind
> >  # echo dfl-uio-pdev > /sys/bus/dfl/devices/dfl_dev.1/driver_override
> >  # echo dfl_dev.1 > /sys/bus/dfl/drivers_probe
> >
> >
> > Xu Yilun (2):
> >   fpga: dfl: add driver_override support
> >   fpga: dfl: add the userspace I/O device support for DFL devices
> >
> >  Documentation/ABI/testing/sysfs-bus-dfl | 28 +++++++++--
> >  drivers/fpga/Kconfig                    | 10 ++++
> >  drivers/fpga/Makefile                   |  1 +
> >  drivers/fpga/dfl-uio-pdev.c             | 83 +++++++++++++++++++++++++++++++++
> >  drivers/fpga/dfl.c                      | 54 ++++++++++++++++++++-
> >  include/linux/dfl.h                     |  2 +
> >  6 files changed, 173 insertions(+), 5 deletions(-)
> >  create mode 100644 drivers/fpga/dfl-uio-pdev.c
> 
> This is a neat new feature.
> 
> Should something be added to Documentation/fpga/dfl.rst ?

Yes, I could add the Doc.

> 
> Overall, patchset looks good.
> 
> Tom