Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932453AbWHKTqy (ORCPT ); Fri, 11 Aug 2006 15:46:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932421AbWHKTqy (ORCPT ); Fri, 11 Aug 2006 15:46:54 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:19902 "EHLO e32.co.us.ibm.com") by vger.kernel.org with ESMTP id S932370AbWHKTqx (ORCPT ); Fri, 11 Aug 2006 15:46:53 -0400 Date: Fri, 11 Aug 2006 14:46:47 -0500 To: Olof Johansson Cc: Arnd Bergmann , Jens Osterkamp , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, netdev@vger.kernel.org, James K Lewis Subject: Re: [PATCH 4/4]: powerpc/cell spidernet ethtool -i version number info. Message-ID: <20060811194647.GO10638@austin.ibm.com> References: <20060811180013.GB6550@pb15.lixom.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11 From: linas@austin.ibm.com (Linas Vepstas) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1061 Lines: 35 Hi Olof, Olof Johansson writes: > On Fri, Aug 11, 2006 at 12:11:17PM -0500, Linas Vepstas wrote: > > > This patch adds version information as reported by > > ethtool -i to the Spidernet driver. > > Why does a driver that's in the mainline kernel need to have a version > number besides the kernel version? I'll let Jim be the primary defender. From what I can tell, "that's the way its done". For example: linux-2.6.18-rc3-mm2 $ grep MODULE_VERSION */*/*.c |wc 164 245 9081 > I can understand it for drivers like e1000 that Intel maintain outside > of the kernel as well. But spidernet is a fully mainline maintained > driver, right? Yes, the spidernet is a Linux-kernel only driver. --linas p.s. very strange, but I did not see your original email; only saw Jim's reply. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/