Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 19 Oct 2020 09:05:41 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Alexander Kochetkov <al.kochet@gmail.com>
Cc:     Mark Brown <broonie@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: spi-sun6i: enable autosuspend feature
Message-ID: <20201019070541.qy3v2r3sg5itdhds@gilmour.lan>
References: <20201016083826.31427-1-al.kochet@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="zqg3emlloxikctnv"
Content-Disposition: inline
In-Reply-To: <20201016083826.31427-1-al.kochet@gmail.com>
Precedence: bulk


--zqg3emlloxikctnv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, Oct 16, 2020 at 11:38:26AM +0300, Alexander Kochetkov wrote:
> If SPI is used for periodic polling any sensor, significant delays
> sometimes appear. Switching on module clocks during resume lead to delays.
> Enabling autosuspend mode causes the controller to not suspend between
> SPI transfers and the delays disappear.
>=20
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
> ---
>  drivers/spi/spi-sun6i.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c
> index 38e5b8af7da6..4cc0280e934c 100644
> --- a/drivers/spi/spi-sun6i.c
> +++ b/drivers/spi/spi-sun6i.c
> @@ -22,6 +22,8 @@
> =20
>  #include <linux/spi/spi.h>
> =20
> +#define SUN6I_AUTOSUSPEND_TIMEOUT	2000
> +
>  #define SUN6I_FIFO_DEPTH		128
>  #define SUN8I_FIFO_DEPTH		64
> =20
> @@ -639,9 +641,10 @@ static int sun6i_spi_probe(struct platform_device *p=
dev)
>  		goto err_free_dma_rx;
>  	}
> =20
> +	pm_runtime_set_autosuspend_delay(&pdev->dev, SUN6I_AUTOSUSPEND_TIMEOUT);
> +	pm_runtime_use_autosuspend(&pdev->dev);
>  	pm_runtime_set_active(&pdev->dev);
>  	pm_runtime_enable(&pdev->dev);
> -	pm_runtime_idle(&pdev->dev);

You should also mention why pm_runtime_idle isn't useful anymore in your
commit log.

Thanks!
Maxime

--zqg3emlloxikctnv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX406jQAKCRDj7w1vZxhR
xQZMAP9MvzwkJ7KYvidr8Tqy6Uun4yiI03CcELJ3laGSQezVEwD/diF7Gju+JH4x
NZedwB1YqwnhUGqHXmb8Mf8hYxkjMgY=
=bZcy
-----END PGP SIGNATURE-----

--zqg3emlloxikctnv--