Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp3536430pxu; Mon, 19 Oct 2020 14:48:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4icnGnTP7LaFkWXtgbNUs/o2jdw3uRORxeapE+byG/du4xjrUjiv5yQRRopywb46WFzjT X-Received: by 2002:a17:906:8248:: with SMTP id f8mr2002336ejx.292.1603144125084; Mon, 19 Oct 2020 14:48:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603144125; cv=none; d=google.com; s=arc-20160816; b=iFXUWympxju51bF8sk7wv2pxgw+SMVNxv3p+aWjNOCJADvdf7M+hFg/ApAAC2x0KD+ v7Pl3eUqzf98PpNi4ICL9nUyRYuD1GJAsIfZJM6zCs7pI3xiJSJ/F5ENTZgfITocbdjQ A9jm7ljETRt1p271yxJxB/gi9gXCqjtagiSkK/JPuTvD14xO0PALuZnemliht9hfI+o2 AhGWz8Eo1es2q4OjY8PCnZS2itsPIejuytxHJ8l42Xvc3yyd5ioGfaHKPIvO0maNgh2g 3EbCWCah4FKQgmBjyAw1mkxOFxA+YXQbLA7o9QbtkQ3txLnaePnoYBzU1rR850iCvbSu Bgdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=M4+HQ8ZGM7qrt+zQTJTKocUPQ5Qklf/bdYUl6x0loMI=; b=0i5eWET9122piHvY/bbI1FFauGbZ7BRD6r4jAFEry8XTkoZwf3AaOG17dxnc3US/dL WvG2day4B+2QZiUJ/UOwjT9PWPl86xOKh0Oo+/d7eErAjB/8HxfYbHT4NqOVQlYya3XO Yn5rh1a2vj6VOLd+YAiiChITFZNGCBIIZDJxmpmANahl9Ew8tF1EUgxfaIZtmUNTYscd +3HVVcpOer82kea4dIVLpwBEj9Y1FX/xraoAeHHSS10z4jl+Ta5zIj0C4d4kbSMJ+50o dFlNLBq6mv8VOhUuY3htK6D4jL/GfbT5lVHYFi/L4SsHVMbZd2Aj4GtqTIsKgQSyLHjK xf5Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j5si688295edc.5.2020.10.19.14.48.23; Mon, 19 Oct 2020 14:48:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730269AbgJSJ0I (ORCPT + 99 others); Mon, 19 Oct 2020 05:26:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:43562 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726015AbgJSJ0I (ORCPT ); Mon, 19 Oct 2020 05:26:08 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3605CACD8; Mon, 19 Oct 2020 09:26:07 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 8C1C51E1340; Mon, 19 Oct 2020 11:26:06 +0200 (CEST) Date: Mon, 19 Oct 2020 11:26:06 +0200 From: Jan Kara To: Roman Anufriev Cc: linux-kernel@vger.kernel.org, jack@suse.cz, dmtrmonakhov@yandex-team.ru Subject: Re: [PATCH] fs/quota: update quota state flags scheme with project quota flags Message-ID: <20201019092606.GB30825@quack2.suse.cz> References: <1602989814-28922-1-git-send-email-dotdot@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1602989814-28922-1-git-send-email-dotdot@yandex-team.ru> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 18-10-20 05:56:54, Roman Anufriev wrote: > Current quota state flags scheme doesn't include project quota and thus > shows all flags after DQUOT_USAGE_ENABLED wrong. Fix this and also add > DQUOT_NOLIST_DIRTY to the scheme. > > Signed-off-by: Roman Anufriev Thanks. I've added the patch to my tree. Honza > --- > include/linux/quota.h | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/include/linux/quota.h b/include/linux/quota.h > index 27aab84..18ebd39 100644 > --- a/include/linux/quota.h > +++ b/include/linux/quota.h > @@ -448,17 +448,18 @@ struct quota_format_type { > }; > > /** > - * Quota state flags - they actually come in two flavors - for users and groups. > + * Quota state flags - they come in three flavors - for users, groups and projects. > * > * Actual typed flags layout: > - * USRQUOTA GRPQUOTA > - * DQUOT_USAGE_ENABLED 0x0001 0x0002 > - * DQUOT_LIMITS_ENABLED 0x0004 0x0008 > - * DQUOT_SUSPENDED 0x0010 0x0020 > + * USRQUOTA GRPQUOTA PRJQUOTA > + * DQUOT_USAGE_ENABLED 0x0001 0x0002 0x0004 > + * DQUOT_LIMITS_ENABLED 0x0008 0x0010 0x0020 > + * DQUOT_SUSPENDED 0x0040 0x0080 0x0100 > * > * Following bits are used for non-typed flags: > - * DQUOT_QUOTA_SYS_FILE 0x0040 > - * DQUOT_NEGATIVE_USAGE 0x0080 > + * DQUOT_QUOTA_SYS_FILE 0x0200 > + * DQUOT_NEGATIVE_USAGE 0x0400 > + * DQUOT_NOLIST_DIRTY 0x0800 > */ > enum { > _DQUOT_USAGE_ENABLED = 0, /* Track disk usage for users */ > -- > 2.7.4 > -- Jan Kara SUSE Labs, CR