Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add usb1 node
To:     Fabien Parent <fparent@baylibre.com>, linux-kernel@vger.kernel.org,
        linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Cc:     robh+dt@kernel.org
References: <20201014162404.1312544-1-fparent@baylibre.com>
 <20201014162404.1312544-2-fparent@baylibre.com>
From:   Matthias Brugger <matthias.bgg@gmail.com>
Message-ID: <d2dc75dd-04ec-d1ec-a84b-f7c5cccafa73@gmail.com>
Date:   Mon, 19 Oct 2020 12:26:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201014162404.1312544-2-fparent@baylibre.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 14/10/2020 18:24, Fabien Parent wrote:
> The MT8516 has 2 USB instances. Add support for the second USB instance.
> usb1 can only work in host mode.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>

Applied to v5.10-tmp/dts64

Thanks!

> ---
>   arch/arm64/boot/dts/mediatek/mt8516.dtsi | 21 +++++++++++++++++++++
>   1 file changed, 21 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> index 50049b6c1ba7..eca7969e15ab 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> @@ -455,6 +455,20 @@ usb0: usb@11100000 {
>   			status = "disabled";
>   		};
>   
> +		usb1: usb@11190000 {
> +			compatible = "mediatek,mtk-musb";
> +			reg = <0 0x11190000 0 0x1000>;
> +			interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_LOW>;
> +			interrupt-names = "mc";
> +			phys = <&usb1_port PHY_TYPE_USB2>;
> +			clocks = <&topckgen CLK_TOP_USB>,
> +				 <&topckgen CLK_TOP_USBIF>,
> +				 <&topckgen CLK_TOP_USB_1P>;
> +			clock-names = "main","mcu","univpll";
> +			dr_mode = "host";
> +			status = "disabled";
> +		};
> +
>   		usb_phy: usb@11110000 {
>   			compatible = "mediatek,generic-tphy-v1";
>   			reg = <0 0x11110000 0 0x800>;
> @@ -469,6 +483,13 @@ usb0_port: usb-phy@11110800 {
>   				clock-names = "ref";
>   				#phy-cells = <1>;
>   			};
> +
> +			usb1_port: usb-phy@11110900 {
> +				reg = <0 0x11110900 0 0x100>;
> +				clocks = <&topckgen CLK_TOP_USB_PHY48M>;
> +				clock-names = "ref";
> +				#phy-cells = <1>;
> +			};
>   		};
>   
>   		auxadc: adc@11003000 {
>