Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] drm/amdgpu: remove unneeded break
To:     trix@redhat.com, harry.wentland@amd.com, sunpeng.li@amd.com,
        alexander.deucher@amd.com, airlied@linux.ie, daniel@ffwll.ch,
        issor.oruam@gmail.com, Anthony.Koo@amd.com,
        Rodrigo.Siqueira@amd.com, Tony.Cheng@amd.com, Charlene.Liu@amd.com,
        yogesh.mohanmarimuthu@amd.com, Aric.Cyr@amd.com,
        Igor.Kravchenko@amd.com, colin.king@canonical.com,
        tao.zhou1@amd.com, Dennis.Li@amd.com, mario.kleiner.de@gmail.com
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20201019144311.18260-1-trix@redhat.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <2f951197-b93e-d0c9-153f-2ddd1b195b3f@amd.com>
Date:   Mon, 19 Oct 2020 16:55:27 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <20201019144311.18260-1-trix@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7] (2a02:908:1252:fb60:be8a:bd56:1f94:86e7) by AM3PR07CA0113.eurprd07.prod.outlook.com (2603:10a6:207:7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.11 via Frontend Transport; Mon, 19 Oct 2020 14:55:33 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 671db46f-a73c-468c-16ba-08d8743f09be
X-MS-TrafficTypeDiagnostic: MN2PR12MB4391:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MN2PR12MB4391D66E0D42BE7CC16D83F8831E0@MN2PR12MB4391.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:81;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: F3m8mzF9dwSdMaFP9d9EHL0i5/xXibe57gwEj4buB3EZSuUkbVJdAybcsT0rd55WSUzymIuh1hpWsOkJCvgdZpZRoHVaCNYRO3vt7z9g2LoDvmPF+ghCSqt7LoCrDoN6sMna7NWH28fATSGS87+T5FM4PPXxTyagE4hq/M1gAn35TLL8Cun8L79DPr6a2C4gvABJ/8e1Ni8KDHnYg68q2MIJj0exnb71iEuNtdblkBis2KxKPmfWy+f/GOmVY8DkEHkzESevjrLoahpFcSos4IY9FXOBCcYwq/ljPhjq+Xx23xy7XXq7o96iBNHgCWDx3g/QcQiRyPikI+F793r9W5uIcpw4/K1GZp9AKmGK6WWgi38gHLYLtCi6IqohRMfQcUR1G3vK9n6YgUiceZXd/g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3775.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(39860400002)(136003)(396003)(346002)(66556008)(66946007)(66476007)(2906002)(52116002)(316002)(6666004)(31686004)(5660300002)(2616005)(8676002)(8936002)(186003)(16526019)(4326008)(6486002)(478600001)(31696002)(86362001)(83380400001)(36756003)(921003)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: exZwpmzld1tCbhfp0SWSixvQvaofid9idOW6jdmOaPMPQzu/jWwd82mBZCojgkjN7ByTB/v1yDcxtlYR+j6xx6QK+vSXzxEHuaiva43Rh8CppTT0OCgJBWfmCHBPd9325Z3rK+wwGwWIilhKDm1D0JaHmMKJfB5mbA7nqwlMgY19Y/cOP/Z6xpXd2INPDALnvz4lmaQdhonRtTMSOrqtN3Gox3JYg6ReEMunMatvC4+CokcVIBBSSIalJXzhWenMjhwJhF1rgwQNKG+mOiCHoBsf0xnWJPf+xdZ9Y22t0tTxoqU8358a6cyQIcf6HnaoABFGU2pnDViUgtubG17di6nAMZRfXnYjL9AhQ8VYbBVaSGl1zhaxQKrfv7z/lKkbHIvNusQR4my2rehA2UtEZOvhqsoj0KgnMltXwD0184hCFD0Q39wnFx/nl60dyaVhSu1RwL4zNQbFCP2YjMOKOUcJ8dkGNAYfZWDoREJc+OpyZVKGOZGCYl9008rn1NK6cl0r4lhAqXX9e6W++6ACHvSevWSgQyUj3/6fAtbLnaoWeoyZf6FzIR1lsgtryWBrIzQzOxDR3w4RbWKQqWpqbhQo++e7YVaAaPbsLgKbag0R29Z1tWPVHOOhlobnROXHHeiOsU9hB2oXofSYKof4XfvgLseCNBS3nxA4g/Q3BO/2hn53zVk+LX8kEF4uThxfSRuiWcOj+aM2LJo9hONWMQ==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 671db46f-a73c-468c-16ba-08d8743f09be
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2020 14:55:37.2457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8QQdeJ4ymWS0MZVICcgi0p2EvLpui9xMI+ahwUoaQR3ykpt+vYQbvxdONHGnjV/M
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4391
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 19.10.20 um 16:43 schrieb trix@redhat.com:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return or break
>
> Signed-off-by: Tom Rix <trix@redhat.com>

Acked-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/display/dc/dce/dce_transform.c      | 1 -
>   drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 7 -------
>   drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 7 -------
>   drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 7 -------
>   drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 7 -------
>   drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c   | 7 -------
>   drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c   | 7 -------
>   7 files changed, 43 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> index 2a32b66959ba..130a0a0c8332 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> @@ -1330,7 +1330,6 @@ static bool configure_graphics_mode(
>   			REG_SET(OUTPUT_CSC_CONTROL, 0,
>   				OUTPUT_CSC_GRPH_MODE, 0);
>   			break;
> -			break;
>   		case COLOR_SPACE_SRGB_LIMITED:
>   			/* TV RGB */
>   			REG_SET(OUTPUT_CSC_CONTROL, 0,
> diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> index d741787f75dc..42c7d157da32 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> @@ -418,25 +418,18 @@ static int map_transmitter_id_to_phy_instance(
>   	switch (transmitter) {
>   	case TRANSMITTER_UNIPHY_A:
>   		return 0;
> -	break;
>   	case TRANSMITTER_UNIPHY_B:
>   		return 1;
> -	break;
>   	case TRANSMITTER_UNIPHY_C:
>   		return 2;
> -	break;
>   	case TRANSMITTER_UNIPHY_D:
>   		return 3;
> -	break;
>   	case TRANSMITTER_UNIPHY_E:
>   		return 4;
> -	break;
>   	case TRANSMITTER_UNIPHY_F:
>   		return 5;
> -	break;
>   	case TRANSMITTER_UNIPHY_G:
>   		return 6;
> -	break;
>   	default:
>   		ASSERT(0);
>   		return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> index 2bbfa2e176a9..382581c4a674 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> @@ -471,25 +471,18 @@ static int map_transmitter_id_to_phy_instance(
>   	switch (transmitter) {
>   	case TRANSMITTER_UNIPHY_A:
>   		return 0;
> -	break;
>   	case TRANSMITTER_UNIPHY_B:
>   		return 1;
> -	break;
>   	case TRANSMITTER_UNIPHY_C:
>   		return 2;
> -	break;
>   	case TRANSMITTER_UNIPHY_D:
>   		return 3;
> -	break;
>   	case TRANSMITTER_UNIPHY_E:
>   		return 4;
> -	break;
>   	case TRANSMITTER_UNIPHY_F:
>   		return 5;
> -	break;
>   	case TRANSMITTER_UNIPHY_G:
>   		return 6;
> -	break;
>   	default:
>   		ASSERT(0);
>   		return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> index b622b4b1dac3..7b4b2304bbff 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> @@ -446,25 +446,18 @@ static int map_transmitter_id_to_phy_instance(
>   	switch (transmitter) {
>   	case TRANSMITTER_UNIPHY_A:
>   		return 0;
> -	break;
>   	case TRANSMITTER_UNIPHY_B:
>   		return 1;
> -	break;
>   	case TRANSMITTER_UNIPHY_C:
>   		return 2;
> -	break;
>   	case TRANSMITTER_UNIPHY_D:
>   		return 3;
> -	break;
>   	case TRANSMITTER_UNIPHY_E:
>   		return 4;
> -	break;
>   	case TRANSMITTER_UNIPHY_F:
>   		return 5;
> -	break;
>   	case TRANSMITTER_UNIPHY_G:
>   		return 6;
> -	break;
>   	default:
>   		ASSERT(0);
>   		return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> index 16fe7344702f..3d782b7c86cb 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> @@ -383,25 +383,18 @@ static int map_transmitter_id_to_phy_instance(
>   	switch (transmitter) {
>   	case TRANSMITTER_UNIPHY_A:
>   		return 0;
> -	break;
>   	case TRANSMITTER_UNIPHY_B:
>   		return 1;
> -	break;
>   	case TRANSMITTER_UNIPHY_C:
>   		return 2;
> -	break;
>   	case TRANSMITTER_UNIPHY_D:
>   		return 3;
> -	break;
>   	case TRANSMITTER_UNIPHY_E:
>   		return 4;
> -	break;
>   	case TRANSMITTER_UNIPHY_F:
>   		return 5;
> -	break;
>   	case TRANSMITTER_UNIPHY_G:
>   		return 6;
> -	break;
>   	default:
>   		ASSERT(0);
>   		return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> index 5a5a9cb77acb..e9dd78c484d6 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> @@ -453,25 +453,18 @@ static int map_transmitter_id_to_phy_instance(
>   	switch (transmitter) {
>   	case TRANSMITTER_UNIPHY_A:
>   		return 0;
> -	break;
>   	case TRANSMITTER_UNIPHY_B:
>   		return 1;
> -	break;
>   	case TRANSMITTER_UNIPHY_C:
>   		return 2;
> -	break;
>   	case TRANSMITTER_UNIPHY_D:
>   		return 3;
> -	break;
>   	case TRANSMITTER_UNIPHY_E:
>   		return 4;
> -	break;
>   	case TRANSMITTER_UNIPHY_F:
>   		return 5;
> -	break;
>   	case TRANSMITTER_UNIPHY_G:
>   		return 6;
> -	break;
>   	default:
>   		ASSERT(0);
>   		return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> index 0eae8cd35f9a..9dbf658162cd 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> @@ -458,25 +458,18 @@ static int map_transmitter_id_to_phy_instance(
>   	switch (transmitter) {
>   	case TRANSMITTER_UNIPHY_A:
>   		return 0;
> -	break;
>   	case TRANSMITTER_UNIPHY_B:
>   		return 1;
> -	break;
>   	case TRANSMITTER_UNIPHY_C:
>   		return 2;
> -	break;
>   	case TRANSMITTER_UNIPHY_D:
>   		return 3;
> -	break;
>   	case TRANSMITTER_UNIPHY_E:
>   		return 4;
> -	break;
>   	case TRANSMITTER_UNIPHY_F:
>   		return 5;
> -	break;
>   	case TRANSMITTER_UNIPHY_G:
>   		return 6;
> -	break;
>   	default:
>   		ASSERT(0);
>   		return 0;