Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp3869461pxu;
        Tue, 20 Oct 2020 02:38:23 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxZBxDmkvntTEnCLiFHIpW4dTNldXGgHl3XH1djbyN7vmYhcqBQ3ydz7Uc8N3DmjIZUpQjO
X-Received: by 2002:a17:906:4ec7:: with SMTP id i7mr2261923ejv.439.1603186703579;
        Tue, 20 Oct 2020 02:38:23 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1603186703; cv=none;
        d=google.com; s=arc-20160816;
        b=P97zmTiOe3iMtVTRZcTnQ6G9TMc3O0KNukIQfKnlKKT49jB+a0Z/YmuUgrSEN2osuh
         NQqT9ltBW14fke5dlOCwrz69i0RKgGfb2E7gTGl0c0vt8qgzNTXYYtqQkYUSryCiw+6l
         uziR7mx6jpVYjH23uciiqO/Iox3qtdPj17d761zWRIvYutwrd4J2bJPyOEr7MJ5MND1R
         RxQc7LJVEQG9NongJX270zm4uekqMW8v3fTd04lo1aZzIm2ArOV91m5j8uIxh4cDbyBi
         6Z89y99R1TP/KnlqOXq2a0IE3YRaOXMLcvaUPHve6Gg5Sf/tyt55+8bruUhW55gWKn0m
         Bb+w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=JgtKQCdBHhWAi0Jahdr1f3uSUYWL0dxtVotsA8MMHMg=;
        b=ulAap6sqkoT7ZIElYWu2pFZLP3mlpqNLs+Y1l51NnjItp8APqk5ZZGVyf0TT/0v/9N
         kt1ThbWZ1B76xttTLzh9yyl5/UpnECPogEnOd8ECLmcx2PYQwAiAbRf/mTmvE5bWP+eZ
         Y9GfCpmzVqLglxT/W+RDOYpUrjhLRg0i5pWuNFiJN4a0w1/K1Ml2ecB0FbEo5VR4sGQq
         oe6LadL/WwzO8XoXQhcU+mSATpKb0zXtFmbq9kcSGQE+eAmVSnX1IACJTFVFslx4/Tsl
         Q+F7PE2MgQT4f1u680p2wsjFuMNHOAD6GaVaFdpKorx51Asl2uG1nORhgfK9ZZnOIVwV
         7fLw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=Tl1oa9Fc;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id a19si892509ejp.388.2020.10.20.02.38.01;
        Tue, 20 Oct 2020 02:38:23 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=Tl1oa9Fc;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2403780AbgJTGQl (ORCPT <rfc822;sduhuangshuai@gmail.com>
        + 99 others); Tue, 20 Oct 2020 02:16:41 -0400
Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:10052 "EHLO
        hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2403774AbgJTGQk (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Oct 2020 02:16:40 -0400
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B5f8e806b0000>; Mon, 19 Oct 2020 23:15:07 -0700
Received: from [10.25.98.225] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 20 Oct
 2020 06:16:27 +0000
Subject: Re: [PATCH v4 11/15] ASoC: dt-bindings: tegra: Add json-schema for
 Tegra audio graph card
To:     Rob Herring <robh@kernel.org>
CC:     <broonie@kernel.org>, <lgirdwood@gmail.com>,
        <kuninori.morimoto.gx@renesas.com>,
        <pierre-louis.bossart@linux.intel.com>, <perex@perex.cz>,
        <tiwai@suse.com>, <p.zabel@pengutronix.de>,
        <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
        <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <sharadg@nvidia.com>, <mkumard@nvidia.com>,
        <viswanathl@nvidia.com>, <rlokhande@nvidia.com>,
        <dramesh@nvidia.com>, <atalambedu@nvidia.com>,
        <nwartikar@nvidia.com>, <swarren@nvidia.com>,
        <nicoleotsuka@gmail.com>
References: <1602859382-19505-1-git-send-email-spujar@nvidia.com>
 <1602859382-19505-12-git-send-email-spujar@nvidia.com>
 <20201019221612.GA3690258@bogus>
From:   Sameer Pujar <spujar@nvidia.com>
Message-ID: <f6d098fa-cbc2-7563-a68c-5d00d71d128f@nvidia.com>
Date:   Tue, 20 Oct 2020 11:46:23 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201019221612.GA3690258@bogus>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1603174507; bh=JgtKQCdBHhWAi0Jahdr1f3uSUYWL0dxtVotsA8MMHMg=;
        h=Subject:To:CC:References:From:Message-ID:Date:User-Agent:
         MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:
         Content-Language:X-Originating-IP:X-ClientProxiedBy;
        b=Tl1oa9FcQuGR29PHRl92SYgAMkqyMK8MYNkdkrOOd98+Z7K8GhczOMW5ZuFFd2sJD
         01ghxx9Me82onlUp7nh4sNKZ4sW1ROkAt7mxLN1wxYS3SJJg1xHlpGIcygDEM2uY3z
         AJLNg86cFbCSsQ8BCngjDaiYQMRIS0XD/eo3zsw8o+ocmz4VVOV/jCe89bQarLxvgX
         7PZVnihrMwPl2hdWBBWrBVyRcf2bLZiaeAVWJRCjR3t26mNmGDlI+RgwZ/2fct5zg2
         lKlkMw5xxi6EINEhBEfgtUXn9a7TpjRW1ImKMOSHNYMH+ZF77POzINwYtgCHAAI3u3
         fJ1iBa4Q/oqRw==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>> Add YAML schema for Tegra audio graph sound card DT bindings. It uses th=
e
>> same DT bindings provided by generic audio graph driver. Along with this
>> few standard clock DT bindings are added which are specifically required
>> for Tegra audio.
>>
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>> ---
>>   .../sound/nvidia,tegra-audio-graph-card.yaml       | 158 +++++++++++++=
++++++++
>>   1 file changed, 158 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegr=
a-audio-graph-card.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-=
graph-card.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra-audi=
o-graph-card.yaml
>> new file mode 100644
>> index 0000000..284d185
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-c=
ard.yaml
>> @@ -0,0 +1,158 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/sound/nvidia,tegra-audio-graph-card.=
yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Audio Graph based Tegra sound card driver
>> +
>> +description: |
>> +  This is based on generic audio graph card driver along with additiona=
l
>> +  customizations for Tegra platforms. It uses the same bindings with
>> +  additional standard clock DT bindings required for Tegra.
>> +
>> +  See{LINUX}/Documentation/devicetree/bindings/sound/audio-graph-card.y=
aml
> You should be able to just $ref this at the top level.

I am seeing one problem while using $ref like below.
allOf:
 =C2=A0 - $ref: /schemas/sound/audio-graph-card.yaml

I see below while running doc validator.
"Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.exam=
ple.dt.yaml:=20
tegra_sound: compatible:0: 'audio-graph-card' was expected"

Is there a way to avoid this?

>
>> +
>> +maintainers:
>> +  - Jon Hunter <jonathanh@nvidia.com>
>> +  - Sameer Pujar <spujar@nvidia.com>
>> +
>> +properties:
>> +  compatible:
>> +    items:
>> +      - enum:
>> +          - nvidia,tegra210-audio-graph-card
>> +          - nvidia,tegra186-audio-graph-card
>> +

>> +  dais:
>> +    $ref: /schemas/sound/audio-graph-card.yaml#/properties/dais
>> +
>> +  label:
>> +    $ref: /schemas/sound/simple-card.yaml#/properties/label
>> +
>> +  pa-gpios:
>> +    $ref: /schemas/sound/audio-graph-card.yaml#/properties/pa-gpios
>> +
>> +  widgets:
>> +    $ref: /schemas/sound/simple-card.yaml#/definitions/widgets
>> +
>> +  routing:
>> +    $ref: /schemas/sound/simple-card.yaml#/definitions/routing
>> +
>> +  mclk-fs:
>> +    $ref: /schemas/sound/simple-card.yaml#/definitions/mclk-fs
>> +
>> +  prefix:
>> +    $ref: /schemas/sound/simple-card.yaml#/definitions/prefix
> And drop all of these.

Could not re-use because of above compatible problem. Also require some=20
additional properties for Tegra.

>> +
>> +  clocks:
>> +   minItems: 2
>> +
>> +  clock-names:
>> +   minItems: 2
> Don't need this.

This is required for Tegra audio graph card to update clock rates at=20
runtime.

>
>> +   items:
>> +     - const: pll_a
>> +     - const: plla_out0
>> +
>> +  assigned-clocks:
>> +    minItems: 1
>> +    maxItems: 3
>> +
>> +  assigned-clock-parents:
>> +    minItems: 1
>> +    maxItems: 3
>> +
>> +  assigned-clock-rates:
>> +    minItems: 1
>> +    maxItems: 3
>> +

It is required for initialisation of above clocks with specific rates.

>> +  ports:
>> +    $ref: /schemas/sound/audio-graph-card.yaml#/properties/ports
>> +
>> +patternProperties:
>> +  "^port(@[0-9a-f]+)?$":
>> +    $ref: /schemas/sound/audio-graph-card.yaml#/definitions/port
> And these can be dropped. Unless what each port is is Tegra specific.

May be I can drop this if I could just directly include=20
audio-graph-card.yaml and extend required properties for Tegra.