Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 20 Oct 2020 09:26:57 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Leo Yan <leo.yan@linaro.org>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Kan Liang <kan.liang@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Ian Rogers <irogers@google.com>, Joe Mario <jmario@redhat.com>,
        David Ahern <dsahern@gmail.com>,
        Don Zickus <dzickus@redhat.com>, Al Grant <Al.Grant@arm.com>,
        James Clark <james.clark@arm.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 8/8] perf c2c: Update documentation for display option
 'llc'
Message-ID: <20201020072657.GE2084117@krava>
References: <20201015145041.10953-1-leo.yan@linaro.org>
 <20201015145041.10953-9-leo.yan@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201015145041.10953-9-leo.yan@linaro.org>
Precedence: bulk

On Thu, Oct 15, 2020 at 03:50:41PM +0100, Leo Yan wrote:
> Since the new display option 'llc' is introduced, this patch is to
> update the documentation to reflect it.
> 
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
>  tools/perf/Documentation/perf-c2c.txt | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/perf/Documentation/perf-c2c.txt b/tools/perf/Documentation/perf-c2c.txt
> index c81d72e3eecf..eadce62ecd28 100644
> --- a/tools/perf/Documentation/perf-c2c.txt
> +++ b/tools/perf/Documentation/perf-c2c.txt
> @@ -109,7 +109,8 @@ REPORT OPTIONS
>  
>  -d::
>  --display::
> -	Switch to HITM type (rmt, lcl) to display and sort on. Total HITMs as default.
> +	Switch to HITM type (rmt, lcl) or LLC load access (llc) to display
> +	and sort on. Total HITMs as default.

ok, forget the doc update I asked in previous reply ;-)

thanks,
jirka

>  
>  --stitch-lbr::
>  	Show callgraph with stitched LBRs, which may have more complete
> @@ -174,12 +175,18 @@ For each cacheline in the 1) list we display following data:
>    Cacheline
>    - cacheline address (hex number)
>  
> -  Rmt/Lcl Hitm
> +  Rmt/Lcl Hitm (For display with HITM types)
>    - cacheline percentage of all Remote/Local HITM accesses
>  
> -  LLC Load Hitm - Total, LclHitm, RmtHitm
> +  LLC Load Hitm - Total, LclHitm, RmtHitm (For display with HITM types)
>    - count of Total/Local/Remote load HITMs
>  
> +  LLC Hit Pct (For display 'llc')
> +  - cacheline percentage of all LLC load accesses
> +
> +  LLC Hit Total (For display 'llc')
> +  - sum of all LLC load accesses
> +
>    Total records
>    - sum of all cachelines accesses
>  
> @@ -207,9 +214,12 @@ For each cacheline in the 1) list we display following data:
>  
>  For each offset in the 2) list we display following data:
>  
> -  HITM - Rmt, Lcl
> +  HITM - Rmt, Lcl (For display with HITM types)
>    - % of Remote/Local HITM accesses for given offset within cacheline
>  
> +  LLC LD - LclHit, LclHitm (For display 'llc')
> +  - % of LLC hits and LLC HITMs accesses for given offset within cacheline
> +
>    Store Refs - L1 Hit, L1 Miss
>    - % of store accesses that hit/missed L1 for given offset within cacheline
>  
> -- 
> 2.17.1
>