Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 20 Oct 2020 10:13:21 +0200
From:   Daniel Vetter <daniel@ffwll.ch>
To:     Kever Yang <kever.yang@rock-chips.com>
Cc:     Sandy Huang <hjc@rock-chips.com>, heiko@sntech.de,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@linux.ie>, huangtao@rock-chips.com,
        andy.yan@rock-chips.com, linux-rockchip@lists.infradead.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled
Message-ID: <20201020081321.GI401619@phenom.ffwll.local>
Mail-Followup-To: Kever Yang <kever.yang@rock-chips.com>,
        Sandy Huang <hjc@rock-chips.com>, heiko@sntech.de,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@linux.ie>, huangtao@rock-chips.com,
        andy.yan@rock-chips.com, linux-rockchip@lists.infradead.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20200707112526.18438-1-hjc@rock-chips.com>
 <5c0cdb9d-8e35-fa0c-35b3-adfa7770fb30@rock-chips.com>
 <20201015152301.GE438822@phenom.ffwll.local>
 <e016801a-61aa-de6c-cb90-c62e03bdd067@rock-chips.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e016801a-61aa-de6c-cb90-c62e03bdd067@rock-chips.com>
Precedence: bulk

On Mon, Oct 19, 2020 at 11:43:53AM +0800, Kever Yang wrote:
> Hi Daniel,
> 
> On 2020/10/15 下午11:23, Daniel Vetter wrote:
> > On Wed, Oct 14, 2020 at 09:48:43AM +0800, Kever Yang wrote:
> > > Hi Maintainers,
> > > 
> > >      Does this patch ready to merge?
> > Would maybe be good to get some acks from other drivers using this, then
> > Sandy can push to drm-misc-next.
> 
> Thanks for your reply, I can understand more 'acks' will be better, but
> there is no comments object to this patch
> 
> or any 'NAK' common for more then 3 months, maintainers should move to next
> step.

I expect you to poke relevant driver maintainers directly for these acks.
That was the purpose of my mail. All communication going through
maintainers, being exclusively orchestrated by maintainers, just doesn't
scale. So not an option for a big subsystem like drivers/gpu.

Hope that makes it clear.

For merging Sandy has commit rights to drm-misc, so that's not the
problem.

Cheers, Daniel

> 
> 
> Thanks,
> 
> - Kever
> 
> > -Daniel
> > > On 2020/7/7 下午7:25, Sandy Huang wrote:
> > > > don't mask possible_crtcs if remote-point is disabled.
> > > > 
> > > > Signed-off-by: Sandy Huang <hjc@rock-chips.com>
> > > > ---
> > > >    drivers/gpu/drm/drm_of.c | 3 +++
> > > >    1 file changed, 3 insertions(+)
> > > > 
> > > > diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> > > > index fdb05fbf72a0..565f05f5f11b 100644
> > > > --- a/drivers/gpu/drm/drm_of.c
> > > > +++ b/drivers/gpu/drm/drm_of.c
> > > > @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
> > > >    	uint32_t possible_crtcs = 0;
> > > >    	for_each_endpoint_of_node(port, ep) {
> > > > +		if (!of_device_is_available(ep))
> > > > +			continue;
> > > > +
> > > >    		remote_port = of_graph_get_remote_port(ep);
> > > >    		if (!remote_port) {
> > > >    			of_node_put(ep);
> > > Looks good to me.
> > > 
> > > 
> > > Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch