Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp3905809pxu; Tue, 20 Oct 2020 03:46:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3cXHAC6LM+nflDhsCk61Ufb76tZ/2I2XX57czgE1q9M2P+h/eAEVI08e/waZoO7G2PW8l X-Received: by 2002:aa7:d453:: with SMTP id q19mr2042201edr.144.1603190775370; Tue, 20 Oct 2020 03:46:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603190775; cv=none; d=google.com; s=arc-20160816; b=zjGiYeDEumR/ZPhKu7HkOmw95y86iS+2G9ggmg7iTVfEj8vIgVHoYFQC77XyW5fqu+ 1JEz9G1G5wxbWbrMSUtV7/VwelDeS9IPmVV+18ONLeK6Yq04KzittxKGe1hH/91QKD9n uLya91lJHE8mlO84kE3ysv7HuMp3uWUn8euCrRbPZ8DN9tIEFthtBIfnPUl40jr/QLdh EdwM7Ayp6/9LQsp+o0EuBF/ZZoeZoKeAJDdvMbW3Zb5ic/h4cd6MekJ25jbeZaUuF22j zEPL2pQybYDv5uBCIJ0uPrVWPlGfXuGXv2u07nRYw+5nGG0ZhOrumu7nPs/CTFDjkO17 YupQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=OzWls94jQ8pq52AMk7jKEXrTP1OQTMot6mH/T4YUYBA=; b=Q3U071Hpzvvk8oKBTo8xyPpZJG5ziDANmDnRU3wAi2sV2rj8sJ0n4yKqm8//kQVCcX 1yg8YhOyzFrO0F6cnHa/oLIrdb+g0OmtIMWaA81BI5lD80i9Y9hKFElzrPQUi8xpf/oP a6Wxr3O4rGcwxpOX9hEpew1xJ+DfTazat2NX8xVO7IIKHvZdAMBSF1ioBRLBktotlMWs LwqDHytasscvTC5hDlJ6qIM6Om5y87E5Psr/+y2x2PATfiUXMoAuWcwBtkM8KhzcToYp DTix/bgDk6kgCOLLHVmdefTwCYdTYHxepGyUiZAIhmbbBKQzfT8JZKiwSYFp0RLMpDi6 1VdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nU9Mwl6o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p14si984953eju.470.2020.10.20.03.45.53; Tue, 20 Oct 2020 03:46:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nU9Mwl6o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390218AbgJTI7j (ORCPT + 99 others); Tue, 20 Oct 2020 04:59:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390158AbgJTI7j (ORCPT ); Tue, 20 Oct 2020 04:59:39 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA771C0613D3 for ; Tue, 20 Oct 2020 01:59:37 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id h7so816124pfn.2 for ; Tue, 20 Oct 2020 01:59:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OzWls94jQ8pq52AMk7jKEXrTP1OQTMot6mH/T4YUYBA=; b=nU9Mwl6o0Qd+Gr4ubPUva9x2DPCXpPfPZXu0ZKfRsCipgcVSs5nalL2v/dHyHN+PKK NZg+H2I9awMs+f5Rz8gPCQOvehDicp01RidO74mOR6qDsvz2EVd7y4WYmvY13GJEBJat /rRigmJ7MiPP9IpK8duYKlPHOrHF3lofxbO9fHOX8NBd3iozrP7N0apAxzF2umTw/KnZ l1Sjhi1SkRedW+feXqXWc3JOTLkJbW0S+gvR5SUwsgh6Qb8L6Bvu3tj1u9EEbZ2bPUdo F3llTjVCnOrX1gfukYFx1nXfLOSn0X+eOUSbqRbpvPKuT6h5TS28qt7DPNI0Ok4fefoq 2Tkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OzWls94jQ8pq52AMk7jKEXrTP1OQTMot6mH/T4YUYBA=; b=Ai0W7JI9bsa7Lk/BQPb2zZmPupwQ8whHngc9nFG8N1lQiL+9B3NKAbMcKeeG3I8LZZ 86ZJiDMrEvYvARM6EwXim5hwtMoIK1qVLra8ck8+8hoMLG4aP0RfCZZEGD14S8RVme8x uepvDTdTAMR5aNyD4tPegh+CyYIbP3awdXyZBXbRTRGQ4Aa5Fqx11Rl7OXKnhWjR/Vpu QXFYrVKpVYI7W+h7jZg1Lk5Z3tlEd6Tp9V7fXRLONnsU72mhQZvQodaFMOaalwr4KPYw AaOVvHqrsrfNj4xNofy0iDZ61vV+9a7eUe7wqABcACOUNdb7EbYXE8vtY2mXbRwEufBn 7msw== X-Gm-Message-State: AOAM533DBX4PNGrNFCtkZX4grzeYHUJcd1mtB+Edbo/ihsi6F8LcdjwJ n/loVqYwricno7v9/chkJIA0jyy6gaO3BJhrXJMFBHyNq2I= X-Received: by 2002:aa7:9245:0:b029:156:552a:1275 with SMTP id 5-20020aa792450000b0290156552a1275mr1838556pfp.12.1603184377105; Tue, 20 Oct 2020 01:59:37 -0700 (PDT) MIME-Version: 1.0 References: <20201018125237.16717-1-kholk11@gmail.com> <20201018125237.16717-3-kholk11@gmail.com> In-Reply-To: <20201018125237.16717-3-kholk11@gmail.com> From: Robert Foss Date: Tue, 20 Oct 2020 10:59:24 +0200 Message-ID: Subject: Re: [PATCH 2/6] media: camss: ispif: Correctly reset based on the VFE ID To: kholk11@gmail.com Cc: Todor Tomov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Rob Herring , marijns95@gmail.com, konradybcio@gmail.com, martin.botka1@gmail.com, linux-arm-msm@vger.kernel.org, linux-media , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nice catch! This patch looks good to me. Signed-off-by: Robert Foss On Sun, 18 Oct 2020 at 14:54, wrote: > > From: AngeloGioacchino Del Regno > > Resetting the ISPIF VFE0 context is wrong if we are using the VFE1 > for dual-camera or simply because a secondary camera is connected > to it: in this case the reset will always happen on the VFE0 ctx > of the ISPIF, which is .. useless. > > Fix this usecase by adding the ISPIF_RST_CMD_1 address and choose > where to do the (or what to) reset based on the VFE line id. > > Signed-off-by: AngeloGioacchino Del Regno > --- > .../media/platform/qcom/camss/camss-ispif.c | 87 ++++++++++++------- > .../media/platform/qcom/camss/camss-ispif.h | 2 +- > 2 files changed, 57 insertions(+), 32 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-ispif.c b/drivers/media/platform/qcom/camss/camss-ispif.c > index db94cfd6c508..252db6b33dab 100644 > --- a/drivers/media/platform/qcom/camss/camss-ispif.c > +++ b/drivers/media/platform/qcom/camss/camss-ispif.c > @@ -26,6 +26,7 @@ > #define MSM_ISPIF_NAME "msm_ispif" > > #define ISPIF_RST_CMD_0 0x008 > +#define ISPIF_RST_CMD_1 0x00c > #define ISPIF_RST_CMD_0_STROBED_RST_EN (1 << 0) > #define ISPIF_RST_CMD_0_MISC_LOGIC_RST (1 << 1) > #define ISPIF_RST_CMD_0_SW_REG_RST (1 << 2) > @@ -179,7 +180,10 @@ static irqreturn_t ispif_isr_8x96(int irq, void *dev) > writel(0x1, ispif->base + ISPIF_IRQ_GLOBAL_CLEAR_CMD); > > if ((value0 >> 27) & 0x1) > - complete(&ispif->reset_complete); > + complete(&ispif->reset_complete[0]); > + > + if ((value3 >> 27) & 0x1) > + complete(&ispif->reset_complete[1]); > > if (unlikely(value0 & ISPIF_VFE_m_IRQ_STATUS_0_PIX0_OVERFLOW)) > dev_err_ratelimited(to_device(ispif), "VFE0 pix0 overflow\n"); > @@ -237,7 +241,7 @@ static irqreturn_t ispif_isr_8x16(int irq, void *dev) > writel(0x1, ispif->base + ISPIF_IRQ_GLOBAL_CLEAR_CMD); > > if ((value0 >> 27) & 0x1) > - complete(&ispif->reset_complete); > + complete(&ispif->reset_complete[0]); > > if (unlikely(value0 & ISPIF_VFE_m_IRQ_STATUS_0_PIX0_OVERFLOW)) > dev_err_ratelimited(to_device(ispif), "VFE0 pix0 overflow\n"); > @@ -257,33 +261,17 @@ static irqreturn_t ispif_isr_8x16(int irq, void *dev) > return IRQ_HANDLED; > } > > -/* > - * ispif_reset - Trigger reset on ISPIF module and wait to complete > - * @ispif: ISPIF device > - * > - * Return 0 on success or a negative error code otherwise > - */ > -static int ispif_reset(struct ispif_device *ispif) > +static int ispif_vfe_reset(struct ispif_device *ispif, u8 vfe_id) > { > - unsigned long time; > u32 val; > - int ret; > - > - ret = camss_pm_domain_on(to_camss(ispif), PM_DOMAIN_VFE0); > - if (ret < 0) > - return ret; > > - ret = camss_pm_domain_on(to_camss(ispif), PM_DOMAIN_VFE1); > - if (ret < 0) > - return ret; > - > - ret = camss_enable_clocks(ispif->nclocks_for_reset, > - ispif->clock_for_reset, > - to_device(ispif)); > - if (ret < 0) > - return ret; > + if (vfe_id > (to_camss(ispif)->vfe_num - 1)) { > + dev_err(to_device(ispif), > + "Error: asked reset for invalid VFE%d\n", vfe_id); > + return -ENOENT; > + } > > - reinit_completion(&ispif->reset_complete); > + reinit_completion(&ispif->reset_complete[vfe_id]); > > val = ISPIF_RST_CMD_0_STROBED_RST_EN | > ISPIF_RST_CMD_0_MISC_LOGIC_RST | > @@ -303,15 +291,51 @@ static int ispif_reset(struct ispif_device *ispif) > ISPIF_RST_CMD_0_RDI_OUTPUT_1_MISR_RST | > ISPIF_RST_CMD_0_RDI_OUTPUT_2_MISR_RST; > > - writel_relaxed(val, ispif->base + ISPIF_RST_CMD_0); > + if (vfe_id == 1) > + writel_relaxed(val, ispif->base + ISPIF_RST_CMD_1); > + else > + writel_relaxed(val, ispif->base + ISPIF_RST_CMD_0); > > - time = wait_for_completion_timeout(&ispif->reset_complete, > + time = wait_for_completion_timeout(&ispif->reset_complete[vfe_id], > msecs_to_jiffies(ISPIF_RESET_TIMEOUT_MS)); > if (!time) { > - dev_err(to_device(ispif), "ISPIF reset timeout\n"); > - ret = -EIO; > + dev_err(to_device(ispif), > + "ISPIF for VFE%d reset timeout\n", vfe_id); > + return -EIO; > } > > + return 0; > +} > + > +/* > + * ispif_reset - Trigger reset on ISPIF module and wait to complete > + * @ispif: ISPIF device > + * > + * Return 0 on success or a negative error code otherwise > + */ > +static int ispif_reset(struct ispif_device *ispif, u8 vfe_id) > +{ > + unsigned long time; > + int ret; > + > + ret = camss_pm_domain_on(to_camss(ispif), PM_DOMAIN_VFE0); > + if (ret < 0) > + return ret; > + > + ret = camss_pm_domain_on(to_camss(ispif), PM_DOMAIN_VFE1); > + if (ret < 0) > + return ret; > + > + ret = camss_enable_clocks(ispif->nclocks_for_reset, > + ispif->clock_for_reset, > + to_device(ispif)); > + if (ret < 0) > + return ret; > + > + ret = ispif_vfe_reset(ispif, vfe_id); > + if (ret) > + dev_dbg(to_device(ispif), "ISPIF Reset failed\n"); > + > camss_disable_clocks(ispif->nclocks_for_reset, ispif->clock_for_reset); > > camss_pm_domain_off(to_camss(ispif), PM_DOMAIN_VFE0); > @@ -355,7 +379,7 @@ static int ispif_set_power(struct v4l2_subdev *sd, int on) > goto exit; > } > > - ret = ispif_reset(ispif); > + ret = ispif_reset(ispif, line->vfe_id); > if (ret < 0) { > pm_runtime_put_sync(dev); > camss_disable_clocks(ispif->nclocks, ispif->clock); > @@ -1192,7 +1216,8 @@ int msm_ispif_subdev_init(struct ispif_device *ispif, > > mutex_init(&ispif->config_lock); > > - init_completion(&ispif->reset_complete); > + for (i = 0; i < MSM_ISPIF_VFE_NUM; i++) > + init_completion(&ispif->reset_complete[i]); > > return 0; > } > diff --git a/drivers/media/platform/qcom/camss/camss-ispif.h b/drivers/media/platform/qcom/camss/camss-ispif.h > index 1a5ba2425a42..4132174f7ea1 100644 > --- a/drivers/media/platform/qcom/camss/camss-ispif.h > +++ b/drivers/media/platform/qcom/camss/camss-ispif.h > @@ -56,7 +56,7 @@ struct ispif_device { > int nclocks; > struct camss_clock *clock_for_reset; > int nclocks_for_reset; > - struct completion reset_complete; > + struct completion reset_complete[MSM_ISPIF_VFE_NUM]; > int power_count; > struct mutex power_lock; > struct ispif_intf_cmd_reg intf_cmd[MSM_ISPIF_VFE_NUM]; > -- > 2.28.0 >