Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp3933986pxu; Tue, 20 Oct 2020 04:32:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjP29cQoyp9ZHgriOfJeqmf5H8e3S1uAqpcABobmywIgRgOEB6n4FJErmDuztx6bO8dk5V X-Received: by 2002:aa7:de95:: with SMTP id j21mr2318824edv.199.1603193555920; Tue, 20 Oct 2020 04:32:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603193555; cv=none; d=google.com; s=arc-20160816; b=d1Kt4CIlrXqP9kdOny0TIQM/Hs1W8qJ1wFXM+7hc6T143E3HmGbnqEtbecUW4vm+sN 0ZFTlrp40q9N3lbfqnkxU1bL7j8E9UvM6byxR8mi6dyHISPfGk9Pr68rPpHPj9f9wny6 4Q4vZom769fsok8p/tfwkl0PCqHxIsj1CPEOfN1IZgxhCsVoP0hhDnp68IQEmoQ5FuQH YnMqZIudVaxg3uP2nr/wwF1iyIVaKMyODa4BLe4I5Jzl2sT66z/ig9BjeRP+lQ66//4k xTVGZvb/m53l4KP+FEFlv5nZ+Xrx7uqedVbT4QQpm6r5HvI24f6U63YkyEFImShrB3Wm CpiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=k40p/TeTSBCnYnmdeXcl5d+yUSPbyw9jvLg468r2bq0=; b=SP6DhhtLrQJ9LLoq3apOmtVJc2EfBN+W593WPHerzOj35geIG/xm3ItDXahTurzZmt EPDE2VlrEMfokbxM1s4blXFIFSNN3h82B1vuZ2ccHa7yPMPAhNtygnR0Mftc+0XYBMkE dZ2QJpkwradDq8cNIqM2t+Xtm1NdoHhkxS3bJuIux54XoL9YygLOLD8wH6+fOhEmxu1K pNUR6yxqjBG4lUof8+Ms1kw2dC5uV3aLWpvr9xf8jbV6irMoku3zfLU3Mh28mqGXP/oq chJalv4JD/pMTvp6v8+VIE9a9BN7e3kYwXUKZgliXdNzJF/kYRIYYqWTI9nJfqxqTE/M hE/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CkH8rcRg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cc20si943996edb.341.2020.10.20.04.32.14; Tue, 20 Oct 2020 04:32:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CkH8rcRg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393130AbgJTKfp (ORCPT + 99 others); Tue, 20 Oct 2020 06:35:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392115AbgJTKfo (ORCPT ); Tue, 20 Oct 2020 06:35:44 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3A03C0613D3 for ; Tue, 20 Oct 2020 03:35:43 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id v22so586038ply.12 for ; Tue, 20 Oct 2020 03:35:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=k40p/TeTSBCnYnmdeXcl5d+yUSPbyw9jvLg468r2bq0=; b=CkH8rcRgSS61NJ0Nk7uX4ybp4pUswOiSBKXWxnHqkXFFG1I5B9UhQTDXbnO4dR6tEt Zgils15Hn+Uo/WI/KpYz9cwb5SqXBic9T4ZFcqzoExoRsUHiROexKTtohb9HboqvQDcg ao+WEbs/Po/vW2No+kjSaBl7sA9BBsi1lXaIyrnkNqLMmXyXllDOleF1SQ0cFAXBTWrG MvDCCVyHfNxdMNBu6VtfG1vnYrNTu8Fxkzy1e4OB71qF/N1RrfmfgwzPjoEeH5/iGBGY JINmDFYiGhdb62uzfr8TuCrfMrSMdTP+n8SSMDsPnQHUSrMt+WUPD6O7CQ8kkFplL20z hwIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k40p/TeTSBCnYnmdeXcl5d+yUSPbyw9jvLg468r2bq0=; b=d6Qp5jg0L32mFAYGuYqRZqMZa2MCPyTOAV5L3iisfBL6Ma8bn327N9yqL9cziYMvLy uOzZGWNhRiFjr+OE5/6klBWakdLT8n76WTBnyNFB/0PsbYWg6Tcpku+0MBagEu39oGC5 kqiGKt+HbNll0qT0bWErC1wLDFfkgAk/CCPg1bcbhFhJt++aDXWQAidrG3A87LErJ0E5 Rgb3RiMik4x0He7ZWGTvGy6WQ87pBT1MUMTQdeggcmeMBTL/ov9rA0eawX+rQftC7T3L h2ysdTTWyhcEUt5tgKmdHqfM4442Z7nHU48Go+z9AJqpAkeOe01qpY+zzigV6M1mhvly ev5A== X-Gm-Message-State: AOAM532BL0yDfITkGIu5gCWoRcNvKMDEji6FfblHENm9vvLHZMatpNIt jTrWTmig/N0S031v8qIv65JSFBoiiXSCD3yXCuafAQ== X-Received: by 2002:a17:90a:160f:: with SMTP id n15mr2190488pja.75.1603190143362; Tue, 20 Oct 2020 03:35:43 -0700 (PDT) MIME-Version: 1.0 References: <20201018125237.16717-1-kholk11@gmail.com> <20201018125237.16717-7-kholk11@gmail.com> In-Reply-To: <20201018125237.16717-7-kholk11@gmail.com> From: Robert Foss Date: Tue, 20 Oct 2020 12:35:32 +0200 Message-ID: Subject: Re: [PATCH 6/6] media: camss: csiphy: Set rate on csiX_phy clock on SDM630/660 To: kholk11@gmail.com Cc: Todor Tomov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Rob Herring , marijns95@gmail.com, konradybcio@gmail.com, martin.botka1@gmail.com, linux-arm-msm@vger.kernel.org, linux-media , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good to me. Signed-off-by: Robert Foss On Sun, 18 Oct 2020 at 14:53, wrote: > > From: AngeloGioacchino Del Regno > > The SDM630/660 SoCs (and variants) have another clock source > for the PHY, which must be set to a rate that's equal or > greater than the CSI PHY timer clock: failing to do this > will produce PHY overflows when trying to get a stream from > a very high bandwidth camera sensor and outputting no frame > or a partial one. > > Since I haven't found any usecase in which the csiX_phy > clock needs to be higher than the csiXphy_timer, let's just > set the same rate on both, which seems to work just perfect. > > Signed-off-by: AngeloGioacchino Del Regno > --- > .../media/platform/qcom/camss/camss-csiphy.c | 22 ++++++++++++++++--- > .../media/platform/qcom/camss/camss-csiphy.h | 1 + > 2 files changed, 20 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/media/platform/qcom/camss/camss-csiphy.c > index c00f25aac21b..a5d717d022a5 100644 > --- a/drivers/media/platform/qcom/camss/camss-csiphy.c > +++ b/drivers/media/platform/qcom/camss/camss-csiphy.c > @@ -113,9 +113,7 @@ static int csiphy_set_clock_rates(struct csiphy_device *csiphy) > for (i = 0; i < csiphy->nclocks; i++) { > struct camss_clock *clock = &csiphy->clock[i]; > > - if (!strcmp(clock->name, "csiphy0_timer") || > - !strcmp(clock->name, "csiphy1_timer") || > - !strcmp(clock->name, "csiphy2_timer")) { > + if (csiphy->rate_set[i]) { > u8 bpp = csiphy_get_bpp(csiphy->formats, > csiphy->nformats, > csiphy->fmt[MSM_CSIPHY_PAD_SINK].code); > @@ -611,6 +609,13 @@ int msm_csiphy_subdev_init(struct camss *camss, > if (!csiphy->clock) > return -ENOMEM; > > + csiphy->rate_set = devm_kcalloc(dev, > + csiphy->nclocks, > + sizeof(*csiphy->rate_set), > + GFP_KERNEL); > + if (!csiphy->rate_set) > + return -ENOMEM; > + > for (i = 0; i < csiphy->nclocks; i++) { > struct camss_clock *clock = &csiphy->clock[i]; > > @@ -638,6 +643,17 @@ int msm_csiphy_subdev_init(struct camss *camss, > > for (j = 0; j < clock->nfreqs; j++) > clock->freq[j] = res->clock_rate[i][j]; > + > + if (!strcmp(clock->name, "csiphy0_timer") || > + !strcmp(clock->name, "csiphy1_timer") || > + !strcmp(clock->name, "csiphy2_timer")) > + csiphy->rate_set[i] = true; > + > + if (camss->version == CAMSS_660 && > + (!strcmp(clock->name, "csi0_phy") || > + !strcmp(clock->name, "csi1_phy") || > + !strcmp(clock->name, "csi2_phy"))) > + csiphy->rate_set[i] = true; > } > > return 0; > diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.h b/drivers/media/platform/qcom/camss/camss-csiphy.h > index 376f865ad383..f7967ef836dc 100644 > --- a/drivers/media/platform/qcom/camss/camss-csiphy.h > +++ b/drivers/media/platform/qcom/camss/camss-csiphy.h > @@ -66,6 +66,7 @@ struct csiphy_device { > u32 irq; > char irq_name[30]; > struct camss_clock *clock; > + bool *rate_set; > int nclocks; > u32 timer_clk_rate; > struct csiphy_config cfg; > -- > 2.28.0 >