Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201019113240.11516-1-geert@linux-m68k.org> <1968b7a6-a553-c882-c386-4b4fde2d7a87@tessares.net>
In-Reply-To: <1968b7a6-a553-c882-c386-4b4fde2d7a87@tessares.net>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 19 Oct 2020 22:38:49 +0200
Message-ID: <CAMuHMdUDpVVejmrr3ayxnN=tgHrgDmUCVMG0VJht1Y-FUUv42Q@mail.gmail.com>
Subject: Re: [PATCH] mptcp: MPTCP_KUNIT_TESTS should depend on MPTCP instead
 of selecting it
To:     Matthieu Baerts <matthieu.baerts@tessares.net>
Cc:     Paolo Abeni <pabeni@redhat.com>,
        Mat Martineau <mathew.j.martineau@linux.intel.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        netdev <netdev@vger.kernel.org>, mptcp@lists.01.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Matthieu,

On Mon, Oct 19, 2020 at 5:47 PM Matthieu Baerts
<matthieu.baerts@tessares.net> wrote:
> On 19/10/2020 13:32, Geert Uytterhoeven wrote:
> > MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the
> > user may not want to enable.  Fix this by making the test depend on
> > MPTCP instead.
>
> I think the initial intension was to select MPTCP to have an easy way to
> enable all KUnit tests. We imitated what was and is still done in
> fs/ext4/Kconfig.
>
> But it probably makes sense to depend on MPTCP instead of selecting it.
> So that's fine for me. But then please also send a patch to ext4
> maintainer to do the same there.

Thanks, good point.  I didn't notice, as I did have ext4 enabled anyway.
Will send a patch for ext4.  Looks like ext4 and MPTCP where the only
test modules selecting their dependencies.

> Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds