Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   ChiaWei Wang <chiawei_wang@aspeedtech.com>
To:     "lee.jones@linaro.org" <lee.jones@linaro.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "joel@jms.id.au" <joel@jms.id.au>,
        "andrew@aj.id.au" <andrew@aj.id.au>,
        "minyard@acm.org" <minyard@acm.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
        "haiyue.wang@linux.intel.com" <haiyue.wang@linux.intel.com>,
        "cyrilbur@gmail.com" <cyrilbur@gmail.com>,
        "rlippert@google.com" <rlippert@google.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
CC:     BMC-SW <BMC-SW@aspeedtech.com>
Subject: RE: [PATCH v2 0/5] Remove LPC register partitioning
Thread-Topic: [PATCH v2 0/5] Remove LPC register partitioning
Thread-Index: AQHWmvF39eweRWKA/USnDpx5+4lpz6mgFZog
Date:   Tue, 20 Oct 2020 06:03:32 +0000
Message-ID: <HK0PR06MB377943740366AB328247C452911F0@HK0PR06MB3779.apcprd06.prod.outlook.com>
References: <20201005082806.28899-1-chiawei_wang@aspeedtech.com>
In-Reply-To: <20201005082806.28899-1-chiawei_wang@aspeedtech.com>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ce2d624f-ffe7-4ef2-3814-08d874bddff4
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2020 06:03:32.6471
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Hys5pANDjOTgREanvnOJouvgNSVKMxBHieRDhC0RMix4KHUDgkAaymLmwKFfbBXASZo1eyOM/n7hjbH/a7yhx1A81yIpNDpxpWm4AVm14Js=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR06MB3250
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi All,

Do you have any comment on the v2 changes?
Thanks.

Chiawei

> -----Original Message-----
> From: ChiaWei Wang <chiawei_wang@aspeedtech.com>
> Sent: Monday, October 5, 2020 4:28 PM
> To: lee.jones@linaro.org; robh+dt@kernel.org; joel@jms.id.au;
> andrew@aj.id.au; minyard@acm.org; arnd@arndb.de;
> gregkh@linuxfoundation.org; linus.walleij@linaro.org;
> haiyue.wang@linux.intel.com; cyrilbur@gmail.com; rlippert@google.com;
> linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org;
> linux-kernel@vger.kernel.org; openbmc@lists.ozlabs.org;
> linux-gpio@vger.kernel.org
> Subject: [PATCH v2 0/5] Remove LPC register partitioning
> 
> The LPC controller has no concept of the BMC and the Host partitions.
> The incorrect partitioning can impose unnecessary range restrictions on
> register access through the syscon regmap interface.
> 
> For instance, HICRB contains the I/O port address configuration of KCS channel
> 1/2. However, the KCS#1/#2 drivers cannot access HICRB as it is located at the
> other LPC partition.
> 
> In addition, to be backward compatible, the newly added HW control bits could
> be located at any reserved bits over the LPC addressing space.
> 
> Thereby, this patch series aims to remove the LPC partitioning for better driver
> development and maintenance.
> 
> 
> Changes since v1:
> 	- Add the fix to the aspeed-lpc binding documentation.
> 
> Chia-Wei, Wang (5):
>   ARM: dts: Remove LPC BMC and Host partitions
>   soc: aspeed: Fix LPC register offsets
>   ipmi: kcs: aspeed: Fix LPC register offsets
>   pinctrl: aspeed-g5: Fix LPC register offsets
>   dt-bindings: aspeed-lpc: Remove LPC partitioning
> 
>  .../devicetree/bindings/mfd/aspeed-lpc.txt    |  85 ++---------
>  arch/arm/boot/dts/aspeed-g4.dtsi              |  74 ++++------
>  arch/arm/boot/dts/aspeed-g5.dtsi              | 135 ++++++++----------
>  arch/arm/boot/dts/aspeed-g6.dtsi              | 135 ++++++++----------
>  drivers/char/ipmi/kcs_bmc_aspeed.c            |  13 +-
>  drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c    |   2 +-
>  drivers/soc/aspeed/aspeed-lpc-ctrl.c          |   6 +-
>  drivers/soc/aspeed/aspeed-lpc-snoop.c         |  11 +-
>  8 files changed, 176 insertions(+), 285 deletions(-)
> 
> --
> 2.17.1