Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: rbGGwftxRpfbZrAuVUcjV/s6W4yLGAfzdC6CdumkNRsd+ln/bcEt8NgUrXtIRD70clPDwMCEbm
 wxKJ3lJVVLVA==
IronPort-SDR: SJCmobtD43KKnOIBZd4CWbgAOvIIVgS6tTQcZacmJvNe5W3twhXpJ4mdwPMdbO/KIl+2SAo4d2
 bpQ9l6TSZXyg==
Date:   Tue, 20 Oct 2020 09:38:09 +0800
From:   Shuo A Liu <shuo.a.liu@intel.com>
To:     Arvind Sankar <nivedita@alum.mit.edu>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Yu Wang <yu1.wang@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Yakui Zhao <yakui.zhao@intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Fengwei Yin <fengwei.yin@intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Segher Boessenkool <segher@kernel.crashing.org>
Subject: Re: [PATCH v5 04/17] x86/acrn: Introduce hypercall interfaces
Message-ID: <20201020013809.GA11038@shuo-intel.sh.intel.com>
References: <20201019061803.13298-1-shuo.a.liu@intel.com>
 <20201019061803.13298-5-shuo.a.liu@intel.com>
 <20201019221515.GA2875488@rani.riverdale.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20201019221515.GA2875488@rani.riverdale.lan>
User-Agent: Mutt/1.8.3 (2017-05-23)
Precedence: bulk

On Mon 19.Oct'20 at 18:15:15 -0400, Arvind Sankar wrote:
>On Mon, Oct 19, 2020 at 02:17:50PM +0800, shuo.a.liu@intel.com wrote:
>> From: Shuo Liu <shuo.a.liu@intel.com>
>>
>> The Service VM communicates with the hypervisor via conventional
>> hypercalls. VMCALL instruction is used to make the hypercalls.
>>
>> ACRN hypercall ABI:
>>   * Hypercall number is in R8 register.
>>   * Up to 2 parameters are in RDI and RSI registers.
>>   * Return value is in RAX register.
>>
>> Introduce the ACRN hypercall interfaces. Because GCC doesn't support R8
>> register as direct register constraints, use supported constraint as
>> input with a explicit MOV to R8 in beginning of asm.
>>
>> +static inline long acrn_hypercall0(unsigned long hcall_id)
>> +{
>> +	long result;
>> +
>> +	asm volatile("movl %1, %%r8d\n\t"
>> +		     "vmcall\n\t"
>> +		     : "=a" (result)
>> +		     : "ir" (hcall_id)
>
>Is the hypercall id an unsigned long (64 bits) or an unsigned int (32
>bits)? This will generate broken assembly if the "r" option is chosen,
>eg something like
>	movl %rdi, %r8d

Yes, it can be an unsigned long. So do MOV explicitly.

	asm volatile("movq %1, %%r8\n\t"
		     "vmcall\n\t"
		     : "=a" (result)
		     : "ir" (hcall_id)

Thanks