Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: FKg5ojdE59EwWR4Yb7ofH7SQoSyPQXrPcof6D1I88vRIbuYFU8UzRZrOuq7uGRkDR0v0qQKpEb
 ykEzH5JegmjA==
IronPort-SDR: fi4SDY4KZtt7W2/BqYzzEnZn9S/MCUh+oO49ItV0Bq3+40Vn4cWi5agurP4DDcGN7kBoGD9JFw
 owWP7wAvoTOA==
Date:   Tue, 20 Oct 2020 11:09:43 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Daniel Latypov <dlatypov@google.com>
Cc:     brendanhiggins@google.com, davidgow@google.com,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        skhan@linuxfoundation.org
Subject: Re: [PATCH] lib: add basic KUnit test for lib/math
Message-ID: <20201020080943.GY4077@smile.fi.intel.com>
References: <20201019224556.3536790-1-dlatypov@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201019224556.3536790-1-dlatypov@google.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, Oct 19, 2020 at 03:45:56PM -0700, Daniel Latypov wrote:
> Add basic test coverage for files that don't require any config options:
> * gcd.c
> * lcm.c
> * int_sqrt.c
> * reciprocal_div.c
> (Ignored int_pow.c since it's a simple textbook algorithm.)
> 
> These tests aren't particularly interesting, but
> * they're chosen as easy to understand examples of how to write tests
> * provides a place to add tests for any new files in this dir
> * written so adding new test cases to cover edge cases should be easy

Is documentation not enough?

I have recently wrote my first KUnit test and I found documentation pretty good
for the start. I think we actually need more complex examples in the code (and
useful).

So, I'm in doubt these test are a good point to start with.

-- 
With Best Regards,
Andy Shevchenko