Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 20 Oct 2020 09:37:10 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc:     Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/2] sched/cpupri: Add CPUPRI_HIGHER
Message-ID: <20201020073710.GZ2611@hirez.programming.kicks-ass.net>
References: <20200922083934.19275-1-dietmar.eggemann@arm.com>
 <20201014195437.GD2974@worktop.programming.kicks-ass.net>
 <17c8a9b5-b63a-1a1a-f11b-5e00c2a6ad34@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <17c8a9b5-b63a-1a1a-f11b-5e00c2a6ad34@arm.com>
Precedence: bulk

On Mon, Oct 19, 2020 at 04:15:01PM +0200, Dietmar Eggemann wrote:
> On 14/10/2020 21:54, Peter Zijlstra wrote:
> > 
> > Add CPUPRI_HIGHER above the RT99 priority to denote the CPU is in use
> > by higher priority tasks (specifically deadline).
> 
> sugov:X already triggers this now on our !fast-switching devices running
> schedutil.

Right, that would also be a nice test-case for:

> > XXX: we should probably drive PUSH-PULL from cpupri, that would
> > automagically result in an RT-PUSH when DL sets cpupri to CPUPRI_HIGHER.

This, once we get there..

> > @@ -54,6 +56,10 @@ static int convert_prio(int prio)
> 
> The BUG_ON could be tightened:
> 
> -       BUG_ON(prio >= MAX_PRIO);
> +       BUG_ON(prio > MAX_RT_PRIO);
> 

Maybe I've not had enough wake-up juice, but I can't seem to locate
this.

> >  	case MAX_RT_PRIO-1:
> >  		cpupri = CPUPRI_NORMAL;		/*  0 */
> >  		break;
> > +
> > +	case MAX_RT_PRIO:
> > +		cpupri = CPUPRI_HIGHER;		/* 100 */
> > +		break;
> >  	}
> > 
> >  	return cpupri;
> 
> Just saw that the comment for cpupri_set() needs changing:
> 
> @@ -205,7 +208,7 @@ int cpupri_find_fitness(struct cpupri *cp, struct
> task_struct *p,
>   * cpupri_set - update the CPU priority setting
>   * @cp: The cpupri context
>   * @cpu: The target CPU
> - * @newpri: The priority (INVALID-RT99) to assign to this CPU
> + * @newpri: The priority (INVALID-RT1-RT99-NORMAL-HIGHER) to assign to
> this CPU

I made that:

+ * @newpri: The priority (INVALID,NORMAL,RT1-RT99,HIGHER) to assign to this CPU

> 
> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>

Thanks!