Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1600859910-15855-1-git-send-email-gene.chen.richtek@gmail.com> <20201016153823.GA9890@kozik-lap>
In-Reply-To: <20201016153823.GA9890@kozik-lap>
From:   Gene Chen <gene.chen.richtek@gmail.com>
Date:   Tue, 20 Oct 2020 17:03:00 +0800
Message-ID: <CAE+NS35gb_KWq3s-M9apxgr7wnNRyn7iPto8J8ZwA-jsgT=paw@mail.gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: power: Add bindings document for Charger
 support on MT6360 PMIC
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     sre@kernel.org, Matthias Brugger <matthias.bgg@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, linux-pm@vger.kernel.org,
        devicetree <devicetree@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Gene Chen <gene_chen@richtek.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Krzysztof Kozlowski <krzk@kernel.org> =E6=96=BC 2020=E5=B9=B410=E6=9C=8816=
=E6=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=8811:38=E5=AF=AB=E9=81=93=EF=
=BC=9A
>
> On Wed, Sep 23, 2020 at 07:18:29PM +0800, Gene Chen wrote:
> > From: Gene Chen <gene_chen@richtek.com>
> >
> > Add bindings document for Charger support on MT6360 PMIC
> >
> > Signed-off-by: Gene Chen <gene_chen@richtek.com>
> > ---
> >  .../bindings/power/supply/mt6360_charger.yaml      | 44 ++++++++++++++=
++++++++
> >  1 file changed, 44 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/power/supply/mt63=
60_charger.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/power/supply/mt6360_char=
ger.yaml b/Documentation/devicetree/bindings/power/supply/mt6360_charger.ya=
ml
> > new file mode 100644
> > index 0000000..711fc19
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/supply/mt6360_charger.yam=
l
> > @@ -0,0 +1,44 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/power/supply/mt6360_charger.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Battery charger driver for MT6360 PMIC from MediaTek Integrated=
.
> > +
> > +maintainers:
> > +  - Gene Chen <gene_chen@richtek.com>
> > +
> > +description: |
> > +  This module is part of the MT6360 MFD device.
> > +  Provides Battery Charger, Boost for OTG devices and BC1.2 detection.
> > +
> > +properties:
> > +  compatible:
> > +    const: mediatek,mt6360-chg
> > +
> > +  vinovp:
> > +    description:
> > +      Maximum CHGIN regulation voltage.
>
> 1. You need to describe the type.
> 2. Use proper unit suffix (see property-units.txt).
> 3. Is this a custom property? If yes, it misses vendor prefix. If not,
>    most likely there is already such property. Reuse.
>

ACK

> > +
> > +  usb-otg-vbus:
> > +      $ref: /schemas/regulator/regulator.yaml#
>
> 1. Wrong indentation.
> 2. Name should be more or less generic, so maybe
>    "usb-otg-vbus-regulator".
>

ACK

> > +
> > +required:
> > +  - compatible
>
> No address/reg? How does it bind?
>

This module is part of the MT6360 MFD device.
see Documentation/devicetree/bindings/mfd/mt6360.yaml, which is
reviewing by MFD reviewer.

Should I add this to description?

> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    mt6360_chg: chg {
>
> s/chg/charger/
>

ACK

> > +      compatible =3D "mediatek,mt6360-chg";
> > +      vinovp =3D <14500000>;
>
> Empty line break
>

ACK

> Best regards,
> Krzysztof