Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp4562822pxu; Tue, 20 Oct 2020 22:36:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjEDB4kMWaBidKgCRqX/pl1gh91ikuf0n6tvG477bjlZkoKJZ1+UW3Y6lhnz90N5CqAP5S X-Received: by 2002:a17:906:3582:: with SMTP id o2mr1682071ejb.518.1603258581090; Tue, 20 Oct 2020 22:36:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603258581; cv=none; d=google.com; s=arc-20160816; b=t8gqA+K+lfLKfxdrBdOtfM8P3MrdQ2Gl9+/U3Funio7cOp0E1J9Uma4JJOji185mAS OiiJ/pziBptrb9jfxnP0F2JovS2AhZAjlSOfM3gc/37fgYm9GwryPmevNseULWza8Vvv vTUxn0TLKCJ57uuqsODp6ekgtQi171Wq2FuLkDJ1S9AWXuTJ54Q1FaOq4Di42zgNpGf3 MqmM1ZFnJglw3wA4uu1fsgKRpTZu2cDbWFBk7vS/loI4q9m+2NDfe5pmoWP5VyyHGWWJ LJaR/55bnXDfn9MqO1bEQ4iHrjoCqO92HBJ3tXZQjHYCBZGbKe5FhrO8Zh4H4+imDVc+ a6wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ibk+WQyl1Lw6q1cJTSOwoEvGba79Exz+c3bdqvCMJck=; b=A9dHliSkiJUkJH/wFE+4doioBLRelAzxMsRyXVuZQlmah1vmFSE5TxN1Yk2dq4LnyD b1WXNdGRZdrzt/rxyDb+4HIP6tMSP9fYxD55DEvWRzQTYukYqQIWAnqUiFBU3RAvFUdY OKdP8TZ4NnbfQek+sOjopjrGmCCwYbJPuchy3R+GacfoFkUPNtgIYTaFEapwVhghwFj/ KNLoVo7Rw9/wB1ACMmGyfov16IUMWiHLwu3qK0URT0qNTSFHEZFrpvOYPRhK6mGnCDcu oDT2ES90ucdB3pBk5q5ze/HbZUnMY57ZeqAA/PX1wtNwboneXcBqTdzqd/5nWVlGwEmP QNJw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d2si650292ejm.716.2020.10.20.22.35.59; Tue, 20 Oct 2020 22:36:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408380AbgJTOrB (ORCPT + 99 others); Tue, 20 Oct 2020 10:47:01 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:48687 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2408360AbgJTOq7 (ORCPT ); Tue, 20 Oct 2020 10:46:59 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kUsue-0002IT-6H; Tue, 20 Oct 2020 14:46:56 +0000 From: Colin King To: Helen Koike , Dafna Hirschfeld , Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: staging: rkisp1: rsz: make const array static, makes object smaller Date: Tue, 20 Oct 2020 15:46:55 +0100 Message-Id: <20201020144655.53251-1-colin.king@canonical.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Don't populate the const array dev_names on the stack but instead it static. Makes the object code smaller by 15 bytes. Before: text data bss dec hex filename 17091 2648 64 19803 4d5b media/rkisp1/rkisp1-resizer.o After: text data bss dec hex filename 17012 2712 64 19788 4d4c media/rkisp1/rkisp1-resizer.o (gcc version 10.2.0) Signed-off-by: Colin Ian King --- drivers/staging/media/rkisp1/rkisp1-resizer.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/rkisp1/rkisp1-resizer.c b/drivers/staging/media/rkisp1/rkisp1-resizer.c index 1687d82e6c68..7ca5b47c5bf5 100644 --- a/drivers/staging/media/rkisp1/rkisp1-resizer.c +++ b/drivers/staging/media/rkisp1/rkisp1-resizer.c @@ -763,8 +763,10 @@ static void rkisp1_rsz_unregister(struct rkisp1_resizer *rsz) static int rkisp1_rsz_register(struct rkisp1_resizer *rsz) { - const char * const dev_names[] = {RKISP1_RSZ_MP_DEV_NAME, - RKISP1_RSZ_SP_DEV_NAME}; + static const char * const dev_names[] = { + RKISP1_RSZ_MP_DEV_NAME, + RKISP1_RSZ_SP_DEV_NAME + }; struct media_pad *pads = rsz->pads; struct v4l2_subdev *sd = &rsz->sd; int ret; -- 2.27.0