Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
References: <20201020075034.172825-1-jbrunet@baylibre.com> <7hblgxkki3.fsf@baylibre.com>
User-agent: mu4e 1.3.3; emacs 26.3
From:   Jerome Brunet <jbrunet@baylibre.com>
To:     Kevin Hilman <khilman@baylibre.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>
Cc:     linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: meson: ship only the necessary clock controllers
In-reply-to: <7hblgxkki3.fsf@baylibre.com>
Date:   Tue, 20 Oct 2020 17:28:22 +0200
Message-ID: <1jimb4nch5.fsf@starbuckisacylon.baylibre.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


On Tue 20 Oct 2020 at 17:03, Kevin Hilman <khilman@baylibre.com> wrote:

> Jerome Brunet <jbrunet@baylibre.com> writes:
>
>> There now the menu entries for the amlogic clock controllers.
>> Do not select these when ARM64 is enabled so it possible to ship only the
>> required.
>>
>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>> ---
>>  arch/arm64/Kconfig.platforms | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
>> index cd58f8495c45..b22d1bdd6eb6 100644
>> --- a/arch/arm64/Kconfig.platforms
>> +++ b/arch/arm64/Kconfig.platforms
>> @@ -154,9 +154,6 @@ config ARCH_MESON
>>  	bool "Amlogic Platforms"
>>  	select PINCTRL
>>  	select PINCTRL_MESON
>> -	select COMMON_CLK_GXBB
>> -	select COMMON_CLK_AXG
>> -	select COMMON_CLK_G12A
>
> This patch alone will break boot when using the default, upstream
> defconfig because these options will all now be disabled and we'll have
> no clock providers.
>
> I think you also need a default value (e.g. `default y`) in
> drivers/clk/meson/Kconfig for each of these entries to keep the same
> defaults.   But these defaults could be overridden by SoC-specific
> defconfigs leading to more flexibilty.
>
> So, assuming you queue up a drivers/clk patch to go in when this
> lands...

Indeed.
Please wait till the clock PR lands during the merge window, you'll see
that it is already taken care of.

I was not expecting you to look at it so soon ;)

>
> Acked-by: Kevin Hilman <khilman@baylibre.com>