Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp4591541pxu; Tue, 20 Oct 2020 23:35:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz58d7VC6n5TErK0hxkF4KSuEpA2wQyykrn6vgUtGSWueh18hxPCDKAmm+be/TPUjWlIqkH X-Received: by 2002:a05:6402:22d9:: with SMTP id dm25mr1547288edb.182.1603262158884; Tue, 20 Oct 2020 23:35:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603262158; cv=none; d=google.com; s=arc-20160816; b=dREdzgZuoTqVGL0BRdtT1qaPadkeSCmuugrA2luYXnQFzBm4FrHDiYCRi/CssJy8tg 1kkgNWxYFU7Ai4hXC/X8V8IbWN7mKZYgmXw00YRFKsMz/es73y5G9J81W9wXZYHCtw1q opae58TFfIfJOQKrPyqFybI1A/h+fOUubaRZSK3cGNpYXm3WnW3uKrz1DXbJIIN26tAZ st0XGNKeU5+5OAeKdb1pH7wm5Wczzw2k0RkyoVZGgQcisjfy1EDRTetVjvRnLDKY/aXA kOWhhonRhEszg+IpUPdfofU8K4eISA72giM7QkMg+/WbLHxmAZr0GkClrnYpWwGivgce RiHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject; bh=wZz/EgNoaMFxxV/kGs+UOOOrFHzt0gb4jjwlbN+b5rE=; b=EMCl1BXjqnQvknzlGAc62sJIuu911BPqB8QpOZrd+Q+6hklHtteqWIhUstq8GUszWg jQDg3ev+BFKqS8KqrSK78aBfUhb7nEvX4JbJu+PiIVzjc7ZI3M2JlIx7zXgqlRbkgcdE 9hbyM9Y0cVq8lz7GcO4e7YVyOPtB0egWkG5qMqb3pL355xSr67ojqAgLIrIZUneNW9ON HzNyZ757wzog7ekDOIBgysW4Nw6BixU30BXaHJE4H7z7351tokOYoG6nKHR74Ev8p7nv U5bC6tUQP1nK3Bu1S/Aq2+TPDEoxBr/ZYYw3h7bBE9Tn0yGm9fcGRBqPB6qgJCqbx7uR yiIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gf19si714645ejb.131.2020.10.20.23.35.36; Tue, 20 Oct 2020 23:35:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394704AbgJTQh4 (ORCPT + 99 others); Tue, 20 Oct 2020 12:37:56 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:35145 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728297AbgJTQh4 (ORCPT ); Tue, 20 Oct 2020 12:37:56 -0400 Received: from [192.168.100.1] ([82.252.146.14]) by mrelayeu.kundenserver.de (mreue011 [213.165.67.103]) with ESMTPSA (Nemesis) id 1MOhx9-1kmqjF3D9L-00QCMA; Tue, 20 Oct 2020 18:37:46 +0200 Subject: Re: [PATCH] serial: pmac_zilog: don't init if zilog is not available To: Greg KH Cc: linux-kernel@vger.kernel.org, Joshua Thompson , linux-serial@vger.kernel.org, Benjamin Herrenschmidt , linux-m68k@lists.linux-m68k.org, Geert Uytterhoeven , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, Michael Ellerman References: <20201020162303.1730562-1-laurent@vivier.eu> <20201020162844.GA865546@kroah.com> From: Laurent Vivier Autocrypt: addr=laurent@vivier.eu; prefer-encrypt=mutual; keydata= mQINBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABtCJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+iQI4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +bkCDQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAYkCHwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== Message-ID: <468bbbef-4745-3b16-b6f4-30b46ebcdc33@vivier.eu> Date: Tue, 20 Oct 2020 18:37:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20201020162844.GA865546@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:puj+R504LMRDRh0WeP8/42DFGwE34POQ0gVbRq7UIV/oVjrpPo2 GW0duE9GLF37u6Vc4TsxvxtJmX2CCTbmxtNbqMJ2kdqUpNxBfi1nG6SA46CK+pKl9+yKz0t DhYp+84q98iys2zeAcP2UTA5gCHLRAZW28pZlD+SB5gWQ4yZEsDXudSh87T9rOhTojwsoVN aIKVEv7MI3NxFdwh4uUOw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:1DbzawPaQK4=:Kd0xEov693LIpkoLoSNTI9 ohV6TB7zJzMD9ayfQZLnbc2uDz3UyZU1VEFcmGIwyPYPVs3JCqOqdTyjWhHg1HkyEGNJuuKXz DXLAJ5gmtC/8GGsZ0xfRo488JhjI2piClOKYSxh6JGqIXvDK3DEMOo0SkGl43OzCcHGb4nYny WiBoaIdQM+ErBGMhILZVAj+vCM7WCmlfyoa1vWU6xtpdHGnFNKo1le+fNiJsGxX3CDDWwVfK8 VoAeHIyzpS5goUsgdSOYb1Pj9RSElJEGvWKao71y2ODjxlWx88bs6NWDiLm9pVw/VgpD5uBeD FUVh3efsPdmxg64fgcF7yl4tKInN2YhLCy7ipJbVclGSciPOGeVXVPVOA7vzhPJGYxXBtqWe1 rChQCLOT5PAe805xVRstDjL3jPH7X+gkC9fISjwANnzfdJRYF6jIyQipONZPi Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 20/10/2020 à 18:28, Greg KH a écrit : > On Tue, Oct 20, 2020 at 06:23:03PM +0200, Laurent Vivier wrote: >> We can avoid to probe for the Zilog device (and generate ugly kernel warning) >> if kernel is built for Mac but not on a Mac. >> >> Signed-off-by: Laurent Vivier >> --- >> drivers/tty/serial/pmac_zilog.c | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/drivers/tty/serial/pmac_zilog.c b/drivers/tty/serial/pmac_zilog.c >> index 063484b22523..d1d2e55983c3 100644 >> --- a/drivers/tty/serial/pmac_zilog.c >> +++ b/drivers/tty/serial/pmac_zilog.c >> @@ -1867,6 +1867,12 @@ static struct platform_driver pmz_driver = { >> static int __init init_pmz(void) >> { >> int rc, i; >> + >> +#ifdef CONFIG_MAC >> + if (!MACH_IS_MAC) >> + return -ENODEV; >> +#endif > > Why is the #ifdef needed? > > We don't like putting #ifdef in .c files for good reasons. Can you make > the api check for this work with and without that #ifdef needed? The #ifdef is needed because this file can be compiled for PowerMac and m68k Mac. For PowerMac, the MACH_IS_MAC is not defined, so we need the #ifdef. We need the MAC_IS_MAC because the same kernel can be used with several m68k machines, so the init_pmz can be called on a m68k machine without the zilog device (it's a multi-targets kernel). You can check it's the good way to do by looking inside: drivers/video/fbdev/valkyriefb.c +317 drivers/macintosh/adb.c +316 That are two files used by both, mac and pmac. Thanks, Laurent