Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp4789757pxu; Wed, 21 Oct 2020 05:35:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxr1N1BWroTCV0O0Xs8SjfOKK9NXNWIXz5Y/SBG3yn0ELcMDC0ZfoNrT+Q9qPEkoIya/hGz X-Received: by 2002:a05:6402:142c:: with SMTP id c12mr2962907edx.41.1603283716257; Wed, 21 Oct 2020 05:35:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603283716; cv=none; d=google.com; s=arc-20160816; b=tFaZeykvaEv1UF+JT/4lAn0DXjxIsufJ7nwfkCCTANGGbgFFxE1XFXIIt6CMs3tMKi 6/7tAu62ParNpWVPEwVJSTtL62PXW4sx+dGOjkSFvdXUnAyTNSWOGJeaUV+XMORX9uiB 0gjdhBynUPEnNh0tQRV+Neyh0/m5SUqCQZvOurXWxz+mxRtkhaWNRn1jfJ+y1rIyUBXZ 4PqxAt0erAFcRXjAmUDn1ZSC3CigtiMJqq2TqwpaJhysNLhq+jMtXvPy+B4YbMG2TVqH T1KTsXUQcbQ8d7RdSNoYUFSCZkoE9/NDfi0yk5xZ53mZOaGM0+4tG4lyhxZSg/70W8cl SbIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=D1ESVdV9ArkvKQOlBvxi/+LEsBYC/ZGzLOFPV8Z0UFY=; b=c5TkDQ9N1JNFIkqOm+01xZwH8UeVFtyWDgTeTv6HMRZpB52unVq4MpdQJ9JJemOQG6 66VKDxRDGglafV0FsKDkHDIdbwyy/rxZEFmrFHS1w3U72XtG2UT8KJo2GIXyGN5n636T 9A8vnk7iMIkv0yO37koxg6cp0nVBHfXPls0zTuint5EF1EoCRqGP8zLnI/TIz4MHCWi+ f1LmqpjEYvqr4N1/QWqoTt7E42pRf53vaEKUnbnB8hLydme3/lThKcnlBrNfyUrxureF DEUtwh8lfI00Ke1i7wjEFncjjRJJLQ1aSY/I8CBWQ2goi8+DTMn1RzHVdXB6uPsnpYfd 6e/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h13si1251808edt.581.2020.10.21.05.34.53; Wed, 21 Oct 2020 05:35:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440436AbgJUFWZ (ORCPT + 99 others); Wed, 21 Oct 2020 01:22:25 -0400 Received: from mail.zju.edu.cn ([61.164.42.155]:56912 "EHLO zju.edu.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2440422AbgJUFWY (ORCPT ); Wed, 21 Oct 2020 01:22:24 -0400 Received: from localhost.localdomain (unknown [210.32.148.79]) by mail-app4 (Coremail) with SMTP id cS_KCgCXXrBuxY9f5hM1AA--.62537S4; Wed, 21 Oct 2020 13:21:54 +0800 (CST) From: Dinghao Liu To: dinghao.liu@zju.edu.cn, kjlu@umn.edu Cc: Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] can: vxcan: Fix memleak in vxcan_newlink Date: Wed, 21 Oct 2020 13:21:49 +0800 Message-Id: <20201021052150.25914-1-dinghao.liu@zju.edu.cn> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: cS_KCgCXXrBuxY9f5hM1AA--.62537S4 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUYx7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY02Avz4vE14v_GrWl 42xK82IYc2Ij64vIr41l42xK82IY6x8ErcxFaVAv8VW8uw4UJr1UMxC20s026xCaFVCjc4 AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE 17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMI IF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_WFyUJVCq 3wCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIda VFxhVjvjDU0xZFpf9x0JUP5rcUUUUU= X-CM-SenderInfo: qrrzjiaqtzq6lmxovvfxof0/1tbiAgATBlZdtQf4pwADsy Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When rtnl_configure_link() fails, peer needs to be freed just like when register_netdevice() fails. Signed-off-by: Dinghao Liu --- drivers/net/can/vxcan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/can/vxcan.c b/drivers/net/can/vxcan.c index d6ba9426be4d..aefc5a61d239 100644 --- a/drivers/net/can/vxcan.c +++ b/drivers/net/can/vxcan.c @@ -244,6 +244,7 @@ static int vxcan_newlink(struct net *net, struct net_device *dev, unregister_network_device: unregister_netdevice(peer); + free_netdev(peer); return err; } -- 2.17.1