Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201017110651.GA1602260@dragonet> <CAPhsuW583=org7AOR-W2vcQV3pTBxin2LG1tb3On=x6VtjXvxQ@mail.gmail.com>
 <20201019070319.GA1811280@dragonet>
In-Reply-To: <20201019070319.GA1811280@dragonet>
From:   Song Liu <song@kernel.org>
Date:   Tue, 20 Oct 2020 22:28:36 -0700
Message-ID: <CAPhsuW4dR7_pgxg-696M34peSRTPhTmJgpokKr5qAMXd81damg@mail.gmail.com>
Subject: Re: WARNING in md_ioctl
To:     "Dae R. Jeong" <dae.r.jeong@kaist.ac.kr>
Cc:     yjkwon@kaist.ac.kr, linux-raid <linux-raid@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Oct 19, 2020 at 12:03 AM Dae R. Jeong <dae.r.jeong@kaist.ac.kr> wrote:
>
> > diff --git i/drivers/md/md.c w/drivers/md/md.c
> > index 6072782070230..49442a3f4605b 100644
> > --- i/drivers/md/md.c
> > +++ w/drivers/md/md.c
> > @@ -7591,8 +7591,10 @@ static int md_ioctl(struct block_device *bdev,
> > fmode_t mode,
> >                         err = -EBUSY;
> >                         goto out;
> >                 }
> > -               WARN_ON_ONCE(test_bit(MD_CLOSING, &mddev->flags));
> > -               set_bit(MD_CLOSING, &mddev->flags);
> > +               if (test_and_set_bit(MD_CLOSING, &mddev->flags)) {
> > +                       err = -EBUSY;
> > +                       goto out;
> > +               }
> >                 did_set_md_closing = true;
> >                 mutex_unlock(&mddev->open_mutex);
> >                 sync_blockdev(bdev);
> >
> > Could you please test whether this fixes the issue?
>
> Since &mddev->open_mutex is held when testing a bit of mddev->flags, I
> modified the code just a little bit by putting mutex_unlock() as
> belows.

Good catch! The fix looks good. Would you like to submit a patch for it?

Thanks,
Song