Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp4826330pxu; Wed, 21 Oct 2020 06:24:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMFvgIKKpMt8uoAUVxkzEuMorAMts/aK4wfgxVOiyE73uZmwIGbwP4ip4eAO65E5f/d/5S X-Received: by 2002:a17:906:3e4b:: with SMTP id t11mr3368438eji.420.1603286652833; Wed, 21 Oct 2020 06:24:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603286652; cv=none; d=google.com; s=arc-20160816; b=gfAdHTNbc2uPqRtaZ5bO/A7WiVUgux0CaG3IWzWfFodXqyyzR8q3k2E8rNB2AvqH3c D1cFL78CvM4AkYlrVWmsIdDrzBcx+6j4FD9Fxy/uGuYj17UZ52G+8FRIEHGLNjZ1PITP WCDMV9z0THoYNJDdjEiTCOQacIHxpQX56n1pr1FiL8sb3SmLAQSSHxUYqvfeNPpNTnWS tPRTh3jMpwrbhWak+wXg3NAem/aS3Qf28lY4UqIg3CDkwf3+d1ipm6yx43RRzHA6QJY3 q6SW+ZUfWA/lAEu6BIb5u3W+katdx82UuboM5PnJCndFIT66Sfc3McfdDIqhx4ag8NUb MJZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mUDQL7MG1scyFSQ0a9pyxTVI6LvdRs8mu9vhMjIp5BA=; b=JL08XS/nMrRFzjG36iElDiQYMzKOyCG9P3Nsu5tziwdaXvOMzYU+YCy6P70SOoqz1Q fO9sGN3B7nwb9o7tLDtqRJBnOVd52c0OporRUo1JcbsRc9Dc9fB4OsISW5O3Rew0YyDH XdRN+yAJcJ+iT9n4IwQQ3184h/b5wOX0L3o8cEHIzcefGuj8T1gme1sJcpxE01S8volj 5LRtQqtsYUA/pTHk5qmweVIFOllM4yw8G+2CKrjtE0zFbFPLJaIg1YPlblNMxrVjWcJT Wwu0rOzfw1YKGbpVJfEDXVCntP3ULNFtz8nYcC42WbaN3/1gX5abXXWslWWAHXaNiCvl axnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@veeam.com header.s=mx4 header.b=C23hn96+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=veeam.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i23si1612915ejj.201.2020.10.21.06.23.49; Wed, 21 Oct 2020 06:24:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@veeam.com header.s=mx4 header.b=C23hn96+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=veeam.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2441646AbgJUKAq (ORCPT + 99 others); Wed, 21 Oct 2020 06:00:46 -0400 Received: from mx4.veeam.com ([104.41.138.86]:42144 "EHLO mx4.veeam.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2409323AbgJUKAq (ORCPT ); Wed, 21 Oct 2020 06:00:46 -0400 Received: from mail.veeam.com (spbmbx01.amust.local [172.17.17.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx4.veeam.com (Postfix) with ESMTPS id 181608A785; Wed, 21 Oct 2020 13:00:43 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=veeam.com; s=mx4; t=1603274443; bh=mUDQL7MG1scyFSQ0a9pyxTVI6LvdRs8mu9vhMjIp5BA=; h=Date:From:To:CC:Subject:References:In-Reply-To:From; b=C23hn96+ZA4EBt3/VYBOTpzXQzD8tcwqS6E0abaBi/XPXMnly4pog8QybPaBZRItI IkAlomgIGuw5ehdil8CcHH54yyHHMyf4tHWdhoRP1oEmTn9Vm3IlcOgOT7K7o+lWSl RilRxDz8BpJahoGW4BtThhWSXLO1v31QNnpmnRhs= Received: from veeam.com (172.24.14.5) by spbmbx01.amust.local (172.17.17.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.595.3; Wed, 21 Oct 2020 13:00:39 +0300 Date: Wed, 21 Oct 2020 13:01:26 +0300 From: Sergei Shtepa To: Johannes Thumshirn CC: "axboe@kernel.dk" , "viro@zeniv.linux.org.uk" , "hch@infradead.org" , "darrick.wong@oracle.com" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "rjw@rjwysocki.net" , "len.brown@intel.com" , "pavel@ucw.cz" , "akpm@linux-foundation.org" , "ming.lei@redhat.com" , "jack@suse.cz" , "tj@kernel.org" , "gustavo@embeddedor.com" , "bvanassche@acm.org" , "osandov@fb.com" , "koct9i@gmail.com" , Damien Le Moal , "steve@sk2.org" , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH 1/2] Block layer filter - second version Message-ID: <20201021100126.GB20749@veeam.com> References: <1603271049-20681-1-git-send-email-sergei.shtepa@veeam.com> <1603271049-20681-2-git-send-email-sergei.shtepa@veeam.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: X-Originating-IP: [172.24.14.5] X-ClientProxiedBy: spbmbx02.amust.local (172.17.17.172) To spbmbx01.amust.local (172.17.17.171) X-EsetResult: clean, is OK X-EsetId: 37303A295605D26A677560 X-Veeam-MMEX: True Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The 10/21/2020 12:14, Johannes Thumshirn wrote: > On 21/10/2020 11:04, Sergei Shtepa wrote: > > + help > > + Enabling this lets third-party kernel modules intercept > > + bio requests for any block device. This allows them to implement > > The "third-party kernel modules" part sounds a bit worrisome to me. Especially > as this functionality is based on EXPORT_SYMBOL()s without the GPL suffix. > > I read it as a "allow a proprietary module to mess with bios", which is a big > no-no to me. > > Not providing any sort of changelog doesn't help much either. > > Thanks, > Johannes > I think the words "third-party" are is not necessary. In my opinion, creating proprietary kernel modules for Linux is an empty idea. EXPORT_SYMBOL() -> EXPORT_SYMBOL_GPL() - no problem. -- Sergei Shtepa Veeam Software developer.