Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp4830690pxu; Wed, 21 Oct 2020 06:30:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpWUcd4ev06zA+EnAgDlmNyZfxzfuXvu9TNxZl8M5P5w1gxkXKDNSMl+HjmSoEdz6Dwi+w X-Received: by 2002:a17:906:9396:: with SMTP id l22mr3454248ejx.36.1603287032004; Wed, 21 Oct 2020 06:30:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603287031; cv=none; d=google.com; s=arc-20160816; b=KqoJXrXkZWV+3mq0RXDQgIDR97IAz1YkdaHKuKO3NsUuOwOVlcK8OOHdT7uPEuVXWK BpSnieEdFQMgdktdqkySgMb2E9X7u8DOwKaMK38Mfd9frKPwuJfHiZYO9YB+Fn6OR1pd lLm8dUDJ1D1iT+B1zxKbO3F0tCBQ7FOGXMj7MVJU6xE4UN057K85ddc6NDPaP3e3Iv63 9ycENjlGBbZbTdnf5rKI2K7nYdQOkRkiSGWkO+7FUKBtZmQ5hxfvVQVDfI5NdnvKhuS3 a+zsONtvVADE6VQuir3dMu01LyPhz5WscOGX33ajABPPU20XihOPnUssL1Cop/RuWDzI +idA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/p6v/6SAhY5h2ewrJ9FDQ7iNuIivMlmHNS95z40vB54=; b=CKRo/lkRMiC0HCTMpoR4QoIE2OJeMt9SBOYBuV/VJlsYCXjmJwfUBdWRqbwig1wJnR hHVGwbqB9W975MWK0OhlHVCpuVLWhhWf9F2m1HFuw4scnT4SnfOIH/pebSq+k4OJjLm0 R6M+z/B1Cg/Go3HDz9G6Z86XErMRfOLVoAHS2JDp/eHs9CyLwAY2qi5xy2JLDSiKpO+E 013OZk5PSub6xh8FeAIRQvk8tgxT03SNWkkyC2IPgad6zA+8Ci0Szj6+nZk2casx2EEY eHcgK0w3f1hd+07gQWIlcu7kq7hgBp+aCu+VGFcnmUKrdX4UG0l5Qsi0a9Ib7YJQ3xKT lLlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@veeam.com header.s=mx4 header.b=jrDBfzIY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=veeam.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e4si1353248edv.228.2020.10.21.06.30.09; Wed, 21 Oct 2020 06:30:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@veeam.com header.s=mx4 header.b=jrDBfzIY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=veeam.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2441697AbgJUK0l (ORCPT + 99 others); Wed, 21 Oct 2020 06:26:41 -0400 Received: from mx4.veeam.com ([104.41.138.86]:35840 "EHLO mx4.veeam.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390048AbgJUK0k (ORCPT ); Wed, 21 Oct 2020 06:26:40 -0400 Received: from mail.veeam.com (spbmbx01.amust.local [172.17.17.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx4.veeam.com (Postfix) with ESMTPS id B5A348A76E; Wed, 21 Oct 2020 13:26:37 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=veeam.com; s=mx4; t=1603275998; bh=/p6v/6SAhY5h2ewrJ9FDQ7iNuIivMlmHNS95z40vB54=; h=Date:From:To:CC:Subject:References:In-Reply-To:From; b=jrDBfzIYLZTU18COuJMG0YH/YRmu3Q2RULo8V7nTZTWqSfnco57Gjh+9xOeIo3NaI DD/wJhV5nzj4GgE0Gu4lUnVWX35iD1GJuqg39VSgVYIWx4tn/xt9ulFjk+JltEEkS1 opM1cZ9QZI/RTdxiEPExGJcHHduM+DtFPWfA6B5o= Received: from veeam.com (172.24.14.5) by spbmbx01.amust.local (172.17.17.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.595.3; Wed, 21 Oct 2020 13:26:35 +0300 Date: Wed, 21 Oct 2020 13:27:24 +0300 From: Sergei Shtepa To: Damien Le Moal CC: "axboe@kernel.dk" , "viro@zeniv.linux.org.uk" , "hch@infradead.org" , "darrick.wong@oracle.com" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "rjw@rjwysocki.net" , "len.brown@intel.com" , "pavel@ucw.cz" , "akpm@linux-foundation.org" , Johannes Thumshirn , "ming.lei@redhat.com" , "jack@suse.cz" , "tj@kernel.org" , "gustavo@embeddedor.com" , "bvanassche@acm.org" , "osandov@fb.com" , "koct9i@gmail.com" , "steve@sk2.org" , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH 1/2] Block layer filter - second version Message-ID: <20201021102724.GC20749@veeam.com> References: <1603271049-20681-1-git-send-email-sergei.shtepa@veeam.com> <1603271049-20681-2-git-send-email-sergei.shtepa@veeam.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: X-Originating-IP: [172.24.14.5] X-ClientProxiedBy: spbmbx02.amust.local (172.17.17.172) To spbmbx01.amust.local (172.17.17.171) X-EsetResult: clean, is OK X-EsetId: 37303A295605D26A677560 X-Veeam-MMEX: True Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org EXPORT_SYMBOL_GPL - ok. #ifdef CONFIG_BLK_FILTER or IS_ENABLED() - It's a matter of habit. > double blank line Ok, I did. Looks like a candidate for ./scripts/checkpatch.pl. > Separate into multiple patches: one that introduces the filter > functions/ops code and another that changes the block layer where needed. I'll think about it. Personally, it seems to me that this separation does not make it easier to understand the code. It is important for me to know immediately where the function is called, and this determines its behavior. -- Sergei Shtepa Veeam Software developer.