Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp4846759pxu; Wed, 21 Oct 2020 06:52:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7axYAt36RprSw0mrUn/5WdDhAV1/AhC/EkYkXYFIFM4xMfxLO0oqhZCF6Yqi30GSPyb0K X-Received: by 2002:aa7:d948:: with SMTP id l8mr3182561eds.159.1603288370554; Wed, 21 Oct 2020 06:52:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603288370; cv=none; d=google.com; s=arc-20160816; b=kFpnGb7zLZY9PAn1JEzHH3fkzCUlNMW+hgi3gkvPLb9w1/btIRFBY8ntOeuDIos484 TJYhOgpBa4aXRQ4pr9clkezmU/zTXokB06fzMb6zmkViiJLwaTg+crsomW0sw6NPUC0F E7Hf+ST4r9bEi/c2ZmJS1B/lYCVG+B0JzquHcLrXWYskFEJtEyc6nWbHfWR0swkftjju RTAM9wxPjfOV44XoAWIa0CJMIuJhM8wtsFJwlagNWyG2PAJ23GpiqXYsnjWC8kfA3n9m n4GAYnduGJHNthy1X+lGweJqu6niE00/Tp518EwRcw/wzwHZ0sIx3b38wdzIaltFaAUS YcTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=E2Vapj+amMVLSYi2wfddbf6LhgrR7X/z6LAxJdUGIy0=; b=dk7GdP/zIcDTL/jl7kytZEDS6A55SGkR5/T4jYRjPFjQn0DJ8UzMGM3yEo06u+c8Dk l4MAMvcSK2XGE8EqSY4P63IVUpopobgwose5hXAA0nQz3Qgh7wmdkf1zTbyU1WvKcFcY RmtA870UKiQM1AnV4Ac9fgMU0vhNMBBzADcIccPSmsJYUYZcJHwwr5ZOwP7wuAohvksu twkGUAFOAKXKCRvpKLTigYISGIE5RCO5huqTTlDY/DZWW6/atr1MJ+4jwZVOxBGNwdih 2Rny0LcDGd5bx/hMZaRNDFN0hEo937Eth33jQaAzkLNxKJnXfMZxmRFSiixvVlW3N1Qs XHRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZDZvY6VT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn21si1509021ejc.419.2020.10.21.06.52.28; Wed, 21 Oct 2020 06:52:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZDZvY6VT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2442105AbgJUL7L (ORCPT + 99 others); Wed, 21 Oct 2020 07:59:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:51804 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439720AbgJUL7L (ORCPT ); Wed, 21 Oct 2020 07:59:11 -0400 Received: from coco.lan (ip5f5ad5a8.dynamic.kabel-deutschland.de [95.90.213.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0B5B821789; Wed, 21 Oct 2020 11:59:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603281550; bh=iQJKeOcoMrfxe0TxGMxnR3EtyZpzJ7uGLe3SYzav/XE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZDZvY6VTcDEWY3Z84x64jvN/zuBBALzRdBdE/WC7iisi8XILmGmnGe0j0vGffSEp6 9Si6RtmBX8SaGQqIAKYYxz7WQ/HIn/Z1KglUjbcqqHh2xPDm06Gu4ct0Us6619xpsn C0TCVI6uBoCgwkbTpuIIHtKv3clALLT/bgwIXIII= Date: Wed, 21 Oct 2020 13:59:03 +0200 From: Mauro Carvalho Chehab To: Matthew Wilcox Cc: Linux Doc Mailing List , Jonathan Corbet , Andreas Gruenbacher , Andrew Morton , Guoqing Jiang , Jens Axboe , Johannes Weiner , Stephen Rothwell , Thomas Gleixner , William Kucharski , Yang Shi , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/24] mm: pagemap.h: fix two kernel-doc markups Message-ID: <20201021135903.719e1f30@coco.lan> In-Reply-To: <20201021112819.GJ20115@casper.infradead.org> References: <54ea6dd0fc37c48aef3fc3ae454c54a80db313dc.1602590106.git.mchehab+huawei@kernel.org> <20201013122654.GE20115@casper.infradead.org> <20201021115557.24c83c35@coco.lan> <20201021112819.GJ20115@casper.infradead.org> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, 21 Oct 2020 12:28:19 +0100 Matthew Wilcox escreveu: > On Wed, Oct 21, 2020 at 11:55:57AM +0200, Mauro Carvalho Chehab wrote: > > Hi Matthew, > > > > Em Tue, 13 Oct 2020 13:26:54 +0100 > > Matthew Wilcox escreveu: > > > > > On Tue, Oct 13, 2020 at 02:14:37PM +0200, Mauro Carvalho Chehab wrote: > > > > Changeset 6c8adf8446a3 ("mm: add find_lock_head") renamed the > > > > index parameter, but forgot to update the kernel-doc markups > > > > accordingly. > > > > > > The patch is correct (thank you!), but the description here references > > > a git commit id that's only found in the -next tree and is unstable. > > > > > > Andrew, can you fold this into the offending commit? > > > > Patch already reached upstream. So, it gained a stable reference. > > > > So, I'm changing its description to: > > > > Author: Mauro Carvalho Chehab > > Date: Thu Sep 10 08:38:07 2020 +0200 > > > > locking/refcount: move kernel-doc markups to the proper place > > This is the wrong changelog? Sorry! Yeah, that was the wrong one. I'm enclosing the right one with the complete patch. Thanks, Mauro [PATCH] mm: pagemap.h: fix two kernel-doc markups Changeset a8cf7f272b5a ("mm: add find_lock_head") renamed the index parameter, but forgot to update the kernel-doc markups accordingly. Fixes: a8cf7f272b5a ("mm: add find_lock_head") Signed-off-by: Mauro Carvalho Chehab diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index c77b7c31b2e4..e1e19c1f9ec9 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -344,9 +344,9 @@ static inline struct page *find_get_page_flags(struct address_space *mapping, /** * find_lock_page - locate, pin and lock a pagecache page * @mapping: the address_space to search - * @offset: the page index + * @index: the page index * - * Looks up the page cache entry at @mapping & @offset. If there is a + * Looks up the page cache entry at @mapping & @index. If there is a * page cache page, it is returned locked and with an increased * refcount. * @@ -363,9 +363,9 @@ static inline struct page *find_lock_page(struct address_space *mapping, /** * find_lock_head - Locate, pin and lock a pagecache page. * @mapping: The address_space to search. - * @offset: The page index. + * @index: The page index. * - * Looks up the page cache entry at @mapping & @offset. If there is a + * Looks up the page cache entry at @mapping & @index. If there is a * page cache page, its head page is returned locked and with an increased * refcount. *