Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CAFDeuWM7D-Upi84-JovKa3g8Y_4fjv65jND3--e9u-tER3WmVA@mail.gmail.com>
 <82b757bb-1f49-ab02-2f4b-89577d56fec9@kernel.org> <20201020122015.GH2294271@kernel.org>
 <CA+khW7gcDPAw4h=0U9mMxTJoaCyOXCMwyw34dcBp1xBKJG6xkg@mail.gmail.com>
In-Reply-To: <CA+khW7gcDPAw4h=0U9mMxTJoaCyOXCMwyw34dcBp1xBKJG6xkg@mail.gmail.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Tue, 20 Oct 2020 10:10:19 -0700
Message-ID: <CAEf4BzYDvvthK_S7EecsTO3HAVXiAf6AqHaiEWbf9+K7sjMiLA@mail.gmail.com>
Subject: Re: Segfault in pahole 1.18 when building kernel 5.9.1 for arm64
To:     Hao Luo <haoluo@google.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        =?UTF-8?B?w4lyaWNvIFJvbGlt?= <erico.erc@gmail.com>,
        dwarves@vger.kernel.org, open list <linux-kernel@vger.kernel.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Andrii Nakryiko <andriin@fb.com>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        bpf <bpf@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Oct 20, 2020 at 10:05 AM Hao Luo <haoluo@google.com> wrote:
>
> Thanks for reporting this and cc'ing me. I forgot to update the error
> messages when renaming the flags. I will send a patch to fix the error
> message.
>
> The commit
>
> commit f3d9054ba8ff1df0fc44e507e3a01c0964cabd42
> Author:     Hao Luo <haoluo@google.com>
> AuthorDate: Wed Jul 8 13:44:10 2020 -0700
>
>      btf_encoder: Teach pahole to store percpu variables in vmlinux BTF.
>
> encodes kernel global variables into BTF so that bpf programs can
> directly access them. If there is no need to access kernel global
> variables, it's perfectly fine to use '--btf_encode_force' to skip
> encoding bad symbols into BTF, or '--skip_encoding_btf_vars' to skip
> encoding all global vars all together. I will add these info into the
> updated error message.
>
> Also cc bpf folks for attention of this bug.

I've already fixed the message as part of
2e719cca6672 ("btf_encoder: revamp how per-CPU variables are encoded")

It's currently still in the tmp.libbtf_encoder branch in pahole repo.

>
> Hao
>
> On Tue, Oct 20, 2020 at 5:20 AM Arnaldo Carvalho de Melo
> <acme@kernel.org> wrote:
> >
> > Em Tue, Oct 20, 2020 at 11:01:39AM +0200, Jiri Slaby escreveu:
> > > Hi,
> > >
> > > On 19. 10. 20, 1:18, =C3=89rico Rolim wrote:
> > > > I'm trying to build kernel 5.9.1 for arm64, and my dotconfig has
> > > > `CONFIG_DEBUG_INFO_BTF=3Dy`, which requires pahole for building. Ho=
wever, pahole
> > > > version 1.18 segfaults during the build, as can be seen below:
> > > >
> > > > PAHOLE: Error: Found symbol of zero size when encoding btf (sym:
> > > > '__kvm_nvhe_arm64_ssbd_callback_required', cu:
> > > > 'arch/arm64/kernel/cpu_errata.c').
> > >
> > > The symbol is an alias coming from arch/arm64/kernel/vmlinux.lds:
> > > __kvm_nvhe_arm64_ssbd_callback_required =3D arm64_ssbd_callback_requi=
red;;
> > >
> > > > PAHOLE: Error: Use '-j' or '--force' to ignore such symbols and for=
ce
> > > > emit the btf.
> > > > scripts/link-vmlinux.sh: line 141: 43837 Segmentation fault
> > > > LLVM_OBJCOPY=3D${OBJCOPY} ${PAHOLE} -J ${1}
> > > >    LD      .tmp_vmlinux.kallsyms1
> > > >    KSYM    .tmp_vmlinux.kallsyms1.o
> > > >    LD      .tmp_vmlinux.kallsyms2
> > > >    KSYM    .tmp_vmlinux.kallsyms2.o
> > > >    LD      vmlinux
> > > >    BTFIDS  vmlinux
> > > > FAILED: load BTF from vmlinux: Unknown error -2make: ***
> > > > [Makefile:1162: vmlinux] Error 255
> > > >
> > > > It is possible to force the build to continue if
> > > >
> > > >    LLVM_OBJCOPY=3D${OBJCOPY} ${PAHOLE} -J ${1}
> > > >
> > > > in scripts/link-vmlinux.sh is changed to
> > > >
> > > >    LLVM_OBJCOPY=3D${OBJCOPY} ${PAHOLE} -J --btf_encode_force ${1}
> > > >
> > > > The suggested `-j` or `--force` flags don't exist, since they were =
removed in
> > > > [1]. I believe `--btf_encode_force` should be suggested instead.
> > >
> > > Agreed, '--btf_encode_force' makes pahole to proceed without crashes.
> > >
> > > > It should be noted that the same build, but with pahole version 1.1=
7, works
> > > > without issue, so I think this is either a regression in pahole or =
the script
> > > > will need to be changed for newer versions of pahole.
> > >
> > > Yeah, I observe the very same. I reported it at:
> > > https://bugzilla.suse.com/show_bug.cgi?id=3D1177921
> >
> > Would it be possible to try with
> > https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?h=3Dtmp.=
libbtf_encoder
> > ?
> >
> > This switches to using libbpf for the BTF encoder and may have fixed
> > this problem.
> >
> > - Arnaldo
> >

[...]

> > >
> > >
> > > I suspect:
> > > commit f3d9054ba8ff1df0fc44e507e3a01c0964cabd42
> > > Author:     Hao Luo <haoluo@google.com>
> > > AuthorDate: Wed Jul 8 13:44:10 2020 -0700
> > >
> > >     btf_encoder: Teach pahole to store percpu variables in vmlinux BT=
F.
> > >
> > >
> > > Which added this machinery (btf_elf__add_datasec_type in particular).
> > >
> > > > - [1] https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit=
/pahole.c?h=3Dv1.18&id=3D1abc001417b579b86a9b27ff88c9095d8f498a46
> > > >
> > > > Thanks,
> > > > =C3=89rico
> > > >
> > >
> > >
> > > --
> > > js
> > > suse labs
> >
> > --
> >
> > - Arnaldo