Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp5005674pxu; Wed, 21 Oct 2020 10:38:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz5zAGJRUSyfTD0Qye/giWybTGl0kPY8ib65OwmiwmMte67CcbV9Vmi2nvfuibsOlskScpT X-Received: by 2002:a17:906:3e4e:: with SMTP id t14mr4595399eji.242.1603301903407; Wed, 21 Oct 2020 10:38:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603301903; cv=none; d=google.com; s=arc-20160816; b=zP3LFa4kfMtKGct3x71fu1RoIYp0PO+683PsRF2HZfxQ8NgaIF2CBs7L8LapW9dhrX DTlcl5/baOT2eFg6wGL8/Lw1tdKs7IEkybJtPN9V68NZE8jgbDF/5CgPvPSfYVv0uD83 8LIUOO+AVnLX7PsnkjInQmF9DgeJSOawAoR72kzLmGKCgCGZFq7FxEZZZgnFdxP81UTo jkQG8AqfGcNttW3SCZXOIUHZlcZpC3RrRGVMoeWgvEYu6iZIF3K2pbMuHPkEwlKamjXD Ag6ZhVbmZzQseirPj6qW17UOxPfEK7ih8VI7PL9nmtuuRQU98Mn4kEwfhwbCOOr79pdF eIBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ApWsqXUGVMr0AU3IN7u+5s3UpXWZGZXiw1+MIywGV2A=; b=tWygmZ4IGRbXuHD66mIUe5yAWRvk76UvB8ElgCaSGlmRjedwQK8B/CzIURShnj4t84 9t1EQo43fbXEPJn2RoY951NlCEFbP3iHtFniJh+gOMsE9S2bj4cRyy7++8a6ik6f7Roi vNwl9FQR0lAQe7LaVwX4TYsvOstBlUZgfOFfK67LNZO4Q2UPNmCt8pdiGSdvbBSk2qcQ szg2HRotYUJCKe0iW6IY8VBlZryHZnsq0n5sTqeQZ3cehf9SOrqTUh/N4syk25wU19y/ 1ooU3YSEkESXB3kbtRGbse1p69iGnfKpL+1SDIcbMN+z9MIoY2Jr2CN0GpcJgfMVoixY oNeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="F5R/G05o"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r10si1909978edm.139.2020.10.21.10.38.01; Wed, 21 Oct 2020 10:38:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="F5R/G05o"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438455AbgJTTxS (ORCPT + 99 others); Tue, 20 Oct 2020 15:53:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:48310 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438427AbgJTTxJ (ORCPT ); Tue, 20 Oct 2020 15:53:09 -0400 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C54CA223C6; Tue, 20 Oct 2020 19:53:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603223588; bh=AHoy8KFgublxtbfCrMKzqGKKzUoHEFBYkSraSnVIqHM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F5R/G05opR4eHjGJBhmaxL/dgp2gKoKY0LLIw6+O5iv/b7y3cMxyA6GMZ0+WJYV4v JzfxiC2lNgaqx0Gj0/xoxUspW/g9jCOsg8kpLLjqoRemxXErhMYuTvNaINxl9yufSW RS7nyCeuDcno3s9Zcr1NvZPeTCGXWzlIEdHnEyyk= From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com Cc: Jaegeuk Kim , Alim Akhtar , Avri Altman , Can Guo Subject: [PATCH v2 5/5] scsi: ufs: fix clkgating on/off correctly Date: Tue, 20 Oct 2020 12:52:58 -0700 Message-Id: <20201020195258.2005605-6-jaegeuk@kernel.org> X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog In-Reply-To: <20201020195258.2005605-1-jaegeuk@kernel.org> References: <20201020195258.2005605-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The below call stack prevents clk_gating at every IO completion. We can remove the condition, ufshcd_any_tag_in_use(), since clkgating_work will check it again. ufshcd_complete_requests(struct ufs_hba *hba) ufshcd_transfer_req_compl() __ufshcd_transfer_req_compl() __ufshcd_release(hba) if (ufshcd_any_tag_in_use() == 1) return; ufshcd_tmc_handler(hba); blk_mq_tagset_busy_iter(); Cc: Alim Akhtar Cc: Avri Altman Cc: Can Guo Signed-off-by: Jaegeuk Kim --- drivers/scsi/ufs/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index b5ca0effe636..cecbd4ace8b4 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -1746,7 +1746,7 @@ static void __ufshcd_release(struct ufs_hba *hba) if (hba->clk_gating.active_reqs || hba->clk_gating.is_suspended || hba->ufshcd_state != UFSHCD_STATE_OPERATIONAL || - ufshcd_any_tag_in_use(hba) || hba->outstanding_tasks || + hba->outstanding_tasks || hba->active_uic_cmd || hba->uic_async_done) return; -- 2.29.0.rc1.297.gfa9743e501-goog