Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201016051455.1913795-1-daeho43@gmail.com> <20201021043620.GA3939@sol.localdomain>
In-Reply-To: <20201021043620.GA3939@sol.localdomain>
From:   Daeho Jeong <daeho43@gmail.com>
Date:   Wed, 21 Oct 2020 13:55:17 +0900
Message-ID: <CACOAw_xJ8yTT+PLjgvE_8M6rfuwLiR42EeCOt5xDm2xTDj2Aeg@mail.gmail.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: add compr_inode and compr_blocks sysfs nodes
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com,
        Daeho Jeong <daehojeong@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Both values are from memory values.

2020=EB=85=84 10=EC=9B=94 21=EC=9D=BC (=EC=88=98) =EC=98=A4=ED=9B=84 1:36, =
Eric Biggers <ebiggers@kernel.org>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:

>
> On Fri, Oct 16, 2020 at 02:14:55PM +0900, Daeho Jeong wrote:
> > From: Daeho Jeong <daehojeong@google.com>
> >
> > Added compr_inode to show compressed inode count and compr_blocks to
> > show compressed block count in sysfs.
> >
> > Signed-off-by: Daeho Jeong <daehojeong@google.com>
> > ---
> >  Documentation/ABI/testing/sysfs-fs-f2fs | 10 ++++++++++
> >  fs/f2fs/sysfs.c                         | 17 +++++++++++++++++
> >  2 files changed, 27 insertions(+)
> >
> > diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/AB=
I/testing/sysfs-fs-f2fs
> > index 834d0becae6d..a01c26484c69 100644
> > --- a/Documentation/ABI/testing/sysfs-fs-f2fs
> > +++ b/Documentation/ABI/testing/sysfs-fs-f2fs
> > @@ -350,3 +350,13 @@ Date:            April 2020
> >  Contact:     "Daeho Jeong" <daehojeong@google.com>
> >  Description: Give a way to change iostat_period time. 3secs by default=
.
> >               The new iostat trace gives stats gap given the period.
> > +
> > +What:                /sys/fs/f2fs/<disk>/compr_inode
> > +Date:                October 2020
> > +Contact:     "Daeho Jeong" <daehojeong@google.com>
> > +Description: Show compressed inode count
> > +
> > +What:                /sys/fs/f2fs/<disk>/compr_blocks
> > +Date:                October 2020
> > +Contact:     "Daeho Jeong" <daehojeong@google.com>
> > +Description: Show compressed block count
>
> Is it the count in memory, or on disk?
>
> - Eric