Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp5346517pxu; Wed, 21 Oct 2020 22:49:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw96tcE4yCMpxPWUorZvM6un0kSZB+HtMvLA12mv77rSnArJDdywfgccyG5JCG/w0AjoeQp X-Received: by 2002:a17:906:5e49:: with SMTP id b9mr735919eju.436.1603345755839; Wed, 21 Oct 2020 22:49:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603345755; cv=none; d=google.com; s=arc-20160816; b=NZ+Vtwq5y8eSr5HP7HqyhtXeuk16462WlELAAqQUt4GVxAM0//fDTGajlsUkIO4YYa lQ3lwyP9jhppvj+Stgbrhn/rIHCveYMp78APvEAiL8JqVbfR4u56PeteMuaHk0I4TUxG nQl5AGmEps1AkMQgTQTYmuQcWA7fBvAmK0il+V7egWXvGz3dpZs1eiRgqJiSH/3Dsdb7 xUDZay3PQqr0wMmY159HhJRT53/ghA6yUCV/v11krBhuiekC4w+TRvMxUM00vVUeLdcr i/nEsPIDmV6IiVdYKE9LKFRA8bPTA+nnJ1xq/nb9i+VwCX0a6pexu1oiJaS22eCfq+Ga 1eSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dmarc-filter:sender:dkim-signature; bh=wvO5zR9EQASc5KuaM9v+5jS+2r+RAJFBwotKW+D0OfY=; b=gD9KYPYoXSyGYTbaC6ACDk8wvLm5kXpuFJpUoecoMFIoE/QeTWNWYwTatke9oWFY4U 3FhlQr3gD7ds1crx+9AK6a2228ajPmY9bRdHjoMUyIGcLj6RWxRl8KNI2XOgZvhhWcXZ l4hUQPCeqzBSTw9/HDNthOX3bXxJ9Zs0aG/tgqdOjKKv2KytlAGwv3LDV6xWoPeWXTDg axis32lN79nt9DP3iAL4c1Mekc8U3Kv5Sr2RGfBoDosBQHuLUHkMpk24HkbAVO10NW05 I6tLibGqm8B46cCELv4SsCoETgQmSfWTf1knHp1+A1/Nu4pFB/bqDjej8VMhkmHrI2bG /+Rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=uDCQlFNY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e7si346001ejm.599.2020.10.21.22.48.54; Wed, 21 Oct 2020 22:49:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=uDCQlFNY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502950AbgJUQdJ (ORCPT + 99 others); Wed, 21 Oct 2020 12:33:09 -0400 Received: from m42-4.mailgun.net ([69.72.42.4]:49216 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2502947AbgJUQdJ (ORCPT ); Wed, 21 Oct 2020 12:33:09 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1603297988; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=wvO5zR9EQASc5KuaM9v+5jS+2r+RAJFBwotKW+D0OfY=; b=uDCQlFNYb3DQdi7D4Fghq2Ep48P41Xi+8MCeOn4oHcLJRzgOBQWeEh/iqkvctXMLImrg+qm7 KaQXLOzctGtbn7nYyKslguQtw67pyVC/k9nHHOLhErTNxGccmoZZZvSyPSDslEdMmKmKT0BL HxpwGNKggIHKm6CGNANSZyNEWSw= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 5f9062c252f4fccef08ffbbc (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 21 Oct 2020 16:33:06 GMT Sender: hemantk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C6B8CC433CB; Wed, 21 Oct 2020 16:33:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, NICE_REPLY_A,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from [10.46.162.249] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: hemantk) by smtp.codeaurora.org (Postfix) with ESMTPSA id E62DDC433C9; Wed, 21 Oct 2020 16:33:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E62DDC433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=hemantk@codeaurora.org Subject: Re: [PATCH] bus: mhi: core: fix potential operator-precedence with BHI macros To: Jeffrey Hugo , manivannan.sadhasivam@linaro.org, bbhatt@codeaurora.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <1603225785-21368-1-git-send-email-jhugo@codeaurora.org> From: Hemant Kumar Message-ID: Date: Wed, 21 Oct 2020 09:33:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1603225785-21368-1-git-send-email-jhugo@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/20/20 1:29 PM, Jeffrey Hugo wrote: > The BHI_MSMHWID and BHI_OEMPKHASH macros take a value 'n' which is > a BHI register index. If 'n' is an expression rather than a simple > value, there can be an operator precedence issue which can result > in the incorrect calculation of the register offset. Adding > parentheses around the macro parameter can prevent such issues. > > Signed-off-by: Jeffrey Hugo > --- Reviewed-by: Hemant Kumar -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project