Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201022035848.976286-1-daeho43@gmail.com> <20201022042257.GA857@sol.localdomain>
In-Reply-To: <20201022042257.GA857@sol.localdomain>
From:   Daeho Jeong <daeho43@gmail.com>
Date:   Thu, 22 Oct 2020 13:30:36 +0900
Message-ID: <CACOAw_zVO8FugS_UAXCYyg99-6GWCm4aGi4xEtrhxeBofa2=cA@mail.gmail.com>
Subject: Re: [f2fs-dev] [PATCH v2 1/2] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION ioctl
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com,
        Daeho Jeong <daehojeong@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Yep, it sounds more clear~

2020=EB=85=84 10=EC=9B=94 22=EC=9D=BC (=EB=AA=A9) =EC=98=A4=ED=9B=84 1:22, =
Eric Biggers <ebiggers@kernel.org>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> On Thu, Oct 22, 2020 at 12:58:47PM +0900, Daeho Jeong wrote:
> > +     if (!f2fs_compressed_file(inode)) {
> > +             inode_unlock(inode);
> > +             return -EINVAL;
> > +     }
>
> How about using ENODATA here?  EINVAL tends to be used for lots of differ=
ent
> reasons, and it's not always clear what it means.
>
> Note that FS_IOC_GET_ENCRYPTION_POLICY fails with ENODATA when called on =
an
> unencrypted file, which is a similar case.
>
> - Eric