Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1ec29ed6-0047-d22f-630b-a7f5ccee96b4@linux.intel.com> <dc78ce8b-664c-45b9-ad44-4faaeb5d544f@linux.intel.com>
In-Reply-To: <dc78ce8b-664c-45b9-ad44-4faaeb5d544f@linux.intel.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Thu, 22 Oct 2020 13:31:02 +0900
Message-ID: <CAM9d7cg7iU5sY0u0AgWhFddzCMT3vuS-SgDePENP6kQm0w5J6w@mail.gmail.com>
Subject: Re: [PATCH v2 03/15] perf data: open data directory in read access mode
To:     Alexey Budankov <alexey.budankov@linux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Oct 22, 2020 at 12:58 AM Alexey Budankov
<alexey.budankov@linux.intel.com> wrote:
>
>
> Open files located at trace data directory in case read access
> mode is requested. File are opened and its fds assigned to
> perf_data dir files especially for loading data directories
> content in perf report mode.
>
> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
> ---
>  tools/perf/util/data.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
> index c47aa34fdc0a..6ad61ac6ba67 100644
> --- a/tools/perf/util/data.c
> +++ b/tools/perf/util/data.c
> @@ -321,6 +321,10 @@ static int open_dir(struct perf_data *data)
>                 return -1;
>
>         ret = open_file(data);
> +       if (!ret && perf_data__is_dir(data)) {

I think this __is_dir() check is unnecessary since it's checked
from the caller side already.

Thanks
Namhyung


> +               if (perf_data__is_read(data))
> +                       ret = perf_data__open_dir(data);
> +       }
>
>         /* Cleanup whatever we managed to create so far. */
>         if (ret && perf_data__is_write(data))
> --
> 2.24.1
>