Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp5417744pxu; Thu, 22 Oct 2020 01:30:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/RXr2ppjQWwz/crExGhSo3ii04w9QPgvnM4xgc7EkObb7eQyAlg2L4jSExjYBERb5qFKJ X-Received: by 2002:a17:906:1a19:: with SMTP id i25mr1127143ejf.323.1603355456254; Thu, 22 Oct 2020 01:30:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603355456; cv=none; d=google.com; s=arc-20160816; b=S8xykhxmLjxlnSYfv3FGDkL1vdx6LnyJZZAsDcawCsg0TALCsJk9MvPCh0xcErnOPV VXJRRoUkjBkcbRmRT5PY1f2toA3rEW+ZlEKpwfUQt3OSZuQBfXIXF4fElJtZWD6ojlU7 R7fYwFscKqaBUsgznDpDW4di87nzc4ej2lbNIQmbd8IHWqTbNL9zjRdrmIgcpZn/QD6+ lNkKHmDPyHi/5S+TXC5cZxWGLi1HE2NE6MLd0BylJ0z4+Au8asT/gFfFSTLjIjobXXwq /fAGog0do5n9EDFbRyW3BSTihp3dcBnAu5axw7ejogiXu99hZxKS9x/Hs6pQ/WlB1HXk Vd4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=tM0w9LGRKJvbD4tp3T910p8sL4hCKiZmCKVnaniZRNA=; b=ZXquNGcOv0e91k6JLKshp2y3emUTmI5n0zjAEe2bB7HLW8Eq/tknRH8yqdHdBFr4Zg ydoRQW5dkjWkgKMquFW6B2NBcqnR6PflBz8DzEL85Ms23UIoWpFvYH1U06ncR74MCMZI 21ZjXfbNg+G6QitkgLoEDVTU8HZfQxDP2EQYXQCmuc9WXepXzX7XmF23l6pQBKVj20XX 8+p2CqiFp2H0Ee7ayweez6xrT1/buO7ZAAb0tGfNWdfSLbBb9BX7QSKjMnnko4wRsjIJ rjOP1ABME3PuwuMq0nl06tKzk4izNvuIEtoR4Qum7jfAHKrMh0C7NiMXFY6G3e4DuvI4 KxOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=A45eiXQD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp4si427081ejc.117.2020.10.22.01.30.33; Thu, 22 Oct 2020 01:30:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=A45eiXQD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2507870AbgJVFTR (ORCPT + 99 others); Thu, 22 Oct 2020 01:19:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:36076 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437018AbgJVFTR (ORCPT ); Thu, 22 Oct 2020 01:19:17 -0400 Received: from sol.localdomain (172-10-235-113.lightspeed.sntcca.sbcglobal.net [172.10.235.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DA3542145D; Thu, 22 Oct 2020 05:19:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603343956; bh=AzJmVMo5bUTZn0rWFhmYbe4LLj90dDUn7CorUzcxEE0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A45eiXQDEQHZSU3qpky+Lib6UIb+r/i7Io8YwYs0B0N0wtY8+fW9CC7zasD5z/b2U hLnwSi4FiSS8IbbXeQQOlDtvQeaIQag0rD+cH27MlkejR2+1g9Ba37jC/kDL51fLnx sVHVYhNITgwH/G+25LRO9jR5TzzqWxN4Xdz4bb2M= Date: Wed, 21 Oct 2020 22:19:14 -0700 From: Eric Biggers To: Mark Salyzyn Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, Miklos Szeredi , Jonathan Corbet , Vivek Goyal , "Eric W . Biederman" , Amir Goldstein , Randy Dunlap , Stephen Smalley , John Stultz , linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [RESEND PATCH v18 0/4] overlayfs override_creds=off & nested get xattr fix Message-ID: <20201022051914.GI857@sol.localdomain> References: <20201021151903.652827-1-salyzyn@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201021151903.652827-1-salyzyn@android.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 21, 2020 at 08:18:59AM -0700, Mark Salyzyn wrote: > Mark Salyzyn (3): > Add flags option to get xattr method paired to __vfs_getxattr > overlayfs: handle XATTR_NOSECURITY flag for get xattr method > overlayfs: override_creds=off option bypass creator_cred > > Mark Salyzyn + John Stultz (1): > overlayfs: inode_owner_or_capable called during execv > > The first three patches address fundamental security issues that should > be solved regardless of the override_creds=off feature. > > The fourth adds the feature depends on these other fixes. FYI, I didn't receive patch 4, and neither https://lkml.kernel.org/linux-fsdevel nor https://lkml.kernel.org/linux-unionfs have it either. - Eric