Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Marek Szyprowski <m.szyprowski@samsung.com>
Cc:     Andrew Lunn <andrew@lunn.ch>, jim.cromie@gmail.com,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Kukjin Kim <kgene@kernel.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org,
        =?utf-8?Q?Bart=C5=82omiej_=C5=BBolnierkiewicz?= 
        <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v3 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet
 Adapter Driver
Date:   Thu, 22 Oct 2020 12:01:23 +0200
In-Reply-To: <633bbf18-1aec-4b2a-7967-898cde1930aa@samsung.com> (Marek
        Szyprowski's message of "Thu, 22 Oct 2020 09:15:50 +0200")
Message-ID: <dleftjzh4ezij0.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <633bbf18-1aec-4b2a-7967-898cde1930aa@samsung.com>
        <CGME20201022100133eucas1p132ef97a9ac767bd357f50034c47d6d1a@eucas1p1.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2020-10-22 czw 09:15>, when Marek Szyprowski wrote:
> On 21.10.2020 23:49, =C5=81ukasz Stelmach wrote:
>> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be
>> connected to a CPU with a 8/16-bit bus or with an SPI. This driver
>> supports SPI connection.
>>
>> The driver has been ported from the vendor kernel for ARTIK5[2]
>> boards. Several changes were made to adapt it to the current kernel
>> which include:
>>
>> + updated DT configuration,
>> + clock configuration moved to DT,
>> + new timer, ethtool and gpio APIs,
>> + dev_* instead of pr_* and custom printk() wrappers,
>> + removed awkward vendor power managemtn.
>>
>> [1] https://www.asix.com.tw/products.php?op=3DpItemdetail&PItemID=3D104;=
65;86&PLine=3D65
>> [2] https://git.tizen.org/cgit/profile/common/platform/kernel/linux-3.10=
-artik/
>>
>> The other ax88796 driver is for NE2000 compatible AX88796L chip. These
>> chips are not compatible. Hence, two separate drivers are required.
>>
>> Signed-off-by: =C5=81ukasz Stelmach <l.stelmach@samsung.com>
>
> co=C5=9B zaszala=C5=82e=C5=9B, jak dobry korea=C5=84ski kod - push bez ko=
mpilacji ;)
>
> drivers/net/ethernet/asix/ax88796c_main.c:758:13: error: static=20
> declaration of =E2=80=98ax88796c_set_csums=E2=80=99 follows non-static de=
claration
>  =C2=A0static void ax88796c_set_csums(struct ax88796c_device *ax_local)
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 ^
> In file included from drivers/net/ethernet/asix/ax88796c_main.c:12:0:
> drivers/net/ethernet/asix/ax88796c_ioctl.h:24:6: note: previous=20
> declaration of =E2=80=98ax88796c_set_csums=E2=80=99 was here
>  =C2=A0void ax88796c_set_csums(struct ax88796c_device *ax_local);
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^
> scripts/Makefile.build:283: recipe for target=20
> 'drivers/net/ethernet/asix/ax88796c_main.o' failed
> make[4]: *** [drivers/net/ethernet/asix/ax88796c_main.o] Error 1
> scripts/Makefile.build:500: recipe for target=20
> 'drivers/net/ethernet/asix' failed
> make[3]: *** [drivers/net/ethernet/asix] Error 2
> scripts/Makefile.build:500: recipe for target 'drivers/net/ethernet' fail=
ed
> make[2]: *** [drivers/net/ethernet] Error 2
> scripts/Makefile.build:500: recipe for target 'drivers/net' failed
> make[1]: *** [drivers/net] Error 2


Fixed. Thanks.

=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAl+RWHMACgkQsK4enJil
gBCTOAf8DDhl24aKJ6K/V2rIeZIbp78TQD8mv/HjBV8moWhi9TfOYwif3micRUfp
qdKzM4+yIP6B5edSQtu6+/ErHkwXQpDzy7ik2qp28WF2F0HLofn7SyfJGR8JaGEv
/fizTdjtNV7/zmWlyjZuTuHkhADGdiKJ+NLrfFLMmVWKdzttQDGkzBTs5khK2R9O
5yXISyU68eIb3dcANLKlKpjRI31ICQq0IjsHwsaWt9VWxFJ0tDGM4BONc5hcNPsS
aZR+hpm2ytGN8VYYcRd6MlV7WI5hm7X2rE43Hgzh/uwAbM8zrqY62bowtq2TZKM7
mdjObq3VWQK+ZzA0uqmSkX0pW7bLWQ==
=OwYK
-----END PGP SIGNATURE-----
--=-=-=--