Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [systemd-devel] BTI interaction between seccomp filters in
 systemd and glibc mprotect calls, causing service failures
To:     Catalin Marinas <catalin.marinas@arm.com>,
        Lennart Poettering <mzxreary@0pointer.de>
Cc:     Szabolcs Nagy <szabolcs.nagy@arm.com>,
        Florian Weimer <fweimer@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        systemd-devel@lists.freedesktop.org,
        Kees Cook <keescook@chromium.org>,
        Will Deacon <will.deacon@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Mark Brown <broonie@kernel.org>, libc-alpha@sourceware.org,
        Dave Martin <dave.martin@arm.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
References: <8584c14f-5c28-9d70-c054-7c78127d84ea@arm.com>
 <20201022071812.GA324655@gardel-login>
 <87sga6snjn.fsf@oldenburg2.str.redhat.com>
 <511318fd-efde-f2fc-9159-9d16ac8d33a7@gmail.com>
 <20201022082912.GQ3819@arm.com> <20201022083823.GA324825@gardel-login>
 <20201022093104.GB1229@gaia>
From:   Topi Miettinen <toiwoton@gmail.com>
Message-ID: <4e82e730-4e71-35fe-e46e-f032766dedeb@gmail.com>
Date:   Thu, 22 Oct 2020 13:12:09 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201022093104.GB1229@gaia>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 22.10.2020 12.31, Catalin Marinas wrote:
> On Thu, Oct 22, 2020 at 10:38:23AM +0200, Lennart Poettering wrote:
>> On Do, 22.10.20 09:29, Szabolcs Nagy (szabolcs.nagy@arm.com) wrote:
>>>>> The dynamic loader has to process the LOAD segments to get to the ELF
>>>>> note that says to enable BTI.  Maybe we could do a first pass and load
>>>>> only the segments that cover notes.  But that requires lots of changes
>>>>> to generic code in the loader.
>>>>
>>>> What if the loader always enabled BTI for PROT_EXEC pages, but then when
>>>> discovering that this was a mistake, mprotect() the pages without BTI? Then
>>>> both BTI and MDWX would work and the penalty of not getting MDWX would fall
>>>> to non-BTI programs. What's the expected proportion of BTI enabled code vs.
>>>> disabled in the future, is it perhaps expected that a distro would enable
>>>> the flag globally so eventually only a few legacy programs might be
>>>> unprotected?
>>>
>>> i thought mprotect(PROT_EXEC) would get filtered
>>> with or without bti, is that not the case?
>>
>> We can adjust the filter in systemd to match any combination of
>> flags to allow and to deny.
> 
> Yes but Szabolcs' point to Topi was that if we can adjust the filters to
> allow mprotect(PROT_EXEC), why not allow mprotect(PROT_EXEC|PROT_BTI)
> instead? Anyway, I see the MDWX and BTI as complementary policies so
> ideally we shouldn't have to choose between one or the other. If we
> allow mprotect(PROT_EXEC), that would override MDWX and also disable
> BTI.

Allowing mprotect(PROT_EXEC|PROT_BTI) would mean that all you need to 
circumvent MDWX is to add PROT_BTI flag. I'd suggest getting the flags 
right at mmap() time or failing that, reverting the PROT_BTI for legacy 
programs later.

Could the kernel tell the loader of the BTI situation with auxiliary 
vectors? Then it would be easy for the loader to always use the best 
mmap() flags without ever needing to mprotect().

-Topi