Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: rIDdQlgALiuoSJ1dD096SBs0B7om9x/klowQ08DEGFjO8V56oZdGoeYIkIQpztGzAf7SsdkyeG
 FumbZR5brqNA==
IronPort-SDR: W97OYR0agkN6TAlZuHKb58WWV18JKY9PMagwAJUdkPPFOgMMn7bUVubWgpxgo1WWgs/xNz3rx3
 6ub3EJ7AoNfA==
Date:   Wed, 21 Oct 2020 15:39:32 -0700
From:   Andi Kleen <ak@linux.intel.com>
To:     Stephane Eranian <eranian@google.com>
Cc:     linux-kernel@vger.kernel.org, kan.liang@intel.com,
        jolsa@redhat.com, peterz@infradead.org, mingo@elte.hu,
        irogers@google.com, namhyung@kernel.org
Subject: Re: [PATCH] perf/x86/intel: make anythread filter support conditional
Message-ID: <20201021223932.GP466880@tassilo.jf.intel.com>
References: <20201021211612.2026234-1-eranian@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201021211612.2026234-1-eranian@google.com>
Precedence: bulk

On Wed, Oct 21, 2020 at 02:16:12PM -0700, Stephane Eranian wrote:
> Starting with Arch Perfmon v5, the anythread filter on generic counters may be
> deprecated. The current kernel was exporting the any filter without checking.
> On Icelake, it means you could do cpu/event=0x3c,any/ even though the filter
> does not exist. This patch corrects the problem by relying on the CPUID 0xa leaf
> function to determine if anythread is supported or not as described in the
> Intel SDM Vol3b 18.2.5.1 AnyThread Deprecation section.

Reviewed-by: Andi Kleen <ak@linux.intel.com>

-Andi