Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4 2/2] PM / devfreq: Add governor attribute flag for
 specifc sysfs nodes
To:     Dmitry Osipenko <digetx@gmail.com>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Cc:     lukasz.luba@arm.com, enric.balletbo@collabora.com,
        hl@rock-chips.com, thierry.reding@gmail.com, jonathanh@nvidia.com,
        abel.vesa@nxp.com, k.konieczny@samsung.com,
        b.zolnierkie@samsung.com, chanwoo@kernel.org,
        myungjoo.ham@samsung.com, kyungmin.park@samsung.com
From:   Chanwoo Choi <cw00.choi@samsung.com>
Organization: Samsung Electronics
Message-ID: <7ee9dcd8-f326-0bc4-25ba-8f58f22d692c@samsung.com>
Date:   Thu, 22 Oct 2020 11:45:55 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101
        Thunderbird/59.0
MIME-Version: 1.0
In-Reply-To: <b94b5c9d-6bfc-0535-baaf-d0809f74de42@gmail.com>
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20201020030407.21047-1-cw00.choi@samsung.com>
        <CGME20201020025045epcas1p4b26b6f23e2896c2d661b2cfa93505e21@epcas1p4.samsung.com>
        <20201020030407.21047-3-cw00.choi@samsung.com>
        <b94b5c9d-6bfc-0535-baaf-d0809f74de42@gmail.com>
Precedence: bulk

On 10/22/20 11:30 AM, Dmitry Osipenko wrote:
> 20.10.2020 06:04, Chanwoo Choi пишет:
>>  /**
>>   * struct devfreq_governor - Devfreq policy governor
>>   * @node:		list node - contains registered devfreq governors
>>   * @name:		Governor's name
>> + * @attr:		Governor's sysfs attribute flag
>>   * @flags:		Governor's feature flags
>>   * @get_target_freq:	Returns desired operating frequency for the device.
>>   *			Basically, get_target_freq will run
>> @@ -57,6 +68,7 @@ struct devfreq_governor {
>>  	struct list_head node;
>>  
>>  	const char name[DEVFREQ_NAME_LEN];
>> +	const u64 attr;
>>  	const u64 flags;
> 
> What about to use plural for the "attrs" as well?
> 
> 

OK. I'll edit it.


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics