Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 22 Oct 2020 14:57:41 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Jaroslav Kysela <perex@perex.cz>
Cc:     Takashi Iwai <tiwai@suse.com>, Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, Dom Cobley <dom@raspberrypi.com>,
        Dave Stevenson <dave.stevenson@raspberrypi.com>,
        Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Subject: Re: Context expectations in ALSA
Message-ID: <20201022125741.xxibhwgcr2mhxehe@gilmour.lan>
References: <20201022095041.44jytaelnlako54w@gilmour.lan>
 <30226f94-72e9-34d2-17d0-11d2501053f0@perex.cz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="d62deidd5dansznh"
Content-Disposition: inline
In-Reply-To: <30226f94-72e9-34d2-17d0-11d2501053f0@perex.cz>
Precedence: bulk


--d62deidd5dansznh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 22, 2020 at 12:03:19PM +0200, Jaroslav Kysela wrote:
> Dne 22. 10. 20 v 11:50 Maxime Ripard napsal(a):
>=20
> > So, I'm not really sure what I'm supposed to do here. The drivers
> > involved don't appear to be doing anything extraordinary, but the issues
> > lockdep report are definitely valid too. What are the expectations in
> > terms of context from ALSA when running the callbacks, and how can we
> > fix it?
>=20
> I think that you should set the non-atomic flag and wake up the workqueue=
 or
> so from interrupt handler in this case. Call snd_pcm_period_elapsed() fro=
m the
> workqueue not the interrupt handler context.

Yeah, that was my first guess too. However, the DMA driver uses some
kind of generic helpers using a tasklet, so getting rid of it would take
some work and would very likely not be eligible for stable.

Maxime

--d62deidd5dansznh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX5GBwQAKCRDj7w1vZxhR
xTCUAQDTmZkZWcff1PLx6AGpuQLAYMsZuMdLn9JoU1UyOhjCaAEAgN02qADXy1D7
SVTe4zN+/PYjg8cdc9fRz8yI1Udj8ws=
=n3lj
-----END PGP SIGNATURE-----

--d62deidd5dansznh--