Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp5776513pxu; Thu, 22 Oct 2020 10:43:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBm1wpihT7bg4ZF02caJ75RQ5wxFZ/ohhzjg0wN/Z7qOsJgmAvxMdlRDBcMcyRljpw2o3u X-Received: by 2002:a17:906:60d3:: with SMTP id f19mr3508810ejk.141.1603388604941; Thu, 22 Oct 2020 10:43:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603388604; cv=none; d=google.com; s=arc-20160816; b=lXUY46TFwWw8NxTj/QY+XlyIY2EW1YtT1hzETKVcgLRz3z1/5FAj37vtj/MJCuhTqW dAdGN/dl09v3JktXtOCi9YuK5po6fg3ZGl0yq/t1N+i0EauRd/z+jFpjK8vCF/wVr0sk g0uqvpvRNb2/w5U/QdoK0Ksf/sv47AjtNJwgzSAX+mUUYErddhd/zsg7gkqcSNOCQI3H EbC3Q22Rwg1kLsgCbowgqphv9hDDzbHHTc/ObknF5Dd+Bz+uwW+bbnErIbsqQ8Si2N3t Ya8w8gQzlce1oEh8qY4vabl6qXcM0FYSbsbYeqGqUW9eXnFesrGidbCDy+FxzZHK86pA RYOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:ironport-sdr:ironport-sdr; bh=nt3Hi27hx3XXJLMBhYm0ORFOodoEw9u/z0GlnI98+XQ=; b=rFDdkhNWNOIrzKXVU31thxRtM76teDrhquv28bwyN8LHlZGdvS9aSQa7S1N4pEvxJa ARnLhQZ1Cz0adsMcFpmNFpBMXyw78oGQLqYAKcFl+MyS5X57bH2akxLkYW0cQWilIi1f EUtAf7E4+xa4zJldBp/0kKko5A4Qxgy7vT9E5wPm4+DPkVjrdyZnRmyVsWUHHroLRxtN FvXDtcbaRLGohPyf+aDWoy3meheM6hVlFeO9tl1BKDkgiwZpWqAPQGifNX3Ig8Rlu4en 7cezvDuTiZ5x3YFc0SKZuiNMEb8j5IRywB5s22GhxyKNo5OdBk7cOirfnZVs6gC9x+Bk ND4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l8si1125336edr.222.2020.10.22.10.43.02; Thu, 22 Oct 2020 10:43:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S368130AbgJVO2H (ORCPT + 99 others); Thu, 22 Oct 2020 10:28:07 -0400 Received: from mga11.intel.com ([192.55.52.93]:58132 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2444386AbgJVO2H (ORCPT ); Thu, 22 Oct 2020 10:28:07 -0400 IronPort-SDR: cabjaFh+MSpP+fDOSMP9JWjkN4Zo/EAPx77fa+B8RwLhdXtYgf+hs45jNEDqoEhUpntORO3rn7 2nhy+HgTMkrQ== X-IronPort-AV: E=McAfee;i="6000,8403,9781"; a="164041662" X-IronPort-AV: E=Sophos;i="5.77,404,1596524400"; d="scan'208";a="164041662" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2020 07:28:06 -0700 IronPort-SDR: L+dFQT6cHBy65R4Ul9GHwhWOpLgNkoEKrejKSppdTaOe1P95kFBg18MbCJp34PbbvCvvZ4LMCr Lm+NFs0PyrMA== X-IronPort-AV: E=Sophos;i="5.77,404,1596524400"; d="scan'208";a="533985541" Received: from xiaoyaol-mobl.ccr.corp.intel.com (HELO [10.254.213.210]) ([10.254.213.210]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2020 07:28:04 -0700 Subject: Re: [PATCH] KVM: X86: Expose KVM_HINTS_REALTIME in KVM_GET_SUPPORTED_CPUID To: Paolo Bonzini , Wanpeng Li , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel References: <1603330475-7063-1-git-send-email-wanpengli@tencent.com> <6ad94df6-9ecd-e364-296a-34ba41e938b1@intel.com> <31b189e0-503f-157d-7af0-329744ed5369@redhat.com> From: Xiaoyao Li Message-ID: <18e7a0c6-faff-8c4c-0830-a0bc02627a36@intel.com> Date: Thu, 22 Oct 2020 22:28:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <31b189e0-503f-157d-7af0-329744ed5369@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/22/2020 10:06 PM, Paolo Bonzini wrote: > On 22/10/20 15:31, Xiaoyao Li wrote: >>> >>> It's common for userspace to copy all supported CPUID bits to >>> KVM_SET_CPUID2, I don't think this is the right behavior for >>> KVM_HINTS_REALTIME. >> >> It reminds of X86_FEATURE_WAITPKG, which is added to supported CPUID >> recently as a fix but QEMU exposes it to guest only when "-overcommit >> cpu-pm" > > WAITPKG is not included in KVM_GET_SUPPORTED_CPUID either. QEMU detects > it through the MSR_IA32_UMWAIT register. Doesn't 0abcc8f65cc2 ("KVM: VMX: enable X86_FEATURE_WAITPKG in KVM capabilities") add WAITPKG to KVM_GET_SUPPORTED_CPUID? > Paolo >