Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [systemd-devel] BTI interaction between seccomp filters in
 systemd and glibc mprotect calls, causing service failures
To:     Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc:     Florian Weimer <fweimer@redhat.com>,
        Lennart Poettering <mzxreary@0pointer.de>,
        Mark Rutland <mark.rutland@arm.com>,
        systemd-devel@lists.freedesktop.org,
        Kees Cook <keescook@chromium.org>,
        Catalin Marinas <Catalin.Marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Mark Brown <broonie@kernel.org>, libc-alpha@sourceware.org,
        Dave Martin <dave.martin@arm.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
References: <8584c14f-5c28-9d70-c054-7c78127d84ea@arm.com>
 <20201022071812.GA324655@gardel-login>
 <87sga6snjn.fsf@oldenburg2.str.redhat.com>
 <511318fd-efde-f2fc-9159-9d16ac8d33a7@gmail.com>
 <20201022082912.GQ3819@arm.com>
From:   Topi Miettinen <toiwoton@gmail.com>
Message-ID: <55b44a39-ab19-363e-3703-9bf4e7d75f68@gmail.com>
Date:   Thu, 22 Oct 2020 13:03:59 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201022082912.GQ3819@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 22.10.2020 11.29, Szabolcs Nagy wrote:
> The 10/22/2020 11:17, Topi Miettinen via Libc-alpha wrote:
>> On 22.10.2020 10.54, Florian Weimer wrote:
>>> * Lennart Poettering:
>>>> Did you see Topi's comments on the systemd issue?
>>>>
>>>> https://github.com/systemd/systemd/issues/17368#issuecomment-710485532
>>>>
>>>> I think I agree with this: it's a bit weird to alter the bits after
>>>> the fact. Can't glibc set up everything right from the begining? That
>>>> would keep both concepts working.
>>>
>>> The dynamic loader has to process the LOAD segments to get to the ELF
>>> note that says to enable BTI.  Maybe we could do a first pass and load
>>> only the segments that cover notes.  But that requires lots of changes
>>> to generic code in the loader.
>>
>> What if the loader always enabled BTI for PROT_EXEC pages, but then when
>> discovering that this was a mistake, mprotect() the pages without BTI? Then
>> both BTI and MDWX would work and the penalty of not getting MDWX would fall
>> to non-BTI programs. What's the expected proportion of BTI enabled code vs.
>> disabled in the future, is it perhaps expected that a distro would enable
>> the flag globally so eventually only a few legacy programs might be
>> unprotected?
> 
> i thought mprotect(PROT_EXEC) would get filtered
> with or without bti, is that not the case?

It would be filtered, but the idea is that with modern binaries this 
would not happen since the pages would be mapped with mmap(,, PROT_EXEC 
| PROT_BTI,,) which is OK for purposes MDWX. The loader would have to 
use mprotect(PROT_EXEC) to get rid of PROT_BTI only for the legacy binaries.

-Topi