Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp59632pxu; Thu, 22 Oct 2020 15:27:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMkyA5+DY7Old9g+pttymhkDlsUxx+/WkEgGWoOIDzo3ZUtr1NWJBfCath+hhcRY5EPbKj X-Received: by 2002:a17:906:8401:: with SMTP id n1mr4282941ejx.215.1603405677211; Thu, 22 Oct 2020 15:27:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603405677; cv=none; d=google.com; s=arc-20160816; b=FeS7U9raO9h8bCtljZQYf/mlDD4C5ypNX0kF3aBWTGhRJaMkX2VtVURJF2lvRpPswf 4UxiM3Ci4aQXhzXWeXrfEEr77hLtKkcU9beV5rycVI3GADbo5t+6Z8gCSIoimThfqB4n 4sRBaPPIVXXPm/jYUx/BqFILA80vwEvF0CFUsu1ReBMI7ZxOQrPzh4AL3UmIfmG/YfSI nGixAE/nq9VoDc4tgYE3szRbYyjTsZHBk4hnE+6HZxh5cG48WAXQZsV8pr3LKkardjcw 0EqiginoovaiZHBKzXFuB2eD1fxbxkKdWb9yXNXALfuPqKnMM0VYtgrdAMTW8HDaiQIr JgpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:ironport-sdr:ironport-sdr; bh=aa16DxSX2lM3F2qZN8T4tLcYP1ejR8TEwhgkn02cL1Y=; b=ct+n9rhgfkvmk7AOucERQL6nMTwKWq+dpJivtyEVzwMqJzQzy8U80rorYFtK+9Lkvj Qvj46O2sHAW8VhfZj4ARGoXM0fD8NbLRU41cQwoxwQV2KggtxSClnnd5AS8njkINqXqI X5VoMyCZCHBafXCBwTvvZa7I3+pF+fuWeVEjn22rSes7ZR6asZjMSVZRKenUXV7v7vKk eM4n/f/RMuwOTh/AthKO3JzOm/olYtZCCP0lhBfUqNa0iS/7OmIbWM6mTVoa0nsDvx6V AOVKZypS5F4wa7VQ1ekAES4RxbkOBOKFObA1LiKGUVH9/88fPsbCBrVlhg2V5o5sVE1j Ahjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h6si1772773ejd.632.2020.10.22.15.27.34; Thu, 22 Oct 2020 15:27:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2900124AbgJVNba (ORCPT + 99 others); Thu, 22 Oct 2020 09:31:30 -0400 Received: from mga18.intel.com ([134.134.136.126]:7583 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2895506AbgJVNb3 (ORCPT ); Thu, 22 Oct 2020 09:31:29 -0400 IronPort-SDR: /XPzOjJ6zcEjLKA50NUOXgl7YiY9L10KIPrAlG66/C4JYocoRM3gzJ3F9ITvouTeF2rFm/J5cN q7+Tg4caHcOA== X-IronPort-AV: E=McAfee;i="6000,8403,9781"; a="155311058" X-IronPort-AV: E=Sophos;i="5.77,404,1596524400"; d="scan'208";a="155311058" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2020 06:31:27 -0700 IronPort-SDR: ZtHX9vEE2nOZ4DgE3j62VO+vKT9O38aAHAtNNns8UiGdYTeYIXIJKbYDsIEkE3P8KdPxr+zMvO YohhWF1xuGEw== X-IronPort-AV: E=Sophos;i="5.77,404,1596524400"; d="scan'208";a="533968088" Received: from xiaoyaol-mobl.ccr.corp.intel.com (HELO [10.254.213.210]) ([10.254.213.210]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2020 06:31:25 -0700 Subject: Re: [PATCH] KVM: X86: Expose KVM_HINTS_REALTIME in KVM_GET_SUPPORTED_CPUID To: Paolo Bonzini , Wanpeng Li , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel References: <1603330475-7063-1-git-send-email-wanpengli@tencent.com> From: Xiaoyao Li Message-ID: <6ad94df6-9ecd-e364-296a-34ba41e938b1@intel.com> Date: Thu, 22 Oct 2020 21:31:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/22/2020 9:02 PM, Paolo Bonzini wrote: > On 22/10/20 03:34, Wanpeng Li wrote: >> From: Wanpeng Li >> >> Per KVM_GET_SUPPORTED_CPUID ioctl documentation: >> >> This ioctl returns x86 cpuid features which are supported by both the >> hardware and kvm in its default configuration. >> >> A well-behaved userspace should not set the bit if it is not supported. >> >> Suggested-by: Jim Mattson >> Signed-off-by: Wanpeng Li > > It's common for userspace to copy all supported CPUID bits to > KVM_SET_CPUID2, I don't think this is the right behavior for > KVM_HINTS_REALTIME. It reminds of X86_FEATURE_WAITPKG, which is added to supported CPUID recently as a fix but QEMU exposes it to guest only when "-overcommit cpu-pm" > (But maybe this was discussed already; if so, please point me to the > previous discussion). > > Paolo >