Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp103709pxu; Thu, 22 Oct 2020 16:59:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrJ1X+C6HNzYFImQsqeFk8x2v6eXMJDZyuWmcmhr4Zg5Ug2eOEd94dW1zNRQPZaA81nHo6 X-Received: by 2002:a05:6402:1ad9:: with SMTP id ba25mr4682640edb.120.1603411153378; Thu, 22 Oct 2020 16:59:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603411153; cv=none; d=google.com; s=arc-20160816; b=Dr71PVA9cECuLEGFaxVRuPRAnHE9GkZZnwyk4DDGGBegfyrWdG7XniRuJDeCandDeD bjTw04M1LLrfWo58V8QUCEUndMeut4IHdnhwxcwJTnqTx/kefFo1Eb+UBPV5XL03rPB1 Yg9vnOeiH0qAENE2gcHj66ryqKgLMndywWslgGRSMsYSpFRS8Jddj9eIzD6S93J0+ww1 gyd+hbfw7zJF6GK7ckVzsq9dy+xPhQKA8wNoFYbppeA0210ZqqTiEvkZLxjLrnEgY79x cYCQG10pv8ioAoUewIHBzn+2R8nHWhBKy0p6VCPmIkFdeFiEmwV8rKkqnjwdJB9QKsG1 uj9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sQ5Xmcg/9wGewf1aqsxbuSsff3EYWaYFXfjaMu6eJPM=; b=kAP5CmjV4eUjtz/ddWJ1zHDzbldqr3yqooj+BwU3ZY9lvY5VaznQL/bCDFfJsDc6KI SvYrgdy7go0lyPIppHr3SYRpoMdqepI88sjkgpHyOIwiH2imfAYxk8fTnLB1xTiN6GGj gNBNBAxK/RWH7u1ZB1wwn/tS/RG/QCDXOlNvQGanDUUpMRzFfkCIKazPcGDm2Tq8V0Ij OUy4Qte7rJtXl2TI4GXCEW070g9g0JO+PGNTRIp2zNOsqKb3nspgp0907oUg/EVJ/MWD VOM9jU50UU2BigLfJhmhpRJ+f1GKxOUnJtsxLaIFdQOsPwEBJUTid8lxuZgggwbcTBME CP9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=NHzfoahN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q25si1886876edw.184.2020.10.22.16.58.50; Thu, 22 Oct 2020 16:59:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=NHzfoahN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2901374AbgJVPVu (ORCPT + 99 others); Thu, 22 Oct 2020 11:21:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2901369AbgJVPVu (ORCPT ); Thu, 22 Oct 2020 11:21:50 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DBCFC0613CE; Thu, 22 Oct 2020 08:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sQ5Xmcg/9wGewf1aqsxbuSsff3EYWaYFXfjaMu6eJPM=; b=NHzfoahNst/RyH/HXY3XWvQcoI Vq+uirgzYCYecuo5YW+6OmTEjT+55Qyp/2Up6lagOo/nNtQ349C956mJ1FkVCCOEhFWP7uZUs167p x3XCj8ianvPUSNXz2S/IqlIxmTs/Z3n8s9oXN6Qs4umCe1uqIsZwzUKZRE/Qk8lq1HwYo4tyAahFn 7ItUOJkS9tM08SETI5p17l1yXKpP/i/7lyhpHz2kVxOqif34yrl8bZ8P+KaaaDdCmFS1qKM6DlOmg +FM0OcPYlRipP70RLayf7Y4JQBVMygxyyyLa4dtf5qj1MAgD3oFUYa7tqPmBtTwQYP1fANdt6J2Wg QLN1xOdg==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVcPU-0006bh-Cj; Thu, 22 Oct 2020 15:21:48 +0000 Date: Thu, 22 Oct 2020 16:21:48 +0100 From: Christoph Hellwig To: Zhenzhong Duan Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, bhelgaas@google.com Subject: Re: [PATCH 1/2] PCI: export pci_match_device() Message-ID: <20201022152148.GA23673@infradead.org> References: <20201021081030.160-1-zhenzhong.duan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201021081030.160-1-zhenzhong.duan@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 21, 2020 at 04:10:29PM +0800, Zhenzhong Duan wrote: > pci_match_id() is deprecated as it doesn't catch any dynamic ids that > a driver might want to check for. > > Export pci_match_device() as a replacement which supports both dynamic > and static ids. You don't actually seems to add any user outside of the PCI core, so I think you only need to drop the static specifier and add a prototype.