Date: Sun, 13 Aug 2006 17:28:59 +0200
From: Adrian Bunk <bunk@stusta.de>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH for review] [123/145] i386: make fault notifier unconditional and export it
Message-ID: <20060813152859.GB3543@stusta.de>
References: <20060810935.775038000@suse.de> <20060810193722.8082B13B8E@wotan.suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060810193722.8082B13B8E@wotan.suse.de>
User-Agent: Mutt/1.5.12-2006-07-14
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1323
Lines: 37

> It's needed for external debuggers and overhead is very small.
>...

We are currently trying to remove exports not used by any in-kernel 
code.

The patch description also lacks the name of what you call "external 
debuggers" (I assume the exports are not for a theoretical usage but for 
an already existing debugger?). There is no reason for keeping a patch 
description small.

Especially nowadays where people demand deprecation periods for removing 
exports without any in-kernel users there must be a _very_ good 
justification when adding such exports.

This is true for both the i386 and the x86_64 patches.

cu
Adrian

BTW1: The subject of this email is wrong (it's the x86_64 patch).
BTW2: Please use a valid To: header.

-- 

    Gentoo kernels are 42 times more popular than SUSE kernels among
    KLive users  (a service by SUSE contractor Andrea Arcangeli that
    gathers data about kernels from many users worldwide).

       There are three kinds of lies: Lies, Damn Lies, and Statistics.
                                                    Benjamin Disraeli

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/