Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751290AbWHMPrb (ORCPT ); Sun, 13 Aug 2006 11:47:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751293AbWHMPrb (ORCPT ); Sun, 13 Aug 2006 11:47:31 -0400 Received: from filfla-vlan276.msk.corbina.net ([213.234.233.49]:6540 "EHLO screens.ru") by vger.kernel.org with ESMTP id S1751290AbWHMPrb (ORCPT ); Sun, 13 Aug 2006 11:47:31 -0400 Date: Mon, 14 Aug 2006 00:11:18 +0400 From: Oleg Nesterov To: Andrew Morton , David Howells Cc: linux-kernel@vger.kernel.org, "Eric W. Biederman" Subject: [PATCH] elf_fdpic_core_dump: don't take tasklist_lock Message-ID: <20060813201118.GA159@oleg> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1324 Lines: 40 do_each_thread() is rcu-safe, and all tasks which use this ->mm must sleep in wait_for_completion(&mm->core_done) at this point, so we can use RCU locks. Also, remove unneeded INIT_LIST_HEAD(new) before list_add(new, head). Signed-off-by: Oleg Nesterov --- 2.6.18-rc3/fs/binfmt_elf_fdpic.c~fdpic 2006-07-16 01:53:08.000000000 +0400 +++ 2.6.18-rc3/fs/binfmt_elf_fdpic.c 2006-08-14 00:05:27.000000000 +0400 @@ -1597,20 +1597,19 @@ static int elf_fdpic_core_dump(long sign if (signr) { struct elf_thread_status *tmp; - read_lock(&tasklist_lock); + rcu_read_lock(); do_each_thread(g,p) if (current->mm == p->mm && current != p) { tmp = kzalloc(sizeof(*tmp), GFP_ATOMIC); if (!tmp) { - read_unlock(&tasklist_lock); + rcu_read_unlock(); goto cleanup; } - INIT_LIST_HEAD(&tmp->list); tmp->thread = p; list_add(&tmp->list, &thread_list); } while_each_thread(g,p); - read_unlock(&tasklist_lock); + rcu_read_unlock(); list_for_each(t, &thread_list) { struct elf_thread_status *tmp; int sz; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/