Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp500819pxu;
        Fri, 23 Oct 2020 06:34:19 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzuVg3RAhygBPijNbUk7SKY6/H07ecvrgR6Lai7BpFMx9Q728Nwb5qNtTCzFdqXyPIHmO0/
X-Received: by 2002:a17:906:1446:: with SMTP id q6mr2005799ejc.549.1603460059121;
        Fri, 23 Oct 2020 06:34:19 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1603460059; cv=none;
        d=google.com; s=arc-20160816;
        b=leSjdBUlQQd5ZOnWENzxtnjbANUHeNDJQ8HeRw9qLPIa1wX6yGl7vxeYNd+aViDUmF
         xHJztFlc2HImg5TaHIXS+Psif4d9OKv58R7/zSJRg2kW82k+9nW959eidu78JqYKHelv
         RbUmtvGb6Vz8C+xS1Peu5hJVPzV/ImbmhoQ4R/yEIqMzyP4JxRIME1KZvDOzYUWbJMWP
         CwEWX5Dnh/m7/JVIIuCndLWd3xBBTR45m+FWtkYsAEMSCjHGZPefg8+l8IBUKOmKW1PJ
         tYRVQrVN+mtyG5CXK1950RWVvdrDG2x4LVC3mtnF0MB6mbqmufb6pxjc8tEDMhEi5mif
         z4DA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:references:message-id:in-reply-to
         :subject:cc:to:from:date;
        bh=ooy4jXSFouEa0prYJMO0+czN5IxuD8bIls9PEsWuigQ=;
        b=B75k3voiwDsjAGiasXyNaxmwdxGfYCRHgLS0i2NgQuEPQWEIigoacSvO72Nu1eQiA/
         cNxucabmAy5hXWiCt4XmkQkk6AIm5vq8yE3g43djirbJqEV8y956UDwbq3so2eFbkkf3
         crS7p6Sm2sphmt+ZvnqcdquvnrlHJYMBSHPt2HAmizBQkrJOYRE8NFoZgD6kXE2A+qm5
         NolvcbXX6cvCZ/qGOchs4878zVqha4VOtYGfXolFrwgEC+nV3CX9C5x8Nh7HUPRADAF+
         Ve2W3bTY5/PfWypE1Z6HqkV8+wGT1zJ6NhJ/+ii0RdvKrGwI/orvrm2AGFMlZaeFWqio
         T4rQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id m16si761196eds.221.2020.10.23.06.33.57;
        Fri, 23 Oct 2020 06:34:19 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S368337AbgJWDVG (ORCPT <rfc822;sduhuangshuai@gmail.com>
        + 99 others); Thu, 22 Oct 2020 23:21:06 -0400
Received: from kvm5.telegraphics.com.au ([98.124.60.144]:45734 "EHLO
        kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2508276AbgJWDVF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 22 Oct 2020 23:21:05 -0400
Received: from localhost (localhost.localdomain [127.0.0.1])
        by kvm5.telegraphics.com.au (Postfix) with ESMTP id 4933A20696;
        Thu, 22 Oct 2020 23:21:01 -0400 (EDT)
Date:   Fri, 23 Oct 2020 14:21:11 +1100 (AEDT)
From:   Finn Thain <fthain@telegraphics.com.au>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
cc:     Laurent Vivier <laurent@vivier.eu>,
        Brad Boyer <brad@allandria.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Joshua Thompson <funaho@jurai.org>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        linux-m68k <linux-m68k@lists.linux-m68k.org>,
        Paul Mackerras <paulus@samba.org>,
        linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
        Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH] serial: pmac_zilog: don't init if zilog is not
 available
In-Reply-To: <CAMuHMdVbo2C1yZ5E_A3L8J1zZigO8i8m5AFUTn9SjbY1sx16kA@mail.gmail.com>
Message-ID: <alpine.LNX.2.23.453.2010231412260.6@nippy.intranet>
References: <20201020162303.1730562-1-laurent@vivier.eu> <20201020162844.GA865546@kroah.com> <468bbbef-4745-3b16-b6f4-30b46ebcdc33@vivier.eu> <20201020173745.GA882703@kroah.com> <387fd2aa-b181-c41f-0581-0a7e79a44e41@vivier.eu> <20201020183246.GA912431@kroah.com>
 <b52e7fde-8874-3c53-ca13-7709656b69fb@vivier.eu> <20201020224446.GA15066@allandria.com> <alpine.LNX.2.23.453.2010211038390.6@nippy.intranet> <311d17ed-75fa-a7fe-6c70-177a6eec4519@vivier.eu> <alpine.LNX.2.23.453.2010221347000.6@nippy.intranet>
 <CAMuHMdVbo2C1yZ5E_A3L8J1zZigO8i8m5AFUTn9SjbY1sx16kA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 22 Oct 2020, Geert Uytterhoeven wrote:

> 
> Thanks for your patch...
> 

You're welcome.

> I can't say I'm a fan of this...
> 

Sorry.

> 
> The real issue is this "extern struct platform_device scc_a_pdev, 
> scc_b_pdev", circumventing the driver framework.
> 
> Can we get rid of that?
> 

Is there a better alternative?

pmz_probe() is called by console_initcall(pmz_console_init) when 
CONFIG_SERIAL_PMACZILOG_CONSOLE=y because this has to happen earlier than 
the normal platform bus probing which takes place later as a typical 
module_initcall.