Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp632247pxu; Fri, 23 Oct 2020 09:23:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrL3/bL6yAvXjeNEODcmUmtjnTQ/blX/cuhVESdnH2acrFjrPOHHeKrbheIL3C2w7dQBk6 X-Received: by 2002:a50:e446:: with SMTP id e6mr3068871edm.259.1603470218901; Fri, 23 Oct 2020 09:23:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603470218; cv=none; d=google.com; s=arc-20160816; b=aM8nFI0IiKLO/90pRETl4u0GZyXrVggEZHHw4tcVIlnQn2WWpb6v16MboXCmtaCEej xjldaTE1GuzvW9MJohsRbznetaqALHC76pnoXEHl1BF59et4wwUgLJWfkOkbL4rQi83/ bkqUUK9oxmhSuP4/LpbFakwA28F+LzkI+p9A2vsGsYF2irDYmdKkfldNrX465LW9djFa wtAZMO4/lM+mSP/6hFXY6KvQUxcMVIEs3O+fqzBDc0gkZ5dnaO3ygL6ameuvRx1YHSCA tPDAKMkZj481lcUSeQGB3Y1DVI6DUIpOEDbmRcoM5mWUeETXwAswB1vvXewc/7aySll7 Y8PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:sender :in-reply-to:references:mime-version:dkim-signature; bh=3rcXVSOL+tJRZBQm0pw/Zq9ogwm9bItd4VPlftbM00g=; b=aUKPn/15Elex/Yol4yKXoJUq2yQO1CA2KBE3hiJMZiSHSLYwtjI56OVI8LJN+GdNbI TW8c+nSYgftP7vpwpNb31dsDFY9t8ebUYx4mIGOuN3I2Qkxkg/+r2NJZ76qw3cMitdjf Ymt5SnkA5gPf0oC8D61NDXnP6BTHP2M51EG+ZV64qhfWUquoMoyanAccPBHFFeyYT9++ xNHwlOZXJh3wvTyshCZ7NbB214zKzvbYGniG57Jm5QTzqGjxNXb57pGOgREbx3Enz8hg nrSSefZ3S02y0yg6zI7PBiYp8EWJc9y6WyexHH3cEYBp8in1bfu9Vvq9XUtZkq/5arS3 rJWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Bge8D9q4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a15si1423694eju.63.2020.10.23.09.23.16; Fri, 23 Oct 2020 09:23:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Bge8D9q4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S374706AbgJWOWA (ORCPT + 99 others); Fri, 23 Oct 2020 10:22:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S374556AbgJWOV6 (ORCPT ); Fri, 23 Oct 2020 10:21:58 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82F17C0613CE; Fri, 23 Oct 2020 07:21:58 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id gs25so2664176ejb.1; Fri, 23 Oct 2020 07:21:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:sender:from:date:message-id :subject:to:cc; bh=3rcXVSOL+tJRZBQm0pw/Zq9ogwm9bItd4VPlftbM00g=; b=Bge8D9q4Ck+6oQR5swtz7kx/CVmO3H/gxI93IJbbAM8yPEyVzaym+n/+CREN6Aya6V 48qAhym76RmXks5OZYbeJqEh6rZj+GDw+9zgBKjBjHpYCpiUckLxwxM85Wxpqws4WCG1 kw6bp5+QWJAyIUd+vV5gVlCvpkg6SRKDSM36LJ0w3RW/wqdmznrdb01WoNfYVcRo/yjK hqHr633nbepgJoGUrk2p+PeYO9lOG9GAetosPfND6Lk0euVNFd0YRCH46VaYi3reDIqo 37IYNKd0A/k96+BQXtXDcD8KJ3EuGkf0xITNm34FzUeTWudaHg33pg9qPLWTONieWWhM WLoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:sender:from :date:message-id:subject:to:cc; bh=3rcXVSOL+tJRZBQm0pw/Zq9ogwm9bItd4VPlftbM00g=; b=d+uvW5Uq7QAr2ik/Wd7pq7jboStl0nEaMdZFcU8o1/ztx5XB2hoelmkUWOcakBvlB/ JuHII/rV5Es+l6Ifz7DazUwamEsVaM1P+63k8eypveWfxIgYCKb959WyL97r0DxC5sSU 8KIow+zHfZtcquhW8YMGSZG9I6d3U8kkGU4Ho8H3iZX4ZMxGn/ESDdChgsRUGrFNKUXy i2M89dKNwroXn2PJhbT73YubR/jVcgCdRHWvYjgZ/lUe6dc3yScQ0SVETdxxgczZb/3m LyreTGXvvPZetzLALY+LHkNNX87pQNvk6ZSoLr+PPcX3LYWGJ79ysJ/y4uG8TryRKFMX arBA== X-Gm-Message-State: AOAM532Z60mF6n7d/YMCs3wVU4I1vlTt9Pfw96xYb/CLpnU+sH8VHXZn /FN6hWemwQqgJXF64b6E7r2U8nfRs+F6lcf1Da8= X-Received: by 2002:a17:906:33c7:: with SMTP id w7mr2067255eja.398.1603462917224; Fri, 23 Oct 2020 07:21:57 -0700 (PDT) MIME-Version: 1.0 References: <20180129005948.7714-1-bjorn.andersson@linaro.org> In-Reply-To: <20180129005948.7714-1-bjorn.andersson@linaro.org> Sender: getarunks@gmail.com X-Google-Sender-Delegation: getarunks@gmail.com From: Arun KS Date: Fri, 23 Oct 2020 19:51:45 +0530 X-Google-Sender-Auth: _vvNSE9j93IlwHnXLdmbEcZjtDI Message-ID: Subject: Re: [PATCH] pinctrl: msm: Use dynamic GPIO numbering To: Bjorn Andersson Cc: Linus Walleij , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Timur Tabi , Arun KS Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 29, 2018 at 8:30 AM Bjorn Andersson wrote: > > The base of the TLMM gpiochip should not be statically defined as 0, fix > this to not artificially restrict the existence of multiple pinctrl-msm > devices. Can someone please provide the details why this is needed for pinctrl-msm. Is there any msm-chipset using multiple tlmm devices? I m only concerned because, after this change, the use of gpio number from user space has become a little difficult. Can we merge the patch from Timur to maintain the past behavior when multiple tlmm devices are not present, which is most likely the case? static int base = 0; chip->base = base; base = -1; Regards, Arun > > Fixes: f365be092572 ("pinctrl: Add Qualcomm TLMM driver") > Reported-by: Timur Tabi > Signed-off-by: Bjorn Andersson > --- > drivers/pinctrl/qcom/pinctrl-msm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c > index 495432f3341b..95e5c5ea40af 100644 > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > @@ -818,7 +818,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl) > return -EINVAL; > > chip = &pctrl->chip; > - chip->base = 0; > + chip->base = -1; > chip->ngpio = ngpio; > chip->label = dev_name(pctrl->dev); > chip->parent = pctrl->dev; > -- > 2.15.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html