Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 23 Oct 2020 15:48:42 +0100
From:   Sudeep Holla <sudeep.holla@arm.com>
To:     claude yen <claude.yen@mediatek.com>
Cc:     "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        wsd_upstream@mediatek.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PM / s2idle: Export s2idle_set_ops
Message-ID: <20201023144842.zos4pvpwv4r3rv4j@bogus>
References: <20201022061748.13730-1-claude.yen@mediatek.com>
 <20201022061748.13730-2-claude.yen@mediatek.com>
 <20201022070154.hqvksoj4nss3er2e@bogus>
 <1603427300.7573.6.camel@mtkswgap22>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1603427300.7573.6.camel@mtkswgap22>
User-Agent: NeoMutt/20171215
Precedence: bulk

On Fri, Oct 23, 2020 at 12:28:20PM +0800, claude yen wrote:
> On Thu, 2020-10-22 at 08:02 +0100, Sudeep Holla wrote:
> > On Thu, Oct 22, 2020 at 02:17:48PM +0800, Claude Yen wrote:
> > > As suspend_set_ops is exported in commit a5e4fd8783a2
> > > ("PM / Suspend: Export suspend_set_ops, suspend_valid_only_mem"),
> > > exporting s2idle_set_ops to make kernel module setup s2idle ops too.
> > > 
> > > In this way, kernel module can hook platform suspend
> > > functions regardless of Suspend-to-Ram(S2R) or
> > > Suspend-to-Idle(S2I)
> > >
> > 
> > If this is for arm64 platform, then NACK. You must use PSCI and it will
> > set the ops and it can't be module.
> > 
> 
> PSCI uses suspend_set_ops instead. And suspend_set_ops has been
> exported years ago.
> 
> Suspend-to_Idle(S2I) is another suspend method supported by linux
> kernel. The corresponding s2idle_ops can be hooked by s2idle_set_ops
> by underlying platforms.  For example, S2I is now introduced into
> Mediatek SoC platforms. Besides, power management driver is built as
> kernel module.
> 
> Mobile platforms are now call for kernel drivers to be kernel modules.
> This could help drivers easier to migrate to newer linux kernel.
> Ref: https://linuxplumbersconf.org/event/7/contributions/790/
> 

I understand that. But I am interested in looking at the module you want
to use this and how that interacts with PSCI. If this is arm64, you must
use PSCI for system suspend and cpu suspend. What does this module do on
top of those is what I want to know. Please post that module or point
me if it is already present in the tree.

-- 
Regards,
Sudeep